X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FMethod%2FDelegation.pm;h=1118b1e1d4258b40417df0447b3c60caf151c093;hb=0f8380b0cdbda1e13ed7c456edd3f0d1c0315ec9;hp=05bf31d3b78ba6da533b3397a593b1587960c5b8;hpb=d344c3feeb1c99183a249e26ddfb0e790101f7b2;p=gitmo%2FMoose.git

diff --git a/lib/Moose/Meta/Method/Delegation.pm b/lib/Moose/Meta/Method/Delegation.pm
index 05bf31d..1118b1e 100644
--- a/lib/Moose/Meta/Method/Delegation.pm
+++ b/lib/Moose/Meta/Method/Delegation.pm
@@ -7,7 +7,7 @@ use warnings;
 use Carp         'confess';
 use Scalar::Util 'blessed', 'weaken';
 
-our $VERSION   = '0.68';
+our $VERSION   = '0.86';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
@@ -70,20 +70,32 @@ sub _initialize_body {
     # NOTE: we used to do a goto here, but the goto didn't handle
     # failure correctly (it just returned nothing), so I took that
     # out. However, the more I thought about it, the less I liked it
-    # doing the goto, and I prefered the act of delegation being
+    # doing the goto, and I preferred the act of delegation being
     # actually represented in the stack trace.  - SL
+    # not inlining this, since it won't really speed things up at
+    # all... the only thing that would end up different would be
+    # interpolating in $method_to_call, and a bunch of things in the
+    # error handling that mostly never gets called - doy
     $self->{body} = sub {
         my $instance = shift;
         my $proxy    = $instance->$accessor();
-        ( defined $proxy )
-            || $self->throw_error(
-            "Cannot delegate $handle_name to $method_to_call because "
-                . "the value of "
-                . $self->name
-                . " is not defined",
-            method_name => $method_to_call,
-            object      => $instance
+
+        my $error
+            = !defined $proxy ? ' is not defined'
+            : !blessed $proxy ? qq{ is not an object (got '$proxy')}
+            :                   undef;
+
+        if ($error) {
+            $self->throw_error(
+                "Cannot delegate $handle_name to $method_to_call because "
+                    . "the value of "
+                    . $self->associated_attribute->name
+                    . $error,
+                method_name => $method_to_call,
+                object      => $instance
             );
+        }
+
         $proxy->$method_to_call(@_);
     };
 }
@@ -117,17 +129,16 @@ methods.
 
 =over 4
 
-=item B<new (%options)>
+=item B<< Moose::Meta::Method::Delegation->new(%options) >>
 
-This creates the method based on the criteria in C<%options>,
-these options are:
+This creates the delegation methods based on the provided C<%options>.
 
 =over 4
 
 =item I<attribute>
 
 This must be an instance of C<Moose::Meta::Attribute> which this
-accessor is being generated for. This parameter is B<required>.
+accessor is being generated for. This options is B<required>.
 
 =item I<delegate_to_method>
 
@@ -136,19 +147,20 @@ delegate. This can be either a method name or a code reference.
 
 =back
 
-=item B<associated_attribute>
+=item B<< $metamethod->associated_attribute >>
 
 Returns the attribute associated with this method.
 
-=item B<delegate_to_method>
+=item B<< $metamethod->delegate_to_method >>
 
-Returns the method to which this method delegates.
+Returns the method to which this method delegates, as passed to the
+constructor.
 
 =back
 
 =head1 BUGS
 
-All complex software has bugs lurking in it, and this module is no 
+All complex software has bugs lurking in it, and this module is no
 exception. If you find a bug please either email me, or add the bug
 to cpan-RT.