X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FMethod%2FConstructor.pm;h=62475d2dc8690a0ee97bee24a3d2a2599e419fdf;hb=a3319906531cef2b41a87138e75461ced7a3394b;hp=b32cefe311346e666e2335dadae94c5035421260;hpb=a7be0f8593e4e7b7f570f49027ee4f8f25d4d8bc;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Method/Constructor.pm b/lib/Moose/Meta/Method/Constructor.pm index b32cefe..62475d2 100644 --- a/lib/Moose/Meta/Method/Constructor.pm +++ b/lib/Moose/Meta/Method/Constructor.pm @@ -6,11 +6,11 @@ use warnings; use Scalar::Util 'blessed', 'weaken', 'looks_like_number'; -our $VERSION = '0.69'; +our $VERSION = '0.73_01'; our $AUTHORITY = 'cpan:STEVAN'; use base 'Moose::Meta::Method', - 'Class::MOP::Method::Generated'; + 'Class::MOP::Method::Constructor'; sub new { my $class = shift; @@ -25,15 +25,10 @@ sub new { || $class->throw_error("You must supply the package_name and name parameters $Class::MOP::Method::UPGRADE_ERROR_TEXT"); my $self = bless { - # from our superclass 'body' => undef, 'package_name' => $options{package_name}, 'name' => $options{name}, - # specific to this subclass 'options' => $options{options}, - 'meta_instance' => $meta->get_meta_instance, - 'attributes' => [ $meta->compute_all_applicable_attributes ], - # ... 'associated_metaclass' => $meta, } => $class; @@ -42,7 +37,7 @@ sub new { # needed weaken($self->{'associated_metaclass'}); - $self->initialize_body; + $self->_initialize_body; return $self; } @@ -63,7 +58,7 @@ sub can_be_inlined { grep { $_ ne $expected_class } $metaclass->linearized_isa ) { - my $transformer = $meta->get_immutable_transformer; + my $transformer = $meta->immutable_transformer; # This is actually a false positive if we're in a subclass of # this class, _and_ the expected class is not overridden (but @@ -81,7 +76,10 @@ sub can_be_inlined { if ( $constructor->body != $expected_class->can('new') ) { my $warning = "Not inlining a constructor for $class since it is not" - . " inheriting the default $expected_class constructor\n"; + . " inheriting the default $expected_class constructor\n" + . "If you are certain you don't need to inline your" + . " constructor, specify inline_constructor => 0 in your" + . " call to $class->meta->make_immutable\n"; $warning .= " (constructor has method modifiers which would be lost if it were inlined)\n" if $constructor->isa('Class::MOP::Method::Wrapped'); @@ -105,21 +103,9 @@ sub _expected_constructor_class { return 'Moose::Object'; } -## accessors - -sub options { (shift)->{'options'} } -sub meta_instance { (shift)->{'meta_instance'} } -sub attributes { (shift)->{'attributes'} } - -sub associated_metaclass { (shift)->{'associated_metaclass'} } - ## method -# this was changed in 0.41, but broke MooseX::Singleton, so try to catch -# any other code using the original broken spelling -sub intialize_body { Moose->throw_error("Please correct the spelling of 'intialize_body' to 'initialize_body'") } - -sub initialize_body { +sub _initialize_body { my $self = shift; # TODO: # the %options should also include a both @@ -132,20 +118,17 @@ sub initialize_body { $source .= "\n" . 'my $class = shift;'; $source .= "\n" . 'return $class->Moose::Object::new(@_)'; - $source .= "\n" . ' if $class ne \'' . $self->associated_metaclass->name . '\';'; - - $source .= "\n" . 'my $params = ' . $self->_generate_BUILDARGS('$class', '@_'); - - $source .= ";\n" . 'my $instance = ' . $self->meta_instance->inline_create_instance('$class'); + $source .= "\n if \$class ne '" . $self->associated_metaclass->name + . "';\n"; - $source .= ";\n" . (join ";\n" => map { - $self->_generate_slot_initializer($_) - } 0 .. (@{$self->attributes} - 1)); + $source .= $self->_generate_params('$params', '$class'); + $source .= $self->_generate_instance('$instance', '$class'); + $source .= $self->_generate_slot_initializers; - $source .= ";\n" . $self->_generate_triggers(); + $source .= $self->_generate_triggers(); $source .= ";\n" . $self->_generate_BUILDALL(); - $source .= ";\n" . 'return $instance'; + $source .= ";\nreturn \$instance"; $source .= ";\n" . '}'; warn $source if $self->options->{debug}; @@ -158,7 +141,7 @@ sub initialize_body { # because the inlined code is using the index of the attributes # to determine where to find the type constraint - my $attrs = $self->attributes; + my $attrs = $self->_attributes; my @type_constraints = map { $_->can('type_constraint') ? $_->type_constraint : undef @@ -177,10 +160,28 @@ sub initialize_body { '@type_constraint_bodies' => \@type_constraint_bodies, }, ) or $self->throw_error("Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@", error => $@, data => $source ); - + $self->{'body'} = $code; } +sub _generate_params { + my ( $self, $var, $class_var ) = @_; + "my $var = " . $self->_generate_BUILDARGS( $class_var, '@_' ) . ";\n"; +} + +sub _generate_instance { + my ( $self, $var, $class_var ) = @_; + "my $var = " + . $self->_meta_instance->inline_create_instance($class_var) . ";\n"; +} + +sub _generate_slot_initializers { + my ($self) = @_; + return (join ";\n" => map { + $self->_generate_slot_initializer($_) + } 0 .. (@{$self->_attributes} - 1)) . ";\n"; +} + sub _generate_BUILDARGS { my ( $self, $class, $args ) = @_; @@ -190,7 +191,7 @@ sub _generate_BUILDARGS { return join("\n", 'do {', $self->_inline_throw_error('"Single parameters to new() must be a HASH ref"', 'data => $_[0]'), - ' if scalar @_ == 1 && defined $_[0] && ref($_[0]) ne q{HASH};', + ' if scalar @_ == 1 && !( defined $_[0] && ref $_[0] eq q{HASH} );', '(scalar @_ == 1) ? {%{$_[0]}} : {@_};', '}', ); @@ -211,34 +212,39 @@ sub _generate_BUILDALL { sub _generate_triggers { my $self = shift; my @trigger_calls; - foreach my $i (0 .. $#{ $self->attributes }) { - my $attr = $self->attributes->[$i]; - if ($attr->can('has_trigger') && $attr->has_trigger) { - if (defined(my $init_arg = $attr->init_arg)) { - push @trigger_calls => ( - '(exists $params->{\'' . $init_arg . '\'}) && do {' . "\n " - . '$attrs->[' . $i . ']->trigger->(' - . '$instance, ' - . $self->meta_instance->inline_get_slot_value( - '$instance', - ("'" . $attr->name . "'") - ) - . ', ' - . '$attrs->[' . $i . ']' - . ');' - ."\n}" - ); - } - } + foreach my $i ( 0 .. $#{ $self->_attributes } ) { + my $attr = $self->_attributes->[$i]; + + next unless $attr->can('has_trigger') && $attr->has_trigger; + + my $init_arg = $attr->init_arg; + + next unless defined $init_arg; + + push @trigger_calls => '(exists $params->{\'' + . $init_arg + . '\'}) && do {' + . "\n " + . '$attrs->[' + . $i + . ']->trigger->(' + . '$instance, ' + . $self->_meta_instance->inline_get_slot_value( + '$instance', + $attr->name, + ) + . ', ' + . ');' . "\n}"; } - return join ";\n" => @trigger_calls; + + return join ";\n" => @trigger_calls; } sub _generate_slot_initializer { my $self = shift; my $index = shift; - my $attr = $self->attributes->[$index]; + my $attr = $self->_attributes->[$index]; my @source = ('## ' . $attr->name); @@ -317,9 +323,9 @@ sub _generate_slot_assignment { } else { $source = ( - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, $value ) . ';' ); @@ -330,9 +336,9 @@ sub _generate_slot_assignment { if ($is_moose && $attr->is_weak_ref) { $source .= ( "\n" . - $self->meta_instance->inline_weaken_slot_value( + $self->_meta_instance->inline_weaken_slot_value( '$instance', - ("'" . $attr->name . "'") + $attr->name ) . ' if ref ' . $value . ';' ); @@ -408,28 +414,37 @@ Moose::Meta::Method::Constructor - Method Meta Object for constructors =head1 DESCRIPTION -This is a subclass of L which handles -constructing an appropriate Constructor methods. This is primarily -used in the making of immutable metaclasses, otherwise it is -not particularly useful. +This class is a subclass of L that +provides additional Moose-specific functionality + +To understand this class, you should read the the +L documentation as well. + +=head1 INHERITANCE + +C is a subclass of +L I L. =head1 METHODS =over 4 -=item B - -=item B +=item B<< $metamethod->can_be_inlined >> -=item B +This returns true if the method can inlined. -=item B +First, it looks at all of the parents of the associated class. If any +of them have an inlined constructor, then the constructor can be +inlined. -=item B +If none of them have been inlined, it checks to make sure that the +pre-inlining constructor for the class matches the constructor from +the expected class. -=item B +By default, it expects this constructor come from L, +but subclasses can change this expectation. -=item B +If the constructor cannot be inlined it warns that this is the case. =back