X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FMethod%2FAccessor.pm;h=837eb1de76b775835c5c993afde33a091b860a69;hb=7a431e9c3e8c7ccf455d775c939ea85bd7d7dc30;hp=413b5b90e8bb48e1e1487c19761e73f3c76e61e2;hpb=cecd110f54f5f07e2f06748ee611db4c2852c0a4;p=gitmo%2FMoose.git

diff --git a/lib/Moose/Meta/Method/Accessor.pm b/lib/Moose/Meta/Method/Accessor.pm
index 413b5b9..837eb1d 100644
--- a/lib/Moose/Meta/Method/Accessor.pm
+++ b/lib/Moose/Meta/Method/Accessor.pm
@@ -4,194 +4,284 @@ package Moose::Meta::Method::Accessor;
 use strict;
 use warnings;
 
-use Carp 'confess';
-
-our $VERSION = '0.03';
+our $VERSION   = '1.18';
+$VERSION = eval $VERSION;
+our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Moose::Meta::Method',
          'Class::MOP::Method::Accessor';
 
-## Inline method generators
-
-sub generate_accessor_method_inline {
-    my $self      = shift;
-    my $attr      = $self->associated_attribute; 
-    my $attr_name = $attr->name;
-
-    my $value_name = $attr->should_coerce ? '$val' : '$_[1]';
-	my $mi = $attr->associated_class->get_meta_instance;
-	my $slot_name = sprintf "'%s'", $attr->slots;
-	my $inv = '$_[0]';
-    my $code = 'sub { '
-    . 'if (scalar(@_) == 2) {'
-        . $self->_inline_check_required
-        . $self->_inline_check_coercion
-        . $self->_inline_check_constraint($value_name)
-		. $self->_inline_store($inv, $value_name)
-		. $self->_inline_trigger($inv, $value_name)
-    . ' }'
-    . $self->_inline_check_lazy
-    . 'return ' . $self->_inline_auto_deref($self->_inline_get($inv))
-    . ' }';
-    
-    # NOTE:
-    # set up the environment
-    my $type_constraint = $attr->type_constraint 
-                                ? $attr->type_constraint->_compiled_type_constraint
-                                : undef;
-    
-    my $sub = eval $code;
-    confess "Could not create accessor for '$attr_name' because $@ \n code: $code" if $@;
-    return $sub;    
+sub _error_thrower {
+    my $self = shift;
+    ( ref $self && $self->associated_attribute ) || $self->SUPER::_error_thrower();
+}
+
+sub _eval_code {
+    my ( $self, $source ) = @_;
+
+    my $environment = $self->_eval_environment;
+
+    my ( $code, $e ) = $self->_compile_code( environment => $environment, code => $source );
+
+    $self->throw_error(
+        "Could not create writer for '${\$self->associated_attribute->name}' because $e \n code: $source",
+        error => $e, data => $source )
+        if $e;
+
+    return $code;
 }
 
-sub generate_writer_method_inline {
-    my $self      = shift;
-    my $attr      = $self->associated_attribute; 
-    my $attr_name = $attr->name;
-    
-    my $value_name = $attr->should_coerce ? '$val' : '$_[1]';
-	my $inv = '$_[0]';
-    my $code = 'sub { '
+sub _eval_environment {
+    my $self = shift;
+
+    my $attr                = $self->associated_attribute;
+    my $type_constraint_obj = $attr->type_constraint;
+
+    return {
+        '$attr'                => \$attr,
+        '$meta'                => \$self,
+        '$type_constraint_obj' => \$type_constraint_obj,
+        '$type_constraint'     => \(
+              $type_constraint_obj
+            ? $type_constraint_obj->_compiled_type_constraint
+            : undef
+        ),
+    };
+}
+
+sub _generate_accessor_method_inline {
+    my $self        = $_[0];
+    my $inv         = '$_[0]';
+    my $value_name  = $self->_value_needs_copy ? '$val' : '$_[1]';
+
+    $self->_eval_code('sub { ' . "\n"
+    . $self->_inline_pre_body(@_) . "\n"
+    . 'if (scalar(@_) >= 2) {' . "\n"
+        . $self->_inline_copy_value . "\n"
+        . $self->_inline_check_required . "\n"
+        . $self->_inline_check_coercion($value_name) . "\n"
+        . $self->_inline_check_constraint($value_name) . "\n"
+        . $self->_inline_get_old_value_for_trigger($inv, $value_name) . "\n"
+        . $self->_inline_store($inv, $value_name) . "\n"
+        . $self->_inline_trigger($inv, $value_name, '@old') . "\n"
+    . ' }' . "\n"
+    . $self->_inline_check_lazy($inv) . "\n"
+    . $self->_inline_post_body(@_) . "\n"
+    . 'return ' . $self->_inline_auto_deref($self->_inline_get($inv)) . "\n"
+    . ' }');
+}
+
+sub _generate_writer_method_inline {
+    my $self        = $_[0];
+    my $inv         = '$_[0]';
+    my $value_name  = $self->_value_needs_copy ? '$val' : '$_[1]';
+
+    $self->_eval_code('sub { '
+    . $self->_inline_pre_body(@_)
+    . $self->_inline_copy_value
     . $self->_inline_check_required
-    . $self->_inline_check_coercion
-	. $self->_inline_check_constraint($value_name)
-	. $self->_inline_store($inv, $value_name)
-	. $self->_inline_trigger($inv, $value_name)
-    . ' }';
-    
-    # NOTE:
-    # set up the environment
-    my $type_constraint = $attr->type_constraint 
-                                ? $attr->type_constraint->_compiled_type_constraint
-                                : undef;    
-    
-    my $sub = eval $code;
-    confess "Could not create writer for '$attr_name' because $@ \n code: $code" if $@;
-    return $sub;    
+    . $self->_inline_check_coercion($value_name)
+    . $self->_inline_check_constraint($value_name)
+    . $self->_inline_get_old_value_for_trigger($inv, $value_name) . "\n"
+    . $self->_inline_store($inv, $value_name)
+    . $self->_inline_post_body(@_)
+    . $self->_inline_trigger($inv, $value_name, '@old')
+    . ' }');
+}
+
+sub _generate_reader_method_inline {
+    my $self        = $_[0];
+    my $inv         = '$_[0]';
+    my $slot_access = $self->_inline_get($inv);
+
+    $self->_eval_code('sub {'
+    . $self->_inline_pre_body(@_)
+    . $self->_inline_throw_error('"Cannot assign a value to a read-only accessor"', 'data => \@_') . ' if @_ > 1;'
+    . $self->_inline_check_lazy($inv)
+    . $self->_inline_post_body(@_)
+    . 'return ' . $self->_inline_auto_deref( $slot_access ) . ';'
+    . '}');
 }
 
-sub generate_reader_method_inline {
-    my $self      = shift;
-    my $attr      = $self->associated_attribute; 
-    my $attr_name = $attr->name;
-    
-    my $code = 'sub {'
-    . 'confess "Cannot assign a value to a read-only accessor" if @_ > 1;'
-    . $self->_inline_check_lazy
-    . 'return ' . $self->_inline_auto_deref( '$_[0]->{$attr_name}' ) . ';'
-    . '}';
-    
-    # NOTE:
-    # set up the environment
-    my $type_constraint = $attr->type_constraint 
-                                ? $attr->type_constraint->_compiled_type_constraint
-                                : undef;    
-    
-    my $sub = eval $code;
-    confess "Could not create reader for '$attr_name' because $@ \n code: $code" if $@;
-    return $sub;
+sub _inline_copy_value {
+    return '' unless shift->_value_needs_copy;
+    return 'my $val = $_[1];'
 }
 
-## normal method generators 
+sub _value_needs_copy {
+    my $attr = (shift)->associated_attribute;
+    return $attr->should_coerce;
+}
+
+sub _instance_is_inlinable {
+    my $self = shift;
+    return $self->associated_attribute->associated_class->instance_metaclass->is_inlinable;
+}
+
+sub _generate_reader_method {
+    my $self = shift;
+    $self->_instance_is_inlinable ? $self->_generate_reader_method_inline(@_)
+                                  : $self->SUPER::_generate_reader_method(@_);
+}
 
-*generate_reader_method   = \&generate_reader_method_inline;
-*generate_writer_method   = \&generate_writer_method_inline;
-*generate_accessor_method = \&generate_accessor_method_inline;
+sub _generate_writer_method {
+    my $self = shift;
+    $self->_instance_is_inlinable ? $self->_generate_writer_method_inline(@_)
+                                  : $self->SUPER::_generate_writer_method(@_);
+}
 
-## ... private helpers
+sub _generate_accessor_method {
+    my $self = shift;
+    $self->_instance_is_inlinable ? $self->_generate_accessor_method_inline(@_)
+                                  : $self->SUPER::_generate_accessor_method(@_);
+}
+
+sub _generate_predicate_method {
+    my $self = shift;
+    $self->_instance_is_inlinable ? $self->_generate_predicate_method_inline(@_)
+                                  : $self->SUPER::_generate_predicate_method(@_);
+}
+
+sub _generate_clearer_method {
+    my $self = shift;
+    $self->_instance_is_inlinable ? $self->_generate_clearer_method_inline(@_)
+                                  : $self->SUPER::_generate_clearer_method(@_);
+}
+
+sub _inline_pre_body  { '' }
+sub _inline_post_body { '' }
 
 sub _inline_check_constraint {
-	my ($self, $value) = @_;
-	
-	my $attr = $self->associated_attribute; 
-	
-	return '' unless $attr->has_type_constraint;
-	
-	# FIXME - remove 'unless defined($value) - constraint Undef
-	return sprintf <<'EOF', $value, $value, $value, $value
-defined($type_constraint->(%s))
-	|| confess "Attribute (" . $attr->name . ") does not pass the type constraint ("
-       . $attr->type_constraint->name . ") with " . (defined(%s) ? "'%s'" : "undef")
-  if defined(%s);
-EOF
+    my ($self, $value) = @_;
+
+    my $attr = $self->associated_attribute;
+
+    return '' unless $attr->has_type_constraint;
+
+    my $attr_name = quotemeta( $attr->name );
+
+    qq{\$type_constraint->($value) || } . $self->_inline_throw_error(qq{"Attribute ($attr_name) does not pass the type constraint because: " . \$type_constraint_obj->get_message($value)}, "data => $value") . ";";
 }
 
 sub _inline_check_coercion {
-	my $attr = (shift)->associated_attribute; 
-	
-	return '' unless $attr->should_coerce;
-    return 'my $val = $attr->type_constraint->coerce($_[1]);'
+    my ($self, $value) = @_;
+
+    my $attr = $self->associated_attribute;
+
+    return '' unless $attr->should_coerce && $attr->type_constraint->has_coercion;
+    return "$value = \$attr->type_constraint->coerce($value);";
 }
 
 sub _inline_check_required {
-	my $attr = (shift)->associated_attribute; 
-	
-	return '' unless $attr->is_required;
-    return 'defined($_[1]) || confess "Attribute ($attr_name) is required, so cannot be set to undef";'
+    my $self = shift;
+    my $attr = $self->associated_attribute;
+
+    return '' unless $attr->is_required;
+
+    my $attr_name = quotemeta( $attr->name );
+
+    return qq{(\@_ >= 2) || } . $self->_inline_throw_error(qq{"Attribute ($attr_name) is required, so cannot be set to undef"}) . ';' # defined $_[1] is not good enough
 }
 
 sub _inline_check_lazy {
-	my $attr = (shift)->associated_attribute; 
-	
-	return '' unless $attr->is_lazy;
-	
-	if ($attr->has_type_constraint) {
-	    # NOTE:
-	    # this could probably be cleaned 
-	    # up and streamlined a little more
-	    return 'unless (exists $_[0]->{$attr_name}) {' .
-	           '    if ($attr->has_default) {' .
-	           '        my $default = $attr->default($_[0]);' .
-               '        (defined($type_constraint->($default)))' .
-               '        	|| confess "Attribute (" . $attr->name . ") does not pass the type constraint ("' .
-               '               . $attr->type_constraint->name . ") with " . (defined($default) ? "\'$default\'" : "undef")' .
-               '          if defined($default);' .	                
-	           '        $_[0]->{$attr_name} = $default; ' .
-	           '    }' .
-	           '    else {' .
-               '        $_[0]->{$attr_name} = undef;' .
-	           '    }' .
-	           '}';	    
-	}
-    return '$_[0]->{$attr_name} = ($attr->has_default ? $attr->default($_[0]) : undef)'
-         . 'unless exists $_[0]->{$attr_name};';
+    my ($self, $instance) = @_;
+
+    my $attr = $self->associated_attribute;
+
+    return '' unless $attr->is_lazy;
+
+    my $slot_exists = $self->_inline_has($instance);
+
+    my $code = 'unless (' . $slot_exists . ') {' . "\n";
+    if ($attr->has_type_constraint) {
+        if ($attr->has_default || $attr->has_builder) {
+            if ($attr->has_default) {
+                $code .= '    my $default = $attr->default(' . $instance . ');'."\n";
+            }
+            elsif ($attr->has_builder) {
+                $code .= '    my $default;'."\n".
+                         '    if(my $builder = '.$instance.'->can($attr->builder)){ '."\n".
+                         '        $default = '.$instance.'->$builder; '. "\n    } else {\n" .
+                         '        ' . $self->_inline_throw_error(q{sprintf "%s does not support builder method '%s' for attribute '%s'", ref(} . $instance . ') || '.$instance.', $attr->builder, $attr->name') .
+                         ';'. "\n    }";
+            }
+            $code .= $self->_inline_check_coercion('$default') . "\n";
+            $code .= $self->_inline_check_constraint('$default', 'lazy') . "\n";
+            $code .= '    ' . $self->_inline_init_slot($attr, $instance, '$default') . "\n";
+        }
+        else {
+            $code .= '    ' . $self->_inline_init_slot($attr, $instance, 'undef') . "\n";
+        }
+
+    } else {
+        if ($attr->has_default) {
+            $code .= '    ' . $self->_inline_init_slot($attr, $instance, ('$attr->default(' . $instance . ')')) . "\n";
+        }
+        elsif ($attr->has_builder) {
+            $code .= '    if (my $builder = '.$instance.'->can($attr->builder)) { ' . "\n"
+                  .  '       ' . $self->_inline_init_slot($attr, $instance, ($instance . '->$builder'))
+                  .  "\n    } else {\n"
+                  .  '        ' . $self->_inline_throw_error(q{sprintf "%s does not support builder method '%s' for attribute '%s'", ref(} . $instance . ') || '.$instance.', $attr->builder, $attr->name')
+                  .  ';'. "\n    }";
+        }
+        else {
+            $code .= '    ' . $self->_inline_init_slot($attr, $instance, 'undef') . "\n";
+        }
+    }
+    $code .= "}\n";
+    return $code;
 }
 
+sub _inline_init_slot {
+    my ($self, $attr, $inv, $value) = @_;
+    if ($attr->has_initializer) {
+        return ('$attr->set_initial_value(' . $inv . ', ' . $value . ');');
+    }
+    else {
+        return $self->_inline_store($inv, $value);
+    }
+}
 
 sub _inline_store {
-	my ($self, $instance, $value) = @_;
-	my $attr = $self->associated_attribute; 	
+    my ( $self, $instance, $value ) = @_;
 
-	my $mi = $attr->associated_class->get_meta_instance;
-	my $slot_name = sprintf "'%s'", $attr->slots;
+    return $self->associated_attribute->inline_set( $instance, $value );
+}
 
-    my $code = $mi->inline_set_slot_value($instance, $slot_name, $value)    . ";";
-	$code   .= $mi->inline_weaken_slot_value($instance, $slot_name, $value) . ";"
-	    if $attr->is_weak_ref;
-    return $code;
+sub _inline_get_old_value_for_trigger {
+    my ( $self, $instance ) = @_;
+
+    my $attr = $self->associated_attribute;
+    return '' unless $attr->has_trigger;
+
+    return
+          'my @old = '
+        . $self->_inline_has($instance) . q{ ? }
+        . $self->_inline_get($instance) . q{ : ()} . ";\n";
 }
 
 sub _inline_trigger {
-	my ($self, $instance, $value) = @_;
-	my $attr = $self->associated_attribute; 	
-	return '' unless $attr->has_trigger;
-	return sprintf('$attr->trigger->(%s, %s, $attr);', $instance, $value);
+    my ($self, $instance, $value, $old_value) = @_;
+    my $attr = $self->associated_attribute;
+    return '' unless $attr->has_trigger;
+    return sprintf('$attr->trigger->(%s, %s, %s);', $instance, $value, $old_value);
 }
 
 sub _inline_get {
-	my ($self, $instance) = @_;
-	my $attr = $self->associated_attribute; 	
+    my ($self, $instance) = @_;
+
+    return $self->associated_attribute->inline_get($instance);
+}
 
-	my $mi = $attr->associated_class->get_meta_instance;
-	my $slot_name = sprintf "'%s'", $attr->slots;
+sub _inline_has {
+    my ($self, $instance) = @_;
 
-    return $mi->inline_get_slot_value($instance, $slot_name);
+    return $self->associated_attribute->inline_has($instance);
 }
 
 sub _inline_auto_deref {
     my ( $self, $ref_value ) = @_;
-	my $attr = $self->associated_attribute;     
+        my $attr = $self->associated_attribute;
 
     return $ref_value unless $attr->should_auto_deref;
 
@@ -200,12 +290,14 @@ sub _inline_auto_deref {
     my $sigil;
     if ($type_constraint->is_a_type_of('ArrayRef')) {
         $sigil = '@';
-    } 
+    }
     elsif ($type_constraint->is_a_type_of('HashRef')) {
         $sigil = '%';
-    } 
+    }
     else {
-        confess "Can not auto de-reference the type constraint '" . $type_constraint->name . "'";
+        $self->throw_error( "Can not auto de-reference the type constraint '"
+                . quotemeta( $type_constraint->name )
+                . "'", type_constraint => $type_constraint );
     }
 
     "(wantarray() ? $sigil\{ ( $ref_value ) || return } : ( $ref_value ) )";
@@ -223,37 +315,16 @@ Moose::Meta::Method::Accessor - A Moose Method metaclass for accessors
 
 =head1 DESCRIPTION
 
-This is a subclass of L<Class::MOP::Method::Accessor> and it's primary 
-responsibility is to generate the accessor methods for attributes. It 
-can handle both closure based accessors, as well as inlined source based
-accessors. 
-
-This is a fairly new addition to the MOP, but this will play an important
-role in the optimization strategy we are currently following.
-
-=head1 METHODS
-
-=over 4
-
-=item B<generate_accessor_method>
-
-=item B<generate_reader_method>
-
-=item B<generate_writer_method>
-
-=item B<generate_accessor_method_inline>
-
-=item B<generate_reader_method_inline>
-
-=item B<generate_writer_method_inline>
+This class is a subclass of L<Class::MOP::Method::Accessor> that
+provides additional Moose-specific functionality, all of which is
+private.
 
-=back
+To understand this class, you should read the the
+L<Class::MOP::Method::Accessor> documentation.
 
 =head1 BUGS
 
-All complex software has bugs lurking in it, and this module is no 
-exception. If you find a bug please either email me, or add the bug
-to cpan-RT.
+See L<Moose/BUGS> for details on reporting bugs.
 
 =head1 AUTHOR
 
@@ -263,11 +334,11 @@ Yuval Kogman E<lt>nothingmuch@woobling.comE<gt>
 
 =head1 COPYRIGHT AND LICENSE
 
-Copyright 2006 by Infinity Interactive, Inc.
+Copyright 2006-2010 by Infinity Interactive, Inc.
 
 L<http://www.iinteractive.com>
 
 This library is free software; you can redistribute it and/or modify
 it under the same terms as Perl itself.
 
-=cut
\ No newline at end of file
+=cut