X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FClass.pm;h=f0a0c24cc1e2a7063f72eb05da661f0e93a66846;hb=3fe3513471eda5b33418f8665f7ec20ecb58c589;hp=75c4f542e2f8aadbe4499d2d197f05c2db3fad5c;hpb=f5bc97e5bbde4f29f52d85ac7c03251665dfd52b;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Class.pm b/lib/Moose/Meta/Class.pm index 75c4f54..f0a0c24 100644 --- a/lib/Moose/Meta/Class.pm +++ b/lib/Moose/Meta/Class.pm @@ -11,7 +11,7 @@ use List::Util qw( first ); use List::MoreUtils qw( any all uniq ); use Scalar::Util 'weaken', 'blessed'; -our $VERSION = '0.60'; +our $VERSION = '0.64'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; @@ -90,8 +90,8 @@ sub create_anon_class { # something like Super::Class|Super::Class::2=Role|Role::1 my $cache_key = join '=' => ( - join('|', sort @{$options{superclasses} || []}), - join('|', sort @{$options{roles} || []}), + join('|', @{$options{superclasses} || []}), + join('|', sort @{$options{roles} || []}), ); if ($cache_ok && defined $ANON_CLASSES{$cache_key}) { @@ -195,74 +195,6 @@ sub construct_instance { return $instance; } -# FIXME: -# This is ugly -sub get_method_map { - my $self = shift; - - my $current = Class::MOP::check_package_cache_flag($self->name); - - if (defined $self->{'_package_cache_flag'} && $self->{'_package_cache_flag'} == $current) { - return $self->{'methods'}; - } - - $self->{_package_cache_flag} = $current; - - my $map = $self->{'methods'}; - - my $class_name = $self->name; - my $method_metaclass = $self->method_metaclass; - - my %all_code = $self->get_all_package_symbols('CODE'); - - foreach my $symbol (keys %all_code) { - my $code = $all_code{$symbol}; - - next if exists $map->{$symbol} && - defined $map->{$symbol} && - $map->{$symbol}->body == $code; - - my ($pkg, $name) = Class::MOP::get_code_info($code); - - if ($pkg->can('meta') - # NOTE: - # we don't know what ->meta we are calling - # here, so we need to be careful cause it - # just might blow up at us, or just complain - # loudly (in the case of Curses.pm) so we - # just be a little overly cautious here. - # - SL - && eval { no warnings; blessed($pkg->meta) } - && $pkg->meta->isa('Moose::Meta::Role')) { - #my $role = $pkg->meta->name; - #next unless $self->does_role($role); - } - else { - - # NOTE: - # in 5.10 constant.pm the constants show up - # as being in the right package, but in pre-5.10 - # they show up as constant::__ANON__ so we - # make an exception here to be sure that things - # work as expected in both. - # - SL - unless ($pkg eq 'constant' && $name eq '__ANON__') { - next if ($pkg || '') ne $class_name || - (($name || '') ne '__ANON__' && ($pkg || '') ne $class_name); - } - - } - - $map->{$symbol} = $method_metaclass->wrap( - $code, - package_name => $class_name, - name => $symbol - ); - } - - return $map; -} - ### --------------------------------------------- sub add_attribute { @@ -582,7 +514,7 @@ sub _process_inherited_attribute { my ($self, $attr_name, %options) = @_; my $inherited_attr = $self->find_attribute_by_name($attr_name); (defined $inherited_attr) - || $self->throw_error("Could not find an attribute by the name of '$attr_name' to inherit from", data => $attr_name); + || $self->throw_error("Could not find an attribute by the name of '$attr_name' to inherit from in ${\$self->name}", data => $attr_name); if ($inherited_attr->isa('Moose::Meta::Attribute')) { return $inherited_attr->clone_and_inherit_options(%options); } @@ -842,7 +774,7 @@ Get or set the error builder. Defaults to C. =item B -Get or set the error class. Has no default. +Get or set the error class. This defaults to L. =item B