X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FAttribute.pm;h=313c9f3c7d3a7e300b60fe4dd75134d854be1ae6;hb=7dbda4584d3c2914caf32515d4ce9621f94a819e;hp=28c0b8b02039b897b76e44521731da347f490bf4;hpb=ccf49e80884ce57511f742a85791d368a372d893;p=gitmo%2FMoose.git diff --git a/lib/Moose/Meta/Attribute.pm b/lib/Moose/Meta/Attribute.pm index 28c0b8b..313c9f3 100644 --- a/lib/Moose/Meta/Attribute.pm +++ b/lib/Moose/Meta/Attribute.pm @@ -9,7 +9,7 @@ use Carp 'confess'; use Sub::Name 'subname'; use overload (); -our $VERSION = '0.18'; +our $VERSION = '0.22'; our $AUTHORITY = 'cpan:STEVAN'; use Moose::Meta::Method::Accessor; @@ -47,6 +47,14 @@ __PACKAGE__->meta->add_attribute('documentation' => ( predicate => 'has_documentation', )); +# NOTE: +# we need to have a ->does method in here to +# more easily support traits, and the introspection +# of those traits. So in order to do this we +# just alias Moose::Object's version of it. +# - SL +*does = \&Moose::Object::does; + sub new { my ($class, $name, %options) = @_; $class->_process_options($name, \%options); @@ -57,23 +65,13 @@ sub clone_and_inherit_options { my ($self, %options) = @_; # you can change default, required, coerce, documentation and lazy my %actual_options; - foreach my $legal_option (qw(default coerce required documentation lazy)) { + foreach my $legal_option (qw(default coerce required documentation lazy handles builder)) { if (exists $options{$legal_option}) { $actual_options{$legal_option} = $options{$legal_option}; delete $options{$legal_option}; } } - # handles can only be added, not changed - if ($options{handles}) { - confess "You can only add the 'handles' option, you cannot change it" - if $self->has_handles; - $actual_options{handles} = $options{handles}; - delete $options{handles}; - } - - # isa can be changed, but only if the - # new type is a subtype if ($options{isa}) { my $type_constraint; if (blessed($options{isa}) && $options{isa}->isa('Moose::Meta::TypeConstraint')) { @@ -86,14 +84,7 @@ sub clone_and_inherit_options { (defined $type_constraint) || confess "Could not find the type constraint '" . $options{isa} . "'"; } - # NOTE: - # check here to see if the new type - # is a subtype of the old one - ($type_constraint->is_subtype_of($self->type_constraint->name)) - || confess "New type constraint setting must be a subtype of inherited one" - # iff we have a type constraint that is ... - if $self->has_type_constraint; - # then we use it :) + $actual_options{type_constraint} = $type_constraint; delete $options{isa}; } @@ -109,7 +100,7 @@ sub _process_options { if ($options->{is} eq 'ro') { $options->{reader} ||= $name; (!exists $options->{trigger}) - || confess "Cannot have a trigger on a read-only attribute"; + || confess "Cannot have a trigger on a read-only attribute $name"; } elsif ($options->{is} eq 'rw') { $options->{accessor} = $name; @@ -118,7 +109,7 @@ sub _process_options { if exists $options->{trigger}; } else { - confess "I do not understand this option (is => " . $options->{is} . ")" + confess "I do not understand this option (is => " . $options->{is} . ") on attribute $name" } } @@ -126,10 +117,10 @@ sub _process_options { if (exists $options->{does}) { if (eval { $options->{isa}->can('does') }) { ($options->{isa}->does($options->{does})) - || confess "Cannot have an isa option and a does option if the isa does not do the does"; + || confess "Cannot have an isa option and a does option if the isa does not do the does on attribute $name"; } else { - confess "Cannot have an isa option which cannot ->does()"; + confess "Cannot have an isa option which cannot ->does() on attribute $name"; } } @@ -165,21 +156,21 @@ sub _process_options { if (exists $options->{coerce} && $options->{coerce}) { (exists $options->{type_constraint}) - || confess "You cannot have coercion without specifying a type constraint"; - confess "You cannot have a weak reference to a coerced value" + || confess "You cannot have coercion without specifying a type constraint on attribute $name"; + confess "You cannot have a weak reference to a coerced value on attribute $name" if $options->{weak_ref}; } if (exists $options->{auto_deref} && $options->{auto_deref}) { (exists $options->{type_constraint}) - || confess "You cannot auto-dereference without specifying a type constraint"; + || confess "You cannot auto-dereference without specifying a type constraint on attribute $name"; ($options->{type_constraint}->is_a_type_of('ArrayRef') || $options->{type_constraint}->is_a_type_of('HashRef')) - || confess "You cannot auto-dereference anything other than a ArrayRef or HashRef"; + || confess "You cannot auto-dereference anything other than a ArrayRef or HashRef on attribute $name"; } if (exists $options->{lazy_build} && $options->{lazy_build} == 1) { - confess("You can not use lazy_build and default for the same attribute") + confess("You can not use lazy_build and default for the same attribute $name") if exists $options->{default}; $options->{lazy} = 1; $options->{required} = 1; @@ -195,8 +186,12 @@ sub _process_options { } if (exists $options->{lazy} && $options->{lazy}) { - (exists $options->{default} || exists $options->{builder} ) - || confess "You cannot have lazy attribute without specifying a default value for it"; + (exists $options->{default} || defined $options->{builder} ) + || confess "You cannot have lazy attribute ($name) without specifying a default value for it"; + } + + if ( $options->{required} && !( ( !exists $options->{init_arg} || defined $options->{init_arg} ) || exists $options->{default} || defined $options->{builder} ) ) { + confess "You cannot have a required attribute ($name) without a default, builder, or an init_arg"; } } @@ -208,7 +203,7 @@ sub initialize_instance_slot { my $val; my $value_is_set; - if (exists $params->{$init_arg}) { + if ( defined($init_arg) and exists $params->{$init_arg}) { $val = $params->{$init_arg}; $value_is_set = 1; } @@ -243,25 +238,59 @@ sub initialize_instance_slot { if ($self->should_coerce && $type_constraint->has_coercion) { $val = $type_constraint->coerce($val); } - (defined($type_constraint->check($val))) - || confess "Attribute (" . - $self->name . - ") does not pass the type constraint (" . - $type_constraint->name . - ") with '" . - (defined $val - ? overload::StrVal($val) - : 'undef') . - "'"; + $type_constraint->check($val) + || confess "Attribute (" + . $self->name + . ") does not pass the type constraint because: " + . $type_constraint->get_message($val); } - $meta_instance->set_slot_value($instance, $self->name, $val); + $self->set_initial_value($instance, $val); $meta_instance->weaken_slot_value($instance, $self->name) if ref $val && $self->is_weak_ref; } ## Slot management +# FIXME: +# this duplicates too much code from +# Class::MOP::Attribute, we need to +# refactor these bits eventually. +# - SL +sub _set_initial_slot_value { + my ($self, $meta_instance, $instance, $value) = @_; + + my $slot_name = $self->name; + + return $meta_instance->set_slot_value($instance, $slot_name, $value) + unless $self->has_initializer; + + my ($type_constraint, $can_coerce); + if ($self->has_type_constraint) { + $type_constraint = $self->type_constraint; + $can_coerce = ($self->should_coerce && $type_constraint->has_coercion); + } + + my $callback = sub { + my $val = shift; + if ($type_constraint) { + $val = $type_constraint->coerce($val) + if $can_coerce; + $type_constraint->check($val) + || confess "Attribute (" + . $slot_name + . ") does not pass the type constraint because: " + . $type_constraint->get_message($val); + } + $meta_instance->set_slot_value($instance, $slot_name, $val); + }; + + my $initializer = $self->initializer; + + # most things will just want to set a value, so make it first arg + $instance->$initializer($value, $callback, $self); +} + sub set_value { my ($self, $instance, $value) = @_; @@ -278,15 +307,12 @@ sub set_value { if ($self->should_coerce) { $value = $type_constraint->coerce($value); - } + } $type_constraint->_compiled_type_constraint->($value) - || confess "Attribute ($attr_name) does not pass the type constraint (" - . $type_constraint->name - . ") with " - . (defined($value) - ? ("'" . overload::StrVal($value) . "'") - : "undef") - if defined($value); + || confess "Attribute (" + . $self->name + . ") does not pass the type constraint because " + . $type_constraint->get_message($value); } my $meta_instance = Class::MOP::Class->initialize(blessed($instance)) @@ -310,11 +336,11 @@ sub get_value { unless ($self->has_value($instance)) { if ($self->has_default) { my $default = $self->default($instance); - $self->set_value($instance, $default); + $self->set_initial_value($instance, $default); } if ( $self->has_builder ){ if (my $builder = $instance->can($self->builder)){ - $self->set_value($instance, $instance->$builder); + $self->set_initial_value($instance, $instance->$builder); } else { confess(blessed($instance) @@ -326,7 +352,7 @@ sub get_value { } } else { - $self->set_value($instance, undef); + $self->set_initial_value($instance, undef); } } } @@ -402,13 +428,22 @@ sub install_accessors { $associated_class->add_method($handle => subname $name, $method_to_call); } else { + # NOTE: + # we used to do a goto here, but the + # goto didn't handle failure correctly + # (it just returned nothing), so I took + # that out. However, the more I thought + # about it, the less I liked it doing + # the goto, and I prefered the act of + # delegation being actually represented + # in the stack trace. + # - SL $associated_class->add_method($handle => subname $name, sub { my $proxy = (shift)->$accessor(); - @_ = ($proxy, @_); (defined $proxy) || confess "Cannot delegate $handle to $method_to_call because " . "the value of " . $self->name . " is not defined"; - goto &{ $proxy->can($method_to_call) || return }; + $proxy->$method_to_call(@_); }); } } @@ -528,6 +563,8 @@ will behave just as L does. =item B +=item B + =item B =item B