X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FMoose%2FMeta%2FAttribute%2FNative%2FTrait.pm;h=9fa865d7ffb3dde5bb7075a59d157ab0fa1e41a5;hb=34d6d196372ac514abfe975cef15e8afd0af04c4;hp=e3a31a8bb6a7fe5e7b0157c55e024e2014448339;hpb=72643035d73124e0b4ef7a8335cdc4f793732b5a;p=gitmo%2FMoose.git

diff --git a/lib/Moose/Meta/Attribute/Native/Trait.pm b/lib/Moose/Meta/Attribute/Native/Trait.pm
index e3a31a8..9fa865d 100644
--- a/lib/Moose/Meta/Attribute/Native/Trait.pm
+++ b/lib/Moose/Meta/Attribute/Native/Trait.pm
@@ -2,50 +2,38 @@
 package Moose::Meta::Attribute::Native::Trait;
 use Moose::Role;
 use Moose::Util::TypeConstraints;
+use Moose::Deprecated;
 
-our $VERSION   = '1.08';
+our $VERSION   = '1.15';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
 requires '_helper_type';
 
-# these next two are the possible methods you can use in the 'handles'
-# map.
-
-# provide a Class or Role which we can collect the method providers
-# from
-
-# or you can provide a HASH ref of anon subs yourself. This will also
-# collect and store the methods from a method_provider as well
-has 'method_constructors' => (
-    is      => 'ro',
-    isa     => 'HashRef',
-    lazy    => 1,
-    default => sub {
-        my $self = shift;
-        return +{} unless $self->has_method_provider;
-        # or grab them from the role/class
-        my $method_provider = $self->method_provider->meta;
-        return +{
-            map {
-                $_ => $method_provider->get_method($_)
-            } $method_provider->get_method_list
-        };
-    },
-);
-
-# methods called prior to instantiation
-
 before '_process_options' => sub {
     my ( $self, $name, $options ) = @_;
 
     $self->_check_helper_type( $options, $name );
 
-    $options->{is} = $self->_default_is
-        if ! exists $options->{is} && $self->can('_default_is');
+    if ( !exists $options->{is} && $self->can('_default_is') ) {
+        $options->{is} = $self->_default_is;
 
-    $options->{default} = $self->_default_default
-        if ! exists $options->{default} && $self->can('_default_default');
+        Moose::Deprecated::deprecated(
+            feature => 'default is for Native Trait',
+            message =>
+                q{Allowing a native trait to automatically supply a value for "is" is deprecated}
+        );
+    }
+
+    if ( !exists $options->{default} && $self->can('_default_default') ) {
+        $options->{default} = $self->_default_default;
+
+        Moose::Deprecated::deprecated(
+            feature => 'default default for Native Trait',
+            message =>
+                'Allowing a native trait to automatically supply a default is deprecated'
+        );
+    }
 };
 
 sub _check_helper_type {
@@ -64,8 +52,26 @@ sub _check_helper_type {
         "The type constraint for $name must be a subtype of $type but it's a $isa";
 }
 
+before 'install_accessors' => sub { (shift)->_check_handles_values };
+
+sub _check_handles_values {
+    my $self = shift;
+
+    my %handles = $self->_canonicalize_handles;
+
+    for my $original_method ( values %handles ) {
+        my $name = $original_method->[0];
+
+        my $accessor_class = $self->_native_accessor_class_for($name);
+
+        ( $accessor_class && $accessor_class->can('new') )
+            || confess
+            "$name is an unsupported method type - $accessor_class";
+    }
+}
+
 around '_canonicalize_handles' => sub {
-    my $next    = shift;
+    shift;
     my $self    = shift;
     my $handles = $self->handles;
 
@@ -73,7 +79,7 @@ around '_canonicalize_handles' => sub {
 
     unless ( 'HASH' eq ref $handles ) {
         $self->throw_error(
-            "The 'handles' option must be a HASH reference, not $handles" );
+            "The 'handles' option must be a HASH reference, not $handles");
     }
 
     return map {
@@ -83,48 +89,64 @@ around '_canonicalize_handles' => sub {
     } keys %$handles;
 };
 
-# methods called after instantiation
-
-before 'install_accessors' => sub { (shift)->_check_handles_values };
+around '_make_delegation_method' => sub {
+    my $next = shift;
+    my ( $self, $handle_name, $method_to_call ) = @_;
 
-sub _check_handles_values {
-    my $self = shift;
+    my ( $name, @curried_args ) = @$method_to_call;
 
-    my $method_constructors = $self->method_constructors;
+    my $accessor_class = $self->_native_accessor_class_for($name);
 
-    my %handles = $self->_canonicalize_handles;
+    die "Cannot find an accessor class for $name"
+        unless $accessor_class && $accessor_class->can('new');
 
-    for my $original_method ( values %handles ) {
-        my $name = $original_method->[0];
-        ( exists $method_constructors->{$name} )
-            || confess "$name is an unsupported method type";
-    }
+    return $accessor_class->new(
+        name               => $handle_name,
+        package_name       => $self->associated_class->name,
+        delegate_to_method => $name,
+        attribute          => $self,
+        is_inline          => 1,
+        curried_arguments  => \@curried_args,
+        root_types         => [ $self->_root_types ],
+    );
+};
 
+sub _root_types {
+    return $_[0]->_helper_type;
 }
 
-around '_make_delegation_method' => sub {
-    my $next = shift;
-    my ( $self, $handle_name, $method_to_call ) = @_;
+sub _native_accessor_class_for {
+    my ( $self, $suffix ) = @_;
 
-    my ( $name, @curried_args ) = @$method_to_call;
+    my $role
+        = 'Moose::Meta::Method::Accessor::Native::'
+        . $self->_native_type . '::'
+        . $suffix;
 
-    my $method_constructors = $self->method_constructors;
+    return Moose::Meta::Class->create_anon_class(
+        superclasses =>
+            [ $self->accessor_metaclass, $self->delegation_metaclass ],
+        roles => [$role],
+        cache => 1,
+    )->name;
+}
 
-    my $code = $method_constructors->{$name}->(
-        $self,
-        $self->get_read_method_ref,
-        $self->get_write_method_ref,
-    );
+sub _build_native_type {
+    my $self = shift;
 
-    return $next->(
-        $self,
-        $handle_name,
-        sub {
-            my $instance = shift;
-            return $code->( $instance, @curried_args, @_ );
-        },
-    );
-};
+    for my $role_name ( map { $_->name } $self->meta->calculate_all_roles ) {
+        return $1 if $role_name =~ /::Native::Trait::(\w+)$/;
+    }
+
+    die "Cannot calculate native type for " . ref $self;
+}
+
+has '_native_type' => (
+    is      => 'ro',
+    isa     => 'Str',
+    lazy    => 1,
+    builder => '_build_native_type',
+);
 
 no Moose::Role;
 no Moose::Util::TypeConstraints;