X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FModule%2FMetadata.pm;h=2147232857aa04d28cf2eb540e1365f2a6f94f67;hb=f04672b558455494c58ad3de8d405a8a2bbe6b90;hp=0d73988489dc122afb84125a8775e2bb0b8d1a89;hpb=cfedad8991041ad6c33a056b5208151178f27372;p=p5sagit%2FModule-Metadata.git diff --git a/lib/Module/Metadata.pm b/lib/Module/Metadata.pm index 0d73988..2147232 100644 --- a/lib/Module/Metadata.pm +++ b/lib/Module/Metadata.pm @@ -11,7 +11,7 @@ package Module::Metadata; use strict; use vars qw($VERSION); -$VERSION = '1.000010'; +$VERSION = '1.000010_002'; $VERSION = eval $VERSION; use Carp qw/croak/; @@ -507,9 +507,6 @@ sub _parse_fh { $in_pod = !$is_cut; } - # Would be nice if we could also check $in_string or something too - last if !$in_pod && $line =~ /^__(?:DATA|END)__$/; - if ( $in_pod ) { if ( $line =~ /^=head[1-4]\s+(.+)\s*$/ ) { @@ -538,6 +535,9 @@ sub _parse_fh { # Skip comments in code next if $line =~ /^\s*#/; + # Would be nice if we could also check $in_string or something too + last if $line =~ /^__(?:DATA|END)__$/; + # parse $line to see if it's a $VERSION declaration my( $vers_sig, $vers_fullname, $vers_pkg ) = ($line =~ /VERSION/) @@ -558,14 +558,6 @@ sub _parse_fh { unless ( defined $vers{$vers_pkg} && length $vers{$vers_pkg} ) { $vers{$vers_pkg} = $self->_evaluate_version_line( $vers_sig, $vers_fullname, $line ); - } else { - # Warn unless the user is using the "$VERSION = eval - # $VERSION" idiom (though there are probably other idioms - # that we should watch out for...) - warn <<"EOM" unless $line =~ /=\s*eval/; -Package '$vers_pkg' already declared with version '$vers{$vers_pkg}', -ignoring subsequent declaration on line $line_num. -EOM } # first non-comment line in undeclared package main is VERSION