X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FImport%2FInto.pm;h=a59ce66ecb260d2ff6862e5b4e81851e5e10a646;hb=9f39bd722eb803aeff0b567a10b921daa4f36448;hp=fc775174084b70a59740de8b11b340c16f02e6df;hpb=6597b81f6e5444206bb09c077521c92ff5ee247e;p=p5sagit%2FImport-Into.git diff --git a/lib/Import/Into.pm b/lib/Import/Into.pm index fc77517..a59ce66 100644 --- a/lib/Import/Into.pm +++ b/lib/Import/Into.pm @@ -3,27 +3,30 @@ package Import::Into; use strict; use warnings FATAL => 'all'; -our $VERSION = '1.001000'; # 1.1.0 +our $VERSION = '1.001001'; # 1.1.1 -my %importers; - -sub _importer { +sub _prelude { my $target = shift; - \($importers{$target} ||= eval qq{ - package $target; - sub { my \$m = splice \@_, 1, 1; shift->\$m(\@_) }; - } or die "Couldn't build importer for $target: $@") + my ($package, $file, $line) + = $target =~ /[^0-9]/ ? ($target) : caller($target + 2); + qq{package $package;\n} + . ($file ? "#line $line \"$file\"\n" : '') +} + +sub _make_action { + my ($action, $target) = @_; + eval _prelude($target).qq{sub { shift->$action(\@_) }} + or die "Failed to build action sub to ${action} for ${target}: $@"; } - sub import::into { my ($class, $target, @args) = @_; - $class->${_importer($target)}(import => @args); + _make_action(import => $target)->($class, @args); } sub unimport::out_of { my ($class, $target, @args) = @_; - $class->${_importer($target)}(unimport => @args); + _make_action(unimport => $target)->($class, @args); } 1; @@ -40,11 +43,13 @@ Import::Into - import packages into other packages use Thing1 (); use Thing2 (); + use Thing3 (); sub import { my $target = caller; Thing1->import::into($target); Thing2->import::into($target, qw(import arguments)); + Thing3->import::into(1); # import to level } Note: you don't need to do anything more clever than this provided you @@ -70,9 +75,15 @@ C on it. This is a global method, and is callable on any package (and in fact on any object as well, although it's rarer that you'd want to do that). +If you provide C with an integer instead of a package name, it +will be used as the number of stack frames to skip to find where to export to. +This has the advantage of preserving the apparent filename and line number +being exported to, which some modules (L, L) check. + Finally, we also provide an C to allow the exporting of the effect of C: + # unimport::out_of was added in 1.1.0 (1.001000) sub unimport { Moose->unimport::out_of(scalar caller); # no MyThing == no Moose } @@ -180,13 +191,19 @@ you're receiving this from a parameter, I recommend using L: And that's it. +=head1 ACKNOWLEDGEMENTS + +Thanks to Getty for asking "how can I get C<< use strict; use warnings; >> +turned on for all consumers of my code?" and then "why is this not a +module?!". + =head1 AUTHOR mst - Matt S. Trout (cpan:MSTROUT) =head1 CONTRIBUTORS -None yet - maybe this software is perfect! (ahahahahahahahahaha) +haarg - Graham Knop (cpan:HAARG) =head1 COPYRIGHT