X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FFileCache.pm;h=7a2aa89df69ec11ff328efcb4e59b2e4dfbdf607;hb=8d0ec8cffad6f81a95e1fb954a5337910142389f;hp=a64ed9a86b33480f0569700292684d1bfa7028a8;hpb=02c473a9139e94d6158d1e3dd9a912f3525b3b21;p=p5sagit%2Fp5-mst-13.2.git

diff --git a/lib/FileCache.pm b/lib/FileCache.pm
index a64ed9a..7a2aa89 100644
--- a/lib/FileCache.pm
+++ b/lib/FileCache.pm
@@ -1,6 +1,6 @@
 package FileCache;
 
-our $VERSION = '1.04_01';
+our $VERSION = '1.05';
 
 =head1 NAME
 
@@ -81,33 +81,35 @@ use Carp;
 use Config;
 use strict;
 no strict 'refs';
+
 # These are not C<my> for legacy reasons.
 # Previous versions requested the user set $cacheout_maxopen by hand.
 # Some authors fiddled with %saw to overcome the clobber on initial open.
-use vars qw(%saw $cacheout_maxopen @EXPORT);
+use vars qw(%saw $cacheout_maxopen);
+$cacheout_maxopen = 16;
+
+use base 'Exporter';
+our @EXPORT = qw[cacheout cacheout_close];
+
+
 my %isopen;
 my $cacheout_seq = 0;
 
 sub import {
     my ($pkg,%args) = @_;
 
-    # Not using Exporter is naughty.
-    # Also, using caller(1) is just wrong.
-    #$pkg = caller(1);
-    #*{$pkg.'::cacheout'} = \&cacheout;
-    #*{$pkg.'::close'}    = \&cacheout_close;
-
     # Use Exporter. %args are for us, not Exporter.
     # Make sure to up export_to_level, or we will import into ourselves,
     # rather than our calling package;
-    use base 'Exporter';
-    @EXPORT = qw[cacheout cacheout_close];
 
     __PACKAGE__->export_to_level(1);
     Exporter::import( $pkg );
 
     # Truth is okay here because setting maxopen to 0 would be bad
     return $cacheout_maxopen = $args{maxopen} if $args{maxopen};
+
+    # XXX This code is crazy.  Why is it a one element foreach loop?
+    # Why is it using $param both as a filename and filehandle?
     foreach my $param ( '/usr/include/sys/param.h' ){
       if (open($param, '<', $param)) {
 	local ($_, $.);
@@ -153,7 +155,7 @@ sub cacheout {
     if( $isopen{$file} && ($mode||'>') ne $isopen{$file}->[1] ){
       &cacheout_close($file, 1);
     }
-    
+
     if( $isopen{$file}) {
       $ret = $file;
       $isopen{$file}->[0]++;
@@ -172,7 +174,7 @@ sub cacheout {
       }
       #XXX should we just return the value from cacheout_open, no croak?
       $ret = cacheout_open($mode, $file) or croak("Can't create $file: $!");
-      
+
       $isopen{$file} = [++$cacheout_seq, $mode];
     }
     return $ret;