X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FFile%2FCopy.t;h=1107f53bf0cb973cd4e250c365704b1e9624aa8d;hb=68c65ec0adda9d2b3fc21f30f68be0ef10de5ad8;hp=84abfd5ab0007eb32d949ef2c7d1e08462a69e8f;hpb=96fe83cdaf0db7b931d0a98967031eefdeb36c15;p=p5sagit%2Fp5-mst-13.2.git diff --git a/lib/File/Copy.t b/lib/File/Copy.t index 84abfd5..1107f53 100755 --- a/lib/File/Copy.t +++ b/lib/File/Copy.t @@ -1,4 +1,4 @@ -#!./perl +#!./perl -w BEGIN { if( $ENV{PERL_CORE} ) { @@ -7,11 +7,14 @@ BEGIN { } } +use strict; +use warnings; + use Test::More; my $TB = Test::More->builder; -plan tests => 60; +plan tests => 91; # We're going to override rename() later on but Perl has to see an override # at compile time to honor it. @@ -40,15 +43,15 @@ for my $cross_partition_test (0..1) { } # First we create a file - open(F, ">file-$$") or die; + open(F, ">file-$$") or die $!; binmode F; # for DOSISH platforms, because test 3 copies to stdout printf F "ok\n"; close F; copy "file-$$", "copy-$$"; - open(F, "copy-$$") or die; - $foo = ; + open(F, "copy-$$") or die $!; + my $foo = ; close(F); is -s "file-$$", -s "copy-$$", 'copy(fn, fn): files of the same size'; @@ -76,8 +79,8 @@ for my $cross_partition_test (0..1) { unlink "copy-$$" or die "unlink: $!"; require IO::File; - $fh = IO::File->new(">copy-$$") or die "Cannot open copy-$$:$!"; - binmode $fh or die; + my $fh = IO::File->new(">copy-$$") or die "Cannot open copy-$$:$!"; + binmode $fh or die $!; copy("file-$$",$fh); $fh->close or die "close: $!"; open(R, "copy-$$") or die; $foo = ; close(R); @@ -85,11 +88,11 @@ for my $cross_partition_test (0..1) { unlink "copy-$$" or die "unlink: $!"; require FileHandle; - my $fh = FileHandle->new(">copy-$$") or die "Cannot open copy-$$:$!"; - binmode $fh or die; + $fh = FileHandle->new(">copy-$$") or die "Cannot open copy-$$:$!"; + binmode $fh or die $!; copy("file-$$",$fh); $fh->close; - open(R, "copy-$$") or die; $foo = ; close(R); + open(R, "copy-$$") or die $!; $foo = ; close(R); is $foo, "ok\n", 'copy(fn, fh): same contents'; unlink "file-$$" or die "unlink: $!"; @@ -108,7 +111,7 @@ for my $cross_partition_test (0..1) { ok move("copy-$$", "file-$$"), 'move'; ok -e "file-$$", ' destination exists'; ok !-e "copy-$$", ' source does not'; - open(R, "file-$$") or die; $foo = ; close(R); + open(R, "file-$$") or die $!; $foo = ; close(R); is $foo, "ok\n", 'contents preserved'; TODO: { @@ -121,7 +124,7 @@ for my $cross_partition_test (0..1) { } # trick: create lib/ if not exists - not needed in Perl core - unless (-d 'lib') { mkdir 'lib' or die; } + unless (-d 'lib') { mkdir 'lib' or die $!; } copy "file-$$", "lib"; open(R, "lib/file-$$") or die $!; $foo = ; close(R); is $foo, "ok\n", 'copy(fn, dir): same contents'; @@ -129,7 +132,7 @@ for my $cross_partition_test (0..1) { # Do it twice to ensure copying over the same file works. copy "file-$$", "lib"; - open(R, "lib/file-$$") or die; $foo = ; close(R); + open(R, "lib/file-$$") or die $!; $foo = ; close(R); is $foo, "ok\n", 'copy over the same file works'; unlink "lib/file-$$" or die "unlink: $!"; @@ -164,8 +167,8 @@ for my $cross_partition_test (0..1) { ok !-z "file-$$", 'rt.perl.org 5196: copying to itself would truncate the file'; - unlink "symlink-$$"; - unlink "file-$$"; + unlink "symlink-$$" or die $!; + unlink "file-$$" or die $!; } SKIP: { @@ -185,9 +188,101 @@ for my $cross_partition_test (0..1) { ok ! -z "file-$$", 'rt.perl.org 5196: copying to itself would truncate the file'; - unlink "hardlink-$$"; - unlink "file-$$"; + unlink "hardlink-$$" or die $!; + unlink "file-$$" or die $!; + } + + open(F, ">file-$$") or die $!; + binmode F; + print F "this is file\n"; + close F; + + my $copy_msg = "this is copy\n"; + open(F, ">copy-$$") or die $!; + binmode F; + print F $copy_msg; + close F; + + my @warnings; + local $SIG{__WARN__} = sub { push @warnings, join '', @_ }; + + # pie-$$ so that we force a non-constant, else the numeric conversion (of 0) + # is cached and we don't get a warning the second time round + is eval { copy("file-$$", "copy-$$", "pie-$$"); 1 }, undef, + "a bad buffer size fails to copy"; + like $@, qr/Bad buffer size for copy/, "with a helpful error message"; + unless (is scalar @warnings, 1, "There is 1 warning") { + diag $_ foreach @warnings; } + + is -s "copy-$$", length $copy_msg, "but does not truncate the destination"; + open(F, "copy-$$") or die $!; + $foo = ; + close(F); + is $foo, $copy_msg, "nor change the destination's contents"; + + unlink "file-$$" or die $!; + unlink "copy-$$" or die $!; +} + + +{ + # Just a sub to get better failure messages. + sub __ ($) { + join "" => map {(qw [--- --x -w- -wx r-- r-x rw- rwx]) [$_]} + split // => sprintf "%03o" => shift + } + # Testing permission bits. + my $src = "file-$$"; + my $copy1 = "copy1-$$"; + my $copy2 = "copy2-$$"; + my $copy3 = "copy3-$$"; + + open my $fh => ">", $src or die $!; + close $fh or die $!; + + open $fh => ">", $copy3 or die $!; + close $fh or die $!; + + my @tests = ( + [0000, 0777, 0777, 0777], + [0000, 0751, 0751, 0644], + [0022, 0777, 0755, 0206], + [0022, 0415, 0415, 0666], + [0077, 0777, 0700, 0333], + [0027, 0755, 0750, 0251], + [0777, 0751, 0000, 0215], + ); + my $old_mask = umask; + foreach my $test (@tests) { + my ($umask, $s_perm, $c_perm1, $c_perm3) = @$test; + # Make sure the copies doesn't exist. + ! -e $_ or unlink $_ or die $! for $copy1, $copy2; + + (umask $umask) // die $!; + chmod $s_perm => $src or die $!; + chmod $c_perm3 => $copy3 or die $!; + + open my $fh => "<", $src or die $!; + + copy ($src, $copy1); + copy ($fh, $copy2); + copy ($src, $copy3); + + my $perm1 = (stat $copy1) [2] & 0xFFF; + my $perm2 = (stat $copy2) [2] & 0xFFF; + my $perm3 = (stat $copy3) [2] & 0xFFF; + is (__$perm1, __$c_perm1, "Permission bits set correctly"); + is (__$perm2, __$c_perm1, "Permission bits set correctly"); + TODO: { + local $TODO = 'Permission bits inconsistent under cygwin' if $^O eq 'cygwin'; + is (__$perm3, __$c_perm3, "Permission bits not modified"); + } + } + umask $old_mask or die $!; + + # Clean up. + ! -e $_ or unlink $_ or die $! for $src, $copy1, $copy2, $copy3; }