X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBM%2FDeep%2FHash.pm;h=0c0e9094e5bf4fdf8f623d372b05a3bf76f97b87;hb=3a7a0dcedb5e8490578dc1470418079919cd034e;hp=e315a5df8a4e0844cc13b5dfed41b3f218285638;hpb=217fef02cc3ece43b124bd36f9efba53dbbc5fe5;p=dbsrgits%2FDBM-Deep.git diff --git a/lib/DBM/Deep/Hash.pm b/lib/DBM/Deep/Hash.pm index e315a5d..0c0e909 100644 --- a/lib/DBM/Deep/Hash.pm +++ b/lib/DBM/Deep/Hash.pm @@ -5,7 +5,7 @@ use strict; use base 'DBM::Deep'; sub _get_self { - eval { tied( %{$_[0]} ) } || $_[0] + eval { local $SIG{'__DIE__'}; tied( %{$_[0]} ) } || $_[0] } sub TIEHASH { @@ -13,32 +13,50 @@ sub TIEHASH { # Tied hash constructor method, called by Perl's tie() function. ## my $class = shift; - my $args; - if (scalar(@_) > 1) { - if ( @_ % 2 ) { - $class->_throw_error( "Odd number of parameters to TIEHASH" ); - } - $args = {@_}; - } - #XXX This use of ref() is bad and is a bug - elsif (ref($_[0])) { $args = $_[0]; } - else { $args = { file => shift }; } + my $args = $class->_get_args( @_ ); $args->{type} = $class->TYPE_HASH; return $class->_init($args); } +sub FETCH { + my $self = shift->_get_self; + my $key = ($self->_root->{filter_store_key}) + ? $self->_root->{filter_store_key}->($_[0]) + : $_[0]; + + return $self->SUPER::FETCH( $key ); +} + sub STORE { my $self = shift->_get_self; - my $key = ($self->root->{filter_store_key}) - ? $self->root->{filter_store_key}->($_[0]) + my $key = ($self->_root->{filter_store_key}) + ? $self->_root->{filter_store_key}->($_[0]) : $_[0]; my $value = $_[1]; return $self->SUPER::STORE( $key, $value ); } +sub EXISTS { + my $self = shift->_get_self; + my $key = ($self->_root->{filter_store_key}) + ? $self->_root->{filter_store_key}->($_[0]) + : $_[0]; + + return $self->SUPER::EXISTS( $key ); +} + +sub DELETE { + my $self = shift->_get_self; + my $key = ($self->_root->{filter_store_key}) + ? $self->_root->{filter_store_key}->($_[0]) + : $_[0]; + + return $self->SUPER::DELETE( $key ); +} + sub FIRSTKEY { ## # Locate and return first key (in no particular order) @@ -48,7 +66,7 @@ sub FIRSTKEY { ## # Make sure file is open ## - if (!defined($self->fh)) { $self->_open(); } + if (!defined($self->_fh)) { $self->_open(); } ## # Request shared lock for reading @@ -59,8 +77,8 @@ sub FIRSTKEY { $self->unlock(); - return ($result && $self->root->{filter_fetch_key}) - ? $self->root->{filter_fetch_key}->($result) + return ($result && $self->_root->{filter_fetch_key}) + ? $self->_root->{filter_fetch_key}->($result) : $result; } @@ -70,8 +88,8 @@ sub NEXTKEY { ## my $self = $_[0]->_get_self; - my $prev_key = ($self->root->{filter_store_key}) - ? $self->root->{filter_store_key}->($_[1]) + my $prev_key = ($self->_root->{filter_store_key}) + ? $self->_root->{filter_store_key}->($_[1]) : $_[1]; my $prev_md5 = $DBM::Deep::DIGEST_FUNC->($prev_key); @@ -79,7 +97,7 @@ sub NEXTKEY { ## # Make sure file is open ## - if (!defined($self->fh)) { $self->_open(); } + if (!defined($self->_fh)) { $self->_open(); } ## # Request shared lock for reading @@ -90,8 +108,8 @@ sub NEXTKEY { $self->unlock(); - return ($result && $self->root->{filter_fetch_key}) - ? $self->root->{filter_fetch_key}->($result) + return ($result && $self->_root->{filter_fetch_key}) + ? $self->_root->{filter_fetch_key}->($result) : $result; }