X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage.pm;h=e5c7d45a8b68d727f40900d011a8cd364d91763d;hb=13bf737a843f9dcdbf746c28ec4de63439d0e081;hp=799a6af9aedf214ffa21c423a971dbaac99070b8;hpb=be01f1be2db37aa534cb95705dc36bf564ca05f0;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage.pm b/lib/DBIx/Class/Storage.pm index 799a6af..e5c7d45 100644 --- a/lib/DBIx/Class/Storage.pm +++ b/lib/DBIx/Class/Storage.pm @@ -4,6 +4,7 @@ use strict; use warnings; use base qw/DBIx::Class/; +use mro 'c3'; use Scalar::Util qw/weaken/; use Carp::Clan qw/^DBIx::Class/; @@ -168,8 +169,14 @@ In a nested transaction (calling txn_do() from within a txn_do() coderef) only the outermost transaction will issue a L, and txn_do() can be called in void, scalar and list context and it will behave as expected. -Unlike L, the coderef will I be -automatically retried on error. +Please note that all of the code in your coderef, including non-DBIx::Class +code, is part of a transaction. This transaction may fail out halfway, or +it may get partially double-executed (in the case that our DB connection +failed halfway through the transaction, in which case we reconnect and +restart the txn). Therefore it is best that any side-effects in your coderef +are idempotent (that is, can be re-executed multiple times and get the +same result), and that you check up on your side-effects in the case of +transaction failure. =cut