X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FSybase.pm;h=9851303d6a384d024080e48651600a51e7700fad;hb=689819e14e9e6245000c64ece46ddd1bc8293bf5;hp=563010f3c387fa758f147521d44c8bd3ea2fd5a6;hpb=efe75aaad126c383000049b29bb71a7d6da97bed;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage/DBI/Sybase.pm b/lib/DBIx/Class/Storage/DBI/Sybase.pm index 563010f..9851303 100644 --- a/lib/DBIx/Class/Storage/DBI/Sybase.pm +++ b/lib/DBIx/Class/Storage/DBI/Sybase.pm @@ -4,16 +4,27 @@ use strict; use warnings; use base qw/ - DBIx::Class::Storage::DBI::Sybase::Base + DBIx::Class::Storage::DBI::Sybase::Common + DBIx::Class::Storage::DBI::AutoCast /; use mro 'c3'; use Carp::Clan qw/^DBIx::Class/; use List::Util (); +use Sub::Name (); __PACKAGE__->mk_group_accessors('simple' => - qw/_identity _blob_log_on_update auto_cast _insert_txn/ + qw/_identity _blob_log_on_update _writer_storage _is_writer_storage + _identity_method/ ); +my @also_proxy_to_writer_storage = qw/ + connect_call_set_auto_cast auto_cast connect_call_blob_setup + connect_call_datetime_setup + + disconnect _connect_info _sql_maker _sql_maker_opts disable_sth_caching + auto_savepoint unsafe cursor_class debug debugobj schema +/; + =head1 NAME DBIx::Class::Storage::DBI::Sybase - Sybase support for DBIx::Class @@ -31,9 +42,8 @@ will be reblessed to L. You can also enable that driver explicitly, see the documentation for more details. With this driver there is unfortunately no way to get the C -without doing a C. This is done safely in a transaction +(locking the table.) See L. A recommended L setting: @@ -48,7 +58,7 @@ sub _rebless { if (ref($self) eq 'DBIx::Class::Storage::DBI::Sybase') { my $dbtype = eval { - @{$self->dbh->selectrow_arrayref(qq{sp_server_info \@attribute_id=1})}[2] + @{$self->_get_dbh->selectrow_arrayref(qq{sp_server_info \@attribute_id=1})}[2] } || ''; my $exception = $@; @@ -61,10 +71,6 @@ sub _rebless { } else { # real Sybase my $no_bind_vars = 'DBIx::Class::Storage::DBI::Sybase::NoBindVars'; -# This is reset to 0 in ::NoBindVars, only necessary because we use max(col) to -# get the identity. - $self->_insert_txn(1); - if ($self->using_freetds) { carp <<'EOF' unless $ENV{DBIC_SYBASE_FREETDS_NOWARN}; @@ -83,8 +89,8 @@ See perldoc DBIx::Class::Storage::DBI::Sybase for more details. To turn off this warning set the DBIC_SYBASE_FREETDS_NOWARN environment variable. EOF - if (not $self->placeholders_with_type_conversion_supported) { - if ($self->placeholders_supported) { + if (not $self->_typeless_placeholders_supported) { + if ($self->_placeholders_supported) { $self->auto_cast(1); } else { $self->ensure_class_loaded($no_bind_vars); @@ -92,21 +98,53 @@ EOF $self->_rebless; } } - - $self->set_textsize; # based on LongReadLen in connect_info - - } elsif (not $self->dbh->{syb_dynamic_supported}) { -# not necessarily FreeTDS, but no placeholders nevertheless + } + elsif (not $self->_get_dbh->{syb_dynamic_supported}) { + # not necessarily FreeTDS, but no placeholders nevertheless $self->ensure_class_loaded($no_bind_vars); bless $self, $no_bind_vars; $self->_rebless; + } elsif (not $self->_typeless_placeholders_supported) { +# this is highly unlikely, but we check just in case + $self->auto_cast(1); } - - $self->_set_max_connect(256); } } } +sub _init { + my $self = shift; + $self->_set_max_connect(256); + + # based on LongReadLen in connect_info + $self->set_textsize if $self->using_freetds; + +# create storage for insert/(update blob) transactions, +# unless this is that storage + return if $self->_is_writer_storage; + + my $writer_storage = (ref $self)->new; + + $writer_storage->_is_writer_storage(1); + $writer_storage->connect_info($self->connect_info); + $writer_storage->auto_cast($self->auto_cast); + + $self->_writer_storage($writer_storage); +} + +for my $method (@also_proxy_to_writer_storage) { + no strict 'refs'; + no warnings 'redefine'; + + my $replaced = __PACKAGE__->can($method); + + *{$method} = Sub::Name::subname __PACKAGE__."::$method" => sub { + my $self = shift; + $self->_writer_storage->$replaced(@_) if $self->_writer_storage; + return $self->$replaced(@_); + }; +} + # Make sure we have CHAINED mode turned on if AutoCommit is off in non-FreeTDS # DBD::Sybase (since we don't know how DBD::Sybase was compiled.) If however # we're using FreeTDS, CHAINED mode turns on an implicit transaction which we @@ -156,88 +194,47 @@ sub connect_call_blob_setup { if exists $args{log_on_update}; } -=head2 connect_call_set_auto_cast - -In some configurations (usually with L) statements with values bound -to columns or conditions that are not strings will throw implicit type -conversion errors. For L this is automatically detected, and this -option is set. - -It converts placeholders to: - - CAST(? as $type) - -the type is taken from the L setting from -your Result class, and mapped to a Sybase type using a mapping based on -L if necessary. - -This setting can also be set outside of -L at any time using: - - $schema->storage->auto_cast(1); - -=cut - -sub connect_call_set_auto_cast { - my $self = shift; - $self->auto_cast(1); -} - sub _is_lob_type { my $self = shift; my $type = shift; $type && $type =~ /(?:text|image|lob|bytea|binary|memo)/i; } -# The select-piggybacking-on-insert trick stolen from odbc/mssql +sub _is_lob_column { + my ($self, $source, $column) = @_; + + return $self->_is_lob_type($source->column_info($column)->{data_type}); +} + sub _prep_for_execute { my $self = shift; my ($op, $extra_bind, $ident, $args) = @_; my ($sql, $bind) = $self->next::method (@_); -# Some combinations of FreeTDS and Sybase throw implicit conversion errors for -# all placeeholders, so we convert them into CASTs here. -# Based on code in ::DBI::NoBindVars . -# -# If we're using ::NoBindVars, there are no binds by this point so this code -# gets skippeed. - if ($self->auto_cast && @$bind) { - my $new_sql; - my @sql_part = split /\?/, $sql; - my $col_info = $self->_resolve_column_info($ident,[ map $_->[0], @$bind ]); - - foreach my $bound (@$bind) { - my $col = $bound->[0]; - my $syb_type = $self->_syb_base_type($col_info->{$col}{data_type}); - - foreach my $data (@{$bound}[1..$#$bound]) { - $new_sql .= shift(@sql_part) . - ($syb_type ? "CAST(? AS $syb_type)" : '?'); - } - } - $new_sql .= join '', @sql_part; - $sql = $new_sql; - } - if ($op eq 'insert') { my $table = $ident->from; my $bind_info = $self->_resolve_column_info( $ident, [map $_->[0], @{$bind}] ); - my $identity_col = -List::Util::first { $bind_info->{$_}{is_auto_increment} } (keys %$bind_info); + my $identity_col = List::Util::first + { $bind_info->{$_}{is_auto_increment} } + (keys %$bind_info) + ; if ($identity_col) { - $sql = -"SET IDENTITY_INSERT $table ON\n" . -"$sql\n" . -"SET IDENTITY_INSERT $table OFF" - } else { - $identity_col = List::Util::first { - $ident->column_info($_)->{is_auto_increment} - } $ident->columns; + $sql = join ("\n", + "SET IDENTITY_INSERT $table ON", + $sql, + "SET IDENTITY_INSERT $table OFF", + ); + } + else { + $identity_col = List::Util::first + { $ident->column_info($_)->{is_auto_increment} } + $ident->columns + ; } if ($identity_col) { @@ -250,9 +247,10 @@ List::Util::first { $bind_info->{$_}{is_auto_increment} } (keys %$bind_info); return ($sql, $bind); } -# Stolen from SQLT, with some modifications. This will likely change when the -# SQLT Sybase stuff is redone/fixed-up. -my %TYPE_MAPPING = ( +# Stolen from SQLT, with some modifications. This is a makeshift +# solution before a sane type-mapping library is available, thus +# the 'our' for easy overrides. +our %TYPE_MAPPING = ( number => 'numeric', money => 'money', varchar => 'varchar', @@ -270,11 +268,11 @@ my %TYPE_MAPPING = ( long => 'varchar', ); -sub _syb_base_type { +sub _native_data_type { my ($self, $type) = @_; $type = lc $type; - $type =~ s/ identity//; + $type =~ s/\s* identity//x; return uc($TYPE_MAPPING{$type} || $type); } @@ -282,7 +280,9 @@ sub _syb_base_type { sub _fetch_identity_sql { my ($self, $source, $col) = @_; - return "SELECT MAX($col) FROM ".$source->from; + return sprintf ("SELECT MAX(%s) FROM %s", + map { $self->sql_maker->_quote ($_) } ($col, $source->from) + ); } sub _execute { @@ -301,51 +301,207 @@ sub _execute { sub last_insert_id { shift->_identity } -# override to handle TEXT/IMAGE and to do a transaction if necessary +# handles TEXT/IMAGE and transaction for last_insert_id sub insert { - my ($self, $source, $to_insert) = splice @_, 0, 3; - my $dbh = $self->_dbh; + my $self = shift; + my ($source, $to_insert) = @_; my $blob_cols = $self->_remove_blob_cols($source, $to_insert); -# We have to do the insert in a transaction to avoid race conditions with the -# SELECT MAX(COL) identity method used when placeholders are enabled. - my $updated_cols = do { - if ($self->_insert_txn && (not $self->{transaction_depth})) { - my $args = \@_; - my $method = $self->next::can; - $self->txn_do( - sub { $self->$method($source, $to_insert, @$args) } - ); - } else { - $self->next::method($source, $to_insert, @_); - } + my $identity_col = List::Util::first + { $source->column_info($_)->{is_auto_increment} } + $source->columns; + + # do we need the horrific SELECT MAX(COL) hack? + my $dumb_last_insert_id = + $identity_col + && (not exists $to_insert->{$identity_col}) + && ($self->_identity_method||'') ne '@@IDENTITY'; + + my $next = $self->next::can; + + # we are already in a transaction, or there are no blobs + # and we don't need the PK - just (try to) do it + if ($self->{transaction_depth} + || (!$blob_cols && !$dumb_last_insert_id) + ) { + return $self->_insert ( + $next, $source, $to_insert, $blob_cols, $identity_col + ); + } + + # otherwise use the _writer_storage to do the insert+transaction on another + # connection + my $guard = $self->_writer_storage->txn_scope_guard; + + my $updated_cols = $self->_writer_storage->_insert ( + $next, $source, $to_insert, $blob_cols, $identity_col + ); + + $self->_identity($self->_writer_storage->_identity); + + $guard->commit; + + return $updated_cols; +} + +sub _insert { + my ($self, $next, $source, $to_insert, $blob_cols, $identity_col) = @_; + + my $updated_cols = $self->$next ($source, $to_insert); + + my $final_row = { + $identity_col => $self->last_insert_id($source, $identity_col), + %$to_insert, + %$updated_cols, }; - $self->_insert_blobs($source, $blob_cols, $to_insert) if %$blob_cols; + $self->_insert_blobs ($source, $blob_cols, $final_row) if $blob_cols; return $updated_cols; } sub update { - my ($self, $source) = splice @_, 0, 2; - my ($fields, $where) = @_; - my $wantarray = wantarray; + my $self = shift; + my ($source, $fields, $where, @rest) = @_; + + my $wantarray = wantarray; my $blob_cols = $self->_remove_blob_cols($source, $fields); + my $table = $source->name; + + my $identity_col = List::Util::first + { $source->column_info($_)->{is_auto_increment} } + $source->columns; + + my $is_identity_update = $identity_col && defined $fields->{$identity_col}; + + if (not $blob_cols) { + $self->_set_identity_insert($table, 'update') if $is_identity_update; + return $self->next::method(@_); + $self->_unset_identity_insert($table, 'update') if $is_identity_update; + } + +# check that we're not updating a blob column that's also in $where + for my $blob (grep $self->_is_lob_column($source, $_), $source->columns) { + if (exists $where->{$blob} && exists $fields->{$blob}) { + croak +'Update of TEXT/IMAGE column that is also in search condition impossible'; + } + } + +# update+blob update(s) done atomically on separate connection + $self = $self->_writer_storage; + + my $guard = $self->txn_scope_guard; + +# First update the blob columns to be updated to '' (taken from $fields, where +# it is originally put by _remove_blob_cols .) + my %blobs_to_empty = map { ($_ => delete $fields->{$_}) } keys %$blob_cols; + + $self->next::method($source, \%blobs_to_empty, $where, @rest); + +# Now update the blobs before the other columns in case the update of other +# columns makes the search condition invalid. + $self->_update_blobs($source, $blob_cols, $where); + my @res; - if ($wantarray) { - @res = $self->next::method($source, @_); - } else { - $res[0] = $self->next::method($source, @_); + if (%$fields) { + $self->_set_identity_insert($table, 'update') if $is_identity_update; + + if ($wantarray) { + @res = $self->next::method(@_); + } + elsif (defined $wantarray) { + $res[0] = $self->next::method(@_); + } + else { + $self->next::method(@_); + } + + $self->_unset_identity_insert($table, 'update') if $is_identity_update; } - $self->_update_blobs($source, $blob_cols, $where) if %$blob_cols; + $guard->commit; return $wantarray ? @res : $res[0]; } +### the insert_bulk stuff stolen from DBI/MSSQL.pm + +sub _set_identity_insert { + my ($self, $table, $op) = @_; + + my $sql = sprintf ( + 'SET IDENTITY_%s %s ON', + (uc($op) || 'INSERT'), + $self->sql_maker->_quote ($table), + ); + + $self->_query_start($sql); + + my $dbh = $self->_get_dbh; + eval { $dbh->do ($sql) }; + my $exception = $@; + + $self->_query_end($sql); + + if ($exception) { + $self->throw_exception (sprintf "Error executing '%s': %s", + $sql, + $dbh->errstr, + ); + } +} + +sub _unset_identity_insert { + my ($self, $table, $op) = @_; + + my $sql = sprintf ( + 'SET IDENTITY_%s %s OFF', + (uc($op) || 'INSERT'), + $self->sql_maker->_quote ($table), + ); + + $self->_query_start($sql); + + my $dbh = $self->_get_dbh; + $dbh->do ($sql); + + $self->_query_end($sql); +} + +# for tests +sub _can_insert_bulk { 1 } + +# XXX this should use the DBD::Sybase bulk API, where possible +sub insert_bulk { + my $self = shift; + my ($source, $cols, $data) = @_; + + my $is_identity_insert = (List::Util::first + { $source->column_info ($_)->{is_auto_increment} } + (@{$cols}) + ) + ? 1 + : 0; + + if ($is_identity_insert) { + $self->_set_identity_insert ($source->name); + } + + $self->next::method(@_); + + if ($is_identity_insert) { + $self->_unset_identity_insert ($source->name); + } +} + +### end of stolen insert_bulk section + +# Make sure blobs are not bound as placeholders, and return any non-empty ones +# as a hash. sub _remove_blob_cols { my ($self, $source, $fields) = @_; @@ -353,12 +509,18 @@ sub _remove_blob_cols { for my $col (keys %$fields) { if ($self->_is_lob_type($source->column_info($col)->{data_type})) { - $blob_cols{$col} = delete $fields->{$col}; - $fields->{$col} = \"''"; + my $blob_val = delete $fields->{$col}; + if (not defined $blob_val) { + $fields->{$col} = \'NULL'; + } + else { + $fields->{$col} = \"''"; + $blob_cols{$col} = $blob_val unless $blob_val eq ''; + } } } - return \%blob_cols; + return keys %blob_cols ? \%blob_cols : undef; } sub _update_blobs { @@ -366,7 +528,7 @@ sub _update_blobs { my (@primary_cols) = $source->primary_columns; - croak "Cannot update TEXT/IMAGE column(s) without a primary key" + $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key') unless @primary_cols; # check if we're updating a single row by PK @@ -381,14 +543,10 @@ sub _update_blobs { @row_to_update{@primary_cols} = @{$where}{@primary_cols}; @rows = \%row_to_update; } else { - my $rs = $source->resultset->search( - $where, - { - result_class => 'DBIx::Class::ResultClass::HashRefInflator', - select => \@primary_cols - } - ); - @rows = $rs->all; # statement must finish + my $cursor = $self->select ($source, \@primary_cols, $where, {}); + @rows = map { + my %row; @row{@primary_cols} = @$_; \%row + } $cursor->all; } for my $row (@rows) { @@ -398,35 +556,36 @@ sub _update_blobs { sub _insert_blobs { my ($self, $source, $blob_cols, $row) = @_; - my $dbh = $self->dbh; + my $dbh = $self->_get_dbh; - my $table = $source->from; + my $table = $source->name; my %row = %$row; my (@primary_cols) = $source->primary_columns; - croak "Cannot update TEXT/IMAGE column(s) without a primary key" + $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key') unless @primary_cols; - if ((grep { defined $row{$_} } @primary_cols) != @primary_cols) { - if (@primary_cols == 1) { - my $col = $primary_cols[0]; - $row{$col} = $self->last_insert_id($source, $col); - } else { - croak "Cannot update TEXT/IMAGE column(s) without primary key values"; - } - } + $self->throw_exception('Cannot update TEXT/IMAGE column(s) without primary key values') + if ((grep { defined $row{$_} } @primary_cols) != @primary_cols); for my $col (keys %$blob_cols) { my $blob = $blob_cols->{$col}; my %where = map { ($_, $row{$_}) } @primary_cols; - my $cursor = $source->resultset->search(\%where, { - select => [$col] - })->cursor; + + my $cursor = $self->select ($source, [$col], \%where, {}); $cursor->next; my $sth = $cursor->sth; + if (not $sth) { + + $self->throw_exception( + "Could not find row in table '$table' for blob update:\n" + . $self->_pretty_print (\%where) + ); + } + eval { do { $sth->func('CS_GET', 1, 'ct_data_info') or die $sth->errstr; @@ -450,11 +609,12 @@ sub _insert_blobs { $sth->finish if $sth; if ($exception) { if ($self->using_freetds) { - croak -"TEXT/IMAGE operation failed, probably because you're using FreeTDS: " . -$exception; + $self->throw_exception ( + 'TEXT/IMAGE operation failed, probably because you are using FreeTDS: ' + . $exception + ); } else { - croak $exception; + $self->throw_exception($exception); } } } @@ -487,7 +647,7 @@ C columns only have minute precision. my $dbh = $self->_dbh; if ($dbh->can('syb_date_fmt')) { -# amazingly, this works with FreeTDS + # amazingly, this works with FreeTDS $dbh->syb_date_fmt('ISO_strict'); } elsif (not $old_dbd_warned) { carp "Your DBD::Sybase is too old to support ". @@ -513,7 +673,7 @@ sub _dbh_begin_work { my $self = shift; $self->next::method(@_); if ($self->using_freetds) { - $self->dbh->do('BEGIN TRAN'); + $self->_get_dbh->do('BEGIN TRAN'); } } @@ -538,7 +698,7 @@ sub _dbh_rollback { sub _svp_begin { my ($self, $name) = @_; - $self->dbh->do("SAVE TRANSACTION $name"); + $self->_get_dbh->do("SAVE TRANSACTION $name"); } # A new SAVE TRANSACTION with the same name releases the previous one. @@ -547,7 +707,7 @@ sub _svp_release { 1 } sub _svp_rollback { my ($self, $name) = @_; - $self->dbh->do("ROLLBACK TRANSACTION $name"); + $self->_get_dbh->do("ROLLBACK TRANSACTION $name"); } 1; @@ -559,7 +719,7 @@ allow you to dump a schema from most (if not all) versions of Sybase. It is available via subversion from: - http://dev.catalyst.perl.org/repos/bast/branches/DBIx-Class-Schema-Loader/mssql_tweaks + http://dev.catalyst.perl.org/repos/bast/branches/DBIx-Class-Schema-Loader/current/ =head1 FreeTDS @@ -582,17 +742,69 @@ Some versions of the libraries involved will not support placeholders, in which case the storage will be reblessed to L. -In some configurations, placeholders will work but will throw implicit +In some configurations, placeholders will work but will throw implicit type conversion errors for anything that's not expecting a string. In such a case, -the C option is automatically set, which you may enable yourself with -L (see the description of that method for more -details.) +the C option from L is +automatically set, which you may enable on connection with +L. The type info +for the Cs is taken from the L +definitions in your Result classes, and are mapped to a Sybase type (if it isn't +already) using a mapping based on L. In other configurations, placeholers will work just as they do with the Sybase Open Client libraries. Inserts or updates of TEXT/IMAGE columns will B work with FreeTDS. +=head1 INSERTS WITH PLACEHOLDERS + +With placeholders enabled, inserts are done in a transaction so that there are +no concurrency issues with getting the inserted identity value using +C as it's a +session variable. + +=head1 TRANSACTIONS + +Due to limitations of the TDS protocol, L, or both; you cannot +begin a transaction while there are active cursors. An active cursor is, for +example, a L that has been executed using +C or C but has not been exhausted or +L. + +For example, this will not work: + + $schema->txn_do(sub { + my $rs = $schema->resultset('Book'); + while (my $row = $rs->next) { + $schema->resultset('MetaData')->create({ + book_id => $row->id, + ... + }); + } + }); + +Transactions done for inserts in C mode when placeholders are in use +are not affected, as they are done on an extra database handle. + +Some workarounds: + +=over 4 + +=item * use L + +=item * L another L + +=item * load the data from your cursor with L + +=back + =head1 MAXIMUM CONNECTIONS The TDS protocol makes separate connections to the server for active statements @@ -634,7 +846,7 @@ C command on connection. See L for a L setting you need to work with C columns. -=head1 AUTHORS +=head1 AUTHOR See L.