X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FSybase.pm;h=77b77e2273395f0e72f815bc7c463cd6dca44770;hb=b718fd0a54e55098bf7103e9af83de9db4b192ab;hp=d92a60e2e8ad11b3cb1d98f84350d595c9d14a91;hpb=9041a97a57cd2831d20e3b25772b29f9af3d8ef9;p=dbsrgits%2FDBIx-Class.git

diff --git a/lib/DBIx/Class/Storage/DBI/Sybase.pm b/lib/DBIx/Class/Storage/DBI/Sybase.pm
index d92a60e..77b77e2 100644
--- a/lib/DBIx/Class/Storage/DBI/Sybase.pm
+++ b/lib/DBIx/Class/Storage/DBI/Sybase.pm
@@ -3,193 +3,124 @@ package DBIx::Class::Storage::DBI::Sybase;
 use strict;
 use warnings;
 
-use Class::C3;
 use base qw/DBIx::Class::Storage::DBI/;
 
-use Carp::Clan qw/^DBIx::Class/;
+=head1 NAME
+
+DBIx::Class::Storage::DBI::Sybase - Base class for drivers using
+L<DBD::Sybase>
+
+=head1 DESCRIPTION
+
+This is the base class/dispatcher for Storage's designed to work with
+L<DBD::Sybase>
+
+=head1 METHODS
+
+=cut
 
 sub _rebless {
   my $self = shift;
 
-  if (ref($self) eq 'DBIx::Class::Storage::DBI::Sybase') {
-    my $dbtype = eval {
-      @{$self->dbh->selectrow_arrayref(qq{sp_server_info \@attribute_id=1})}[2]
-    } || '';
+  my $dbtype = eval {
+    @{$self->_get_dbh->selectrow_arrayref(qq{sp_server_info \@attribute_id=1})}[2]
+  };
+
+  $self->throw_exception("Unable to estable connection to determine database type: $@")
+    if $@;
 
-    my $exception = $@;
+  if ($dbtype) {
     $dbtype =~ s/\W/_/gi;
-    my $subclass = "DBIx::Class::Storage::DBI::Sybase::${dbtype}";
 
-    if (!$exception && $dbtype && $self->load_optional_class($subclass)) {
+    # saner class name
+    $dbtype = 'ASE' if $dbtype eq 'SQL_Server';
+
+    my $subclass = __PACKAGE__ . "::$dbtype";
+    if ($self->load_optional_class($subclass)) {
       bless $self, $subclass;
       $self->_rebless;
-    } else {
-      # real Sybase
-      if (not $self->dbh->{syb_dynamic_supported}) {
-        bless $self, 'DBIx::Class::Storage:DBI::Sybase::NoBindVars';
-        $self->_rebless;
-      }
-      $self->connect_call_datetime_setup;
-      $self->connect_call_blob_setup;
     }
   }
 }
 
-sub _populate_dbh {
+sub _ping {
   my $self = shift;
-  $self->next::method(@_);
-  $self->connect_call_datetime_setup;
-  $self->connect_call_blob_setup;
-  1;
-}
 
-=head2 connect_call_blob_setup
+  my $dbh = $self->_dbh or return 0;
 
-Used as:
+  local $dbh->{RaiseError} = 1;
+  local $dbh->{PrintError} = 0;
 
-  on_connect_call => 'blob_setup'
-
-Does C<< $dbh->{syb_binary_images} = 1; >> to return C<IMAGE> data as raw binary
-instead of as a hex string.
-
-Recommended.
+  if ($dbh->{syb_no_child_con}) {
+# if extra connections are not allowed, then ->ping is reliable
+    my $ping = eval { $dbh->ping };
+    return $@ ? 0 : $ping;
+  }
 
-=cut
+  eval {
+# XXX if the main connection goes stale, does opening another for this statement
+# really determine anything?
+    $dbh->do('select 1');
+  };
 
-sub connect_call_blob_setup {
-  my $self = shift;
-  my $dbh = $self->_dbh;
-  $dbh->{syb_binary_images} = 1;
+  return $@ ? 0 : 1;
 }
 
-=head2 connect_call_datetime_setup
-
-Used as:
-
-  on_connect_call => 'datetime_setup'
-
-In L<DBIx::Class::Storage::DBI/connect_info> to set:
-
-  $dbh->syb_date_fmt('ISO_strict'); # output fmt: 2004-08-21T14:36:48.080Z
-  $dbh->do('set dateformat mdy');   # input fmt:  08/13/1979 18:08:55.080
-
-On connection for use with L<DBIx::Class::InflateColumn::DateTime>, using
-L<DateTime::Format::Sybase>, which you will need to install.
-
-This works for both C<DATETIME> and C<SMALLDATETIME> columns, although
-C<SMALLDATETIME> columns only have minute precision.
-
-=cut
-
-{
-  my $old_dbd_warned = 0;
-
-  sub connect_call_datetime_setup {
-    my $self = shift;
-    my $dbh = $self->_dbh;
+sub _set_max_connect {
+  my $self = shift;
+  my $val  = shift || 256;
 
-    if ($dbh->can('syb_date_fmt')) {
-      $dbh->syb_date_fmt('ISO_strict');
-    } elsif (not $old_dbd_warned) {
-      carp "Your DBD::Sybase is too old to support ".
-      "DBIx::Class::InflateColumn::DateTime, please upgrade!";
-      $old_dbd_warned = 1;
-    }
+  my $dsn = $self->_dbi_connect_info->[0];
 
-    $dbh->do('set dateformat mdy');
+  return if ref($dsn) eq 'CODE';
 
-    1;
+  if ($dsn !~ /maxConnect=/) {
+    $self->_dbi_connect_info->[0] = "$dsn;maxConnect=$val";
+    my $connected = defined $self->_dbh;
+    $self->disconnect;
+    $self->ensure_connected if $connected;
   }
 }
 
-sub datetime_parser_type { "DateTime::Format::Sybase" }
+=head2 using_freetds
 
-sub _dbh_last_insert_id {
-  my ($self, $dbh, $source, $col) = @_;
-
-  # sorry, there's no other way!
-  my $sth = $dbh->prepare_cached("select max($col) from ".$source->from);
-  return ($dbh->selectrow_array($sth))[0];
-}
-
-=head2 count
-
-Counts for limited queries are emulated by executing select queries and
-returning the number of successful executions minus the offset.
-
-This is necessary due to the limitations of Sybase.
+Whether or not L<DBD::Sybase> was compiled against FreeTDS. If false, it means
+the Sybase OpenClient libraries were used.
 
 =cut
 
-sub count {
+sub using_freetds {
   my $self = shift;
-  my ($source, $attrs) = @_;
-
-  if (not exists $attrs->{rows}) {
-    return $self->next::method(@_);
-  }
 
-  my $offset = $attrs->{offset} || 0;
-  my $total  = $attrs->{rows} + $offset;
+  return $self->_get_dbh->{syb_oc_version} =~ /freetds/i;
+}
 
-  my $new_attrs = $self->_copy_attributes_for_count($source, $attrs);
+=head2 set_textsize
 
-  my $first_pk = ($source->primary_columns)[0];
+When using FreeTDS and/or MSSQL, C<< $dbh->{LongReadLen} >> is not available,
+use this function instead. It does:
 
-  $new_attrs->{select} = $first_pk ? "me.$first_pk" : 1;
+  $dbh->do("SET TEXTSIZE $bytes");
 
-  my $tmp_rs = $source->resultset_class->new($source, $new_attrs);
+Takes the number of bytes, or uses the C<LongReadLen> value from your
+L<DBIx::Class/connect_info> if omitted, lastly falls back to the C<32768> which
+is the L<DBD::Sybase> default.
 
-  $self->dbh->{syb_rowcount} = $total;
+=cut
 
-  my $count = 0;
-  $count++ while $tmp_rs->cursor->next;
+sub set_textsize {
+  my $self = shift;
+  my $text_size = shift ||
+    eval { $self->_dbi_connect_info->[-1]->{LongReadLen} } ||
+    32768; # the DBD::Sybase default
 
-  $self->dbh->{syb_rowcount} = 0;
+  return unless defined $text_size;
 
-  return $count - $offset;
+  $self->_dbh->do("SET TEXTSIZE $text_size");
 }
 
 1;
 
-=head1 NAME
-
-DBIx::Class::Storage::DBI::Sybase - Storage::DBI subclass for Sybase
-
-=head1 SYNOPSIS
-
-This subclass supports L<DBD::Sybase> for real Sybase databases.  If you are
-using an MSSQL database via L<DBD::Sybase>, your storage will be reblessed to
-L<DBIx::Class::Storage::DBI::Sybase::Microsoft_SQL_Server>.
-
-=head1 DESCRIPTION
-
-If your version of Sybase does not support placeholders, then your storage
-will be reblessed to L<DBIx::Class::Storage::DBI::Sybase::NoBindVars>. You can
-also enable that driver explicitly, see the documentation for more details.
-
-With this driver there is unfortunately no way to get the C<last_insert_id>
-without doing a C<select max(col)>.
-
-But your queries will be cached.
-
-A recommended L<DBIx::Class::Storage::DBI/connect_info> setting:
-
-  on_connect_call => [qw/datetime_setup blob_setup/]
-
-=head1 DATES
-
-See L</connect_call_datetime_setup> to setup date formats
-for L<DBIx::Class::InflateColumn::DateTime>.
-
-=head1 IMAGE AND TEXT COLUMNS
-
-See L</connect_call_blob_setup> for a L<DBIx::Class::Storage::DBI/connect_info>
-setting you need to work with C<IMAGE> columns.
-
-Due to limitations in L<DBD::Sybase> and this driver, it is only possible to
-select one C<TEXT> or C<IMAGE> column at a time.
-
 =head1 AUTHORS
 
 See L<DBIx::Class/CONTRIBUTORS>.
@@ -199,4 +130,3 @@ See L<DBIx::Class/CONTRIBUTORS>.
 You may distribute this code under the same terms as Perl itself.
 
 =cut
-# vim:sts=2 sw=2: