X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FSybase%2FNoBindVars.pm;h=32908ee0174cde181bc5b9f7caa4e03568885e48;hb=48a76fcfd023d2149f6980bd9a7bdc4937dbc4fc;hp=7b59d0a95f136389b18249b0cce81b1f4336043a;hpb=166c656193b56e08b472c675e92b9076aac03a53;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage/DBI/Sybase/NoBindVars.pm b/lib/DBIx/Class/Storage/DBI/Sybase/NoBindVars.pm index 7b59d0a..32908ee 100644 --- a/lib/DBIx/Class/Storage/DBI/Sybase/NoBindVars.pm +++ b/lib/DBIx/Class/Storage/DBI/Sybase/NoBindVars.pm @@ -1,21 +1,21 @@ package DBIx::Class::Storage::DBI::Sybase::NoBindVars; -use Class::C3; use base qw/ DBIx::Class::Storage::DBI::NoBindVars DBIx::Class::Storage::DBI::Sybase /; +use mro 'c3'; use List::Util (); use Scalar::Util (); -sub _rebless { +sub _init { my $self = shift; $self->disable_sth_caching(1); - $self->insert_txn(0); + $self->_identity_method('@@IDENTITY'); + $self->next::method (@_); } -# this works when NOT using placeholders -sub _fetch_identity_sql { 'SELECT @@IDENTITY' } +sub _fetch_identity_sql { 'SELECT ' . $_[0]->_identity_method } my $number = sub { Scalar::Util::looks_like_number($_[0]) }; @@ -32,22 +32,18 @@ my %noquote = ( numeric => $decimal, ); -sub should_quote_value { +sub interpolate_unquoted { my $self = shift; my ($type, $value) = @_; return $self->next::method(@_) if not defined $value or not defined $type; if (my $key = List::Util::first { $type =~ /$_/i } keys %noquote) { - return 0 if $noquote{$key}->($value); - } elsif ($self->is_datatype_numeric($type) && $number->($value)) { - return 0; + return 1 if $noquote{$key}->($value); + } + elsif ($self->is_datatype_numeric($type) && $number->($value)) { + return 1; } - -## try to guess based on value -# elsif (not $type) { -# return 0 if $number->($value) || $noquote->{money}->($value); -# } return $self->next::method(@_); }