X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FReplicated.pm;h=04b94f29de555b68bea6dec8474d4276e9562b9c;hb=bf51641f97a504ae9796fcc45da4e409c6466ca4;hp=447747514dd38272da3c17fa1c9e635944407822;hpb=64ae166780d0cb2b9577e506da9b9b240c146d20;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage/DBI/Replicated.pm b/lib/DBIx/Class/Storage/DBI/Replicated.pm index 4477475..04b94f2 100644 --- a/lib/DBIx/Class/Storage/DBI/Replicated.pm +++ b/lib/DBIx/Class/Storage/DBI/Replicated.pm @@ -345,7 +345,6 @@ has 'write_handler' => ( _sqlt_minimum_version _sql_maker_opts _conn_pid - _conn_tid _dbh_autocommit _native_data_type _get_dbh @@ -356,21 +355,17 @@ has 'write_handler' => ( _resolve_column_info _prune_unused_joins _strip_cond_qualifiers - _extract_order_columns _resolve_aliastypes_from_select_args _execute _do_query _dbh_sth _dbh_execute - _prefetch_insert_auto_nextvals /], ); my @unimplemented = qw( _arm_global_destructor - _preserve_foreign_dbh _verify_pid - _verify_tid get_use_dbms_capability set_use_dbms_capability @@ -382,6 +377,9 @@ my @unimplemented = qw( _inner_join_to_node _group_over_selection + _prefetch_autovalues + _extract_order_criteria + _max_column_bytesize ); # the capability framework @@ -411,8 +409,6 @@ C, C, C and C. around connect_info => sub { my ($next, $self, $info, @extra) = @_; - my $wantarray = wantarray; - my $merge = Hash::Merge->new('LEFT_PRECEDENT'); my %opts; @@ -449,11 +445,11 @@ around connect_info => sub { $self->_master_connect_info_opts(\%opts); - my (@res, $res); - if ($wantarray) { + my @res; + if (wantarray) { @res = $self->$next($info, @extra); } else { - $res = $self->$next($info, @extra); + $res[0] = $self->$next($info, @extra); } # Make sure master is blessed into the correct class and apply role to it. @@ -466,7 +462,7 @@ around connect_info => sub { # link pool back to master $self->pool->master($master); - $wantarray ? @res : $res; + wantarray ? @res : $res[0]; }; =head1 METHODS @@ -681,7 +677,7 @@ sub execute_reliably { $self->read_handler($current); }; - return $want_array ? @result : $result[0]; + return wantarray ? @result : $result[0]; } =head2 set_reliable_storage