X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FPg.pm;h=aecaa7e9e7f25a867490f71e978252c433fef4df;hb=7eb4ecc8fc02a8b99fbe8be59b03321dd773ab9a;hp=88d401b91dd5b30e877cb2e3f31329679d83b154;hpb=843f8ecda2d9885b79402416f048016c1ecc4114;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/lib/DBIx/Class/Storage/DBI/Pg.pm b/lib/DBIx/Class/Storage/DBI/Pg.pm index 88d401b..aecaa7e 100644 --- a/lib/DBIx/Class/Storage/DBI/Pg.pm +++ b/lib/DBIx/Class/Storage/DBI/Pg.pm @@ -7,39 +7,43 @@ use base qw/DBIx::Class::Storage::DBI/; # __PACKAGE__->load_components(qw/PK::Auto/); +# Warn about problematic versions of DBD::Pg +warn "DBD::Pg 1.49 is strongly recommended" + if ($DBD::Pg::VERSION < 1.49); + sub last_insert_id { - my ($self, $source) = @_; - $self->get_autoinc_seq unless $self->{_autoinc_seq}; - $self->_dbh->last_insert_id(undef,undef,undef,undef, - {sequence=>$self->{_autoinc_seq}}); + my ($self,$source,$col) = @_; + my $seq = ($source->column_info($col)->{sequence} ||= $self->get_autoinc_seq($source,$col)); + $self->_dbh->last_insert_id(undef,undef,undef,undef, {sequence => $seq}); } sub get_autoinc_seq { - my $self = shift; - - # return the user-defined sequence if known - if ($source->sequence) { - return $self->{_autoinc_seq} = $source->sequence; - } - + my ($self,$source,$col) = @_; + my @pri = $source->primary_columns; my $dbh = $self->_dbh; - my ($schema,$table) = $source->name =~ /^(.+)\.(.+)$/ ? ($1,$2) : (undef,$sou -rce->table); + my ($schema,$table) = $source->name =~ /^(.+)\.(.+)$/ ? ($1,$2) + : (undef,$source->name); while (my $col = shift @pri) { - my $info = $dbh->column_info(undef,$schema,$table,$col)->fetchrow_arrayref; - if (defined $info->[12] and $info->[12] =~ - /^nextval\('"?([^"']+)"?'::(?:text|regclass)\)/) + my $info = $dbh->column_info(undef,$schema,$table,$col)->fetchrow_hashref; + if (defined $info->{COLUMN_DEF} and $info->{COLUMN_DEF} =~ + /^nextval\(+'([^']+)'::(?:text|regclass)\)/) { - $self->{_autoinc_seq} = $1; - last; - } + my $seq = $1; + return $seq =~ /\./ ? $seq : $info->{TABLE_SCHEM} . "." . $seq; # may need to strip quotes -- see if this works + } } } +sub sqlt_type { + return 'PostgreSQL'; +} + +sub datetime_parser_type { return "DateTime::Format::Pg"; } + 1; -=head1 NAME +=head1 NAME DBIx::Class::Storage::DBI::Pg - Automatic primary key class for PostgreSQL