X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FNoBindVars.pm;h=126b9de2bd28327ee1ceefa19f04626dd7906d54;hb=bc144884abdf828846ecc29122647fdaf1ac2487;hp=c3ba153be1a91417d19afd3f0983765fa1a27f55;hpb=28cea3aa579791963ea117bdbfdbd4ee3e948555;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm index c3ba153..126b9de 100644 --- a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm +++ b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm @@ -59,8 +59,11 @@ sub _prep_for_execute { foreach my $data (@$bound) { $data = ''.$data if ref $data; + $data = $self->transform_unbound_value($datatype, $data) + if $datatype; + $data = $self->_dbh->quote($data) - if $self->should_quote_value($datatype, $data); + if (!$datatype || $self->should_quote_value($datatype, $data)); $new_sql .= shift(@sql_part) . $data; } @@ -71,7 +74,7 @@ sub _prep_for_execute { } =head2 should_quote_value - + This method is called by L for every column in order to determine if its value should be quoted or not. The arguments are the current column data type and the actual bind value. The return @@ -79,16 +82,25 @@ value is interpreted as: true - do quote, false - do not quote. You should override this in you Storage::DBI:: subclass, if your RDBMS does not like quotes around certain datatypes (e.g. Sybase and integer columns). The default method always returns true (do quote). - + WARNING!!! - + Always validate that the bind-value is valid for the current datatype. Otherwise you may very well open the door to SQL injection attacks. - + =cut - + sub should_quote_value { 1 } +=head2 transform_unbound_value + +Given a datatype and the value to be inserted directly into a SQL query, returns +the necessary SQL fragment to represent that value. + +=cut + +sub transform_unbound_value { $_[2] } + =head1 AUTHORS Brandon Black