X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FNoBindVars.pm;h=126b9de2bd28327ee1ceefa19f04626dd7906d54;hb=7eee5c151525ef17674dac9b914acbd98f5f2f97;hp=b8684fd492dd428cfd956893067bbe76c59fd87a;hpb=a9f32dbced12b2b6c4f8b8a7aa142d5922350830;p=dbsrgits%2FDBIx-Class.git

diff --git a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
index b8684fd..126b9de 100644
--- a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
+++ b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
@@ -4,64 +4,107 @@ use strict;
 use warnings;
 
 use base 'DBIx::Class::Storage::DBI';
+use mro 'c3';
 
-sub _execute {
-  my ($self, $op, $extra_bind, $ident, @args) = @_;
-  my ($sql, @bind) = $self->sql_maker->$op($ident, @args);
-  unshift(@bind, @$extra_bind) if $extra_bind;
-  if ($self->debug) {
-    my @debug_bind = map { defined $_ ? qq{'$_'} : q{'NULL'} } @bind;
-    $self->debugobj->query_start($sql, @debug_bind);
-  }
+=head1 NAME 
 
-  while(my $bvar = shift @bind) {
-    $bvar = $self->_dbh->quote($bvar);
-    $sql =~ s/\?/$bvar/;
-  }
+DBIx::Class::Storage::DBI::NoBindVars - Sometime DBDs have poor to no support for bind variables
 
-  my $sth = eval { $self->sth($sql,$op) };
+=head1 DESCRIPTION
 
-  if (!$sth || $@) {
-    $self->throw_exception(
-      'no sth generated via sql (' . ($@ || $self->_dbh->errstr) . "): $sql"
-    );
-  }
+This class allows queries to work when the DBD or underlying library does not
+support the usual C<?> placeholders, or at least doesn't support them very
+well, as is the case with L<DBD::Sybase>
+
+=head1 METHODS
+
+=head2 connect_info
+
+We can't cache very effectively without bind variables, so force the C<disable_sth_caching> setting to be turned on when the connect info is set.
+
+=cut
+
+sub connect_info {
+    my $self = shift;
+    my $retval = $self->next::method(@_);
+    $self->disable_sth_caching(1);
+    $retval;
+}
+
+=head2 _prep_for_execute
+
+Manually subs in the values for the usual C<?> placeholders.
+
+=cut
+
+sub _prep_for_execute {
+  my $self = shift;
+
+  my ($op, $extra_bind, $ident, $args) = @_;
+
+  my ($sql, $bind) = $self->next::method(@_);
+
+  # stringify args, quote via $dbh, and manually insert
 
-  my $rv;
-  if ($sth) {
-    my $time = time();
-    $rv = eval { $sth->execute };
+  my @sql_part = split /\?/, $sql;
+  my $new_sql;
 
-    if ($@ || !$rv) {
-      $self->throw_exception("Error executing '$sql': ".($@ || $sth->errstr));
+  my $col_info = $self->_resolve_column_info($ident, [ map $_->[0], @$bind ]);
+
+  foreach my $bound (@$bind) {
+    my $col = shift @$bound;
+
+    my $datatype = $col_info->{$col}{data_type};
+
+    foreach my $data (@$bound) {
+      $data = ''.$data if ref $data;
+
+      $data = $self->transform_unbound_value($datatype, $data)
+        if $datatype;
+
+      $data = $self->_dbh->quote($data)
+        if (!$datatype || $self->should_quote_value($datatype, $data));
+
+      $new_sql .= shift(@sql_part) . $data;
     }
-  } else {
-    $self->throw_exception("'$sql' did not generate a statement.");
   }
-  if ($self->debug) {
-    my @debug_bind = map { defined $_ ? qq{`$_'} : q{`NULL'} } @bind;
-    $self->debugobj->query_end($sql, @debug_bind);
-  }
-  return (wantarray ? ($rv, $sth, @bind) : $rv);
+  $new_sql .= join '', @sql_part;
+
+  return ($new_sql, []);
 }
 
-1;
+=head2 should_quote_value
 
-=head1 NAME 
+This method is called by L</_prep_for_execute> for every column in
+order to determine if its value should be quoted or not. The arguments
+are the current column data type and the actual bind value. The return
+value is interpreted as: true - do quote, false - do not quote. You should
+override this in you Storage::DBI::<database> subclass, if your RDBMS
+does not like quotes around certain datatypes (e.g. Sybase and integer
+columns). The default method always returns true (do quote).
 
-DBIx::Class::Storage::DBI::NoBindVars - Sometime DBDs have poor to no support for bind variables
+ WARNING!!!                     
 
-=head1 SYNOPSIS
+ Always validate that the bind-value is valid for the current datatype.
+ Otherwise you may very well open the door to SQL injection attacks.
 
-=head1 DESCRIPTION
+=cut                            
 
-This class allows queries to work when the DBD or underlying library does not
-support the usual C<?> placeholders, or at least doesn't support them very
-well, as is the case with L<DBD::Sybase>
+sub should_quote_value { 1 }
+
+=head2 transform_unbound_value
+
+Given a datatype and the value to be inserted directly into a SQL query, returns
+the necessary SQL fragment to represent that value.
+
+=cut
+
+sub transform_unbound_value { $_[2] }
 
 =head1 AUTHORS
 
 Brandon Black <blblack@gmail.com>
+
 Trym Skaar <trym@tryms.no>
 
 =head1 LICENSE
@@ -69,3 +112,5 @@ Trym Skaar <trym@tryms.no>
 You may distribute this code under the same terms as Perl itself.
 
 =cut
+
+1;