X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FCursor.pm;h=3d59e84a04bd6b522de93e4d46cf86007f52d069;hb=8c4b6c50e873a2b5993d1bfe0f40763d994b7da4;hp=0fe570f1deec357f7bbc2d44ab6ba68c66459fde;hpb=2007929b1d9c679e67f85a9ab37c804111e66311;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage/DBI/Cursor.pm b/lib/DBIx/Class/Storage/DBI/Cursor.pm index 0fe570f..3d59e84 100644 --- a/lib/DBIx/Class/Storage/DBI/Cursor.pm +++ b/lib/DBIx/Class/Storage/DBI/Cursor.pm @@ -1,10 +1,10 @@ package DBIx::Class::Storage::DBI::Cursor; -use base qw/DBIx::Class::Cursor/; - use strict; use warnings; +use base qw/DBIx::Class::Cursor/; + =head1 NAME DBIx::Class::Storage::DBI::Cursor - Object representing a query cursor on a @@ -49,32 +49,6 @@ sub new { return bless ($new, $class); } -=head2 as_query - -=over 4 - -=item Arguments: none - -=item Return Value: \[ $sql, @bind ] - -=back - -Returns the SQL statement and bind vars associated with the invocant. - -=cut - -sub as_query { - my $self = shift; - - my $storage = $self->{storage}; - my $sql_maker = $storage->sql_maker; - local $sql_maker->{for}; - - my @args = $storage->_select_args(@{$self->{args}}); - my ($sql, $bind) = $storage->_prep_for_execute(@args[0 .. 2], [@args[4 .. $#args]]); - return \[ "($sql)", @$bind ]; -} - =head2 next =over 4 @@ -94,7 +68,11 @@ sub _dbh_next { my ($storage, $dbh, $self) = @_; $self->_check_dbh_gen; - if ($self->{attrs}{rows} && $self->{pos} >= $self->{attrs}{rows}) { + if ( + $self->{attrs}{software_limit} + && $self->{attrs}{rows} + && $self->{pos} >= $self->{attrs}{rows} + ) { $self->{sth}->finish if $self->{sth}->{Active}; delete $self->{sth}; $self->{done} = 1; @@ -152,8 +130,9 @@ sub all { my ($self) = @_; if ($self->{attrs}{software_limit} && ($self->{attrs}{offset} || $self->{attrs}{rows})) { - return $self->SUPER::all; + return $self->next::method; } + $self->{storage}->dbh_do($self->can('_dbh_all'), $self); }