X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStorage%2FDBI%2FADO.pm;h=db8517dc30a26184a02ab4f8bae7006001b7ddb1;hb=23b2c49b17262ecf84307c9ffba88ed38ecc90cb;hp=469564d09834dfbfbae0125025ce5b9010c93e46;hpb=75d3bdb2431d0e2762e51b9dc7e03195240484bb;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Storage/DBI/ADO.pm b/lib/DBIx/Class/Storage/DBI/ADO.pm index 469564d..db8517d 100644 --- a/lib/DBIx/Class/Storage/DBI/ADO.pm +++ b/lib/DBIx/Class/Storage/DBI/ADO.pm @@ -1,10 +1,14 @@ package DBIx::Class::Storage::DBI::ADO; +use warnings; +use strict; + use base 'DBIx::Class::Storage::DBI'; use mro 'c3'; use Sub::Name; use Try::Tiny; +use DBIx::Class::_Util 'sigwarn_silencer'; use namespace::clean; =head1 NAME @@ -26,12 +30,9 @@ sub _rebless { shift->_determine_connector_driver('ADO') } sub _dbh_get_info { my $self = shift; - my $warn_handler = $SIG{__WARN__} || sub { warn @_ }; - - local $SIG{__WARN__} = sub { - $warn_handler->(@_) - unless $_[0] =~ m{^Missing argument in sprintf at \S+/ADO/GetInfo\.pm}; - }; + local $SIG{__WARN__} = sigwarn_silencer( + qr{^Missing argument in sprintf at \S+/ADO/GetInfo\.pm} + ); $self->next::method(@_); } @@ -49,11 +50,9 @@ sub _init { my $disconnect = *DBD::ADO::db::disconnect{CODE}; *DBD::ADO::db::disconnect = subname 'DBD::ADO::db::disconnect' => sub { - my $warn_handler = $SIG{__WARN__} || sub { warn @_ }; - local $SIG{__WARN__} = sub { - $warn_handler->(@_) - unless $_[0] =~ /Not a Win32::OLE object|uninitialized value/; - }; + local $SIG{__WARN__} = sigwarn_silencer( + qr/Not a Win32::OLE object|uninitialized value/ + ); $disconnect->(@_); }; } @@ -64,7 +63,7 @@ sub _init { # Here I was just experimenting with ADO cursor types, left in as a comment in # case you want to as well. See the DBD::ADO docs. -#sub _dbh_sth { +#sub _prepare_sth { # my ($self, $dbh, $sql) = @_; # # my $sth = $self->disable_sth_caching