X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FStartupCheck.pm;h=17ca65f7930d8f74bc59162a47c5f3c52680a4a1;hb=97940e368df996e1fe6111fb14f560594dc4c0b2;hp=339aebce9ad432af9585d2fe397bb41d24c0febd;hpb=5a7651d5e761836fdf5eac9bf1dc4f4a84cdc545;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/StartupCheck.pm b/lib/DBIx/Class/StartupCheck.pm index 339aebc..17ca65f 100644 --- a/lib/DBIx/Class/StartupCheck.pm +++ b/lib/DBIx/Class/StartupCheck.pm @@ -1,34 +1,11 @@ package DBIx::Class::StartupCheck; -BEGIN { +use warnings; +use strict; - { package # don't want this in PAUSE - TestRHBug; use overload bool => sub { 0 } } - - sub _has_bug_34925 { - my %thing; - my $r1 = \%thing; - my $r2 = \%thing; - bless $r1 => 'TestRHBug'; - return !!$r2; - } - - sub _possibly_has_bad_overload_performance { - return $] < 5.008009 && ! _has_bug_34925(); - } +1; - unless ($ENV{DBIC_NO_WARN_BAD_PERL}) { - if (_possibly_has_bad_overload_performance()) { - print STDERR "\n\nWARNING: " . __PACKAGE__ . ": This version of Perl is likely to exhibit\n" . - "extremely slow performance for certain critical operations.\n" . - "Please consider recompiling Perl. For more information, see\n" . - "https://bugzilla.redhat.com/show_bug.cgi?id=196836 and/or\n" . - "http://lists.scsys.co.uk/pipermail/dbix-class/2007-October/005119.html.\n" . - "You can suppress this message by setting DBIC_NO_WARN_BAD_PERL=1 in your\n" . - "environment.\n\n"; - } - } -} +__END__ =head1 NAME @@ -37,35 +14,33 @@ DBIx::Class::StartupCheck - Run environment checks on startup =head1 SYNOPSIS use DBIx::Class::StartupCheck; - -=head1 DESCRIPTION - -Currently this module checks for, and if necessary issues a warning for, a -particular bug found on RedHat systems from perl-5.8.8-10 and up. Other checks -may be added from time to time. - -Any checks herein can be disabled by setting an appropriate environment -variable. If your system suffers from a particular bug, you will get a warning -message on startup sent to STDERR, explaining what to do about it and how to -suppress the message. If you don't see any messages, you have nothing to worry -about. - -=head1 CONTRIBUTORS - -Nigel Metheringham -Brandon Black +=head1 DESCRIPTION -Matt S. Trout +This module used to check for, and if necessary issue a warning for, a +particular bug found on Red Hat and Fedora systems using their system +perl build. As of September 2008 there are fixed versions of perl for +all current Red Hat and Fedora distributions, but the old check still +triggers, incorrectly flagging those versions of perl to be buggy. A +more comprehensive check has been moved into the test suite in +C and further information about the bug has been +put in L. -=head1 AUTHOR +Other checks may be added from time to time. -Jon Schutz +Any checks herein can be disabled by setting an appropriate environment +variable. If your system suffers from a particular bug, you will get a +warning message on startup sent to STDERR, explaining what to do about +it and how to suppress the message. If you don't see any messages, you +have nothing to worry about. -=head1 LICENSE +=head1 FURTHER QUESTIONS? -You may distribute this code under the same terms as Perl itself. +Check the list of L. -=cut +=head1 COPYRIGHT AND LICENSE -1; +This module is free software L +by the L. You can +redistribute it and/or modify it under the same terms as the +L.