X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSerialize%2FStorable.pm;h=23f61cb98d4a1b38849549ce4370197fc339f16a;hb=a5280453bd7fc86157fb4a84a451bddc2c408bf7;hp=7ccd2b0f52edb3928f3bdf5dc0da21dde115d441;hpb=9b83fccd091065fcebbb6fb6fb7bf2c2da38ffe2;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Serialize/Storable.pm b/lib/DBIx/Class/Serialize/Storable.pm index 7ccd2b0..23f61cb 100644 --- a/lib/DBIx/Class/Serialize/Storable.pm +++ b/lib/DBIx/Class/Serialize/Storable.pm @@ -1,20 +1,29 @@ package DBIx::Class::Serialize::Storable; use strict; use warnings; -use Storable; + +use Storable(); +use DBIx::Class::Carp; + +carp 'The Serialize::Storable component is now *DEPRECATED*. It has not ' + .'been providing any useful functionality for quite a while, and in fact ' + .'destroys prefetched results in its current implementation. Do not use!'; + sub STORABLE_freeze { - my ($self,$cloning) = @_; + my ($self, $cloning) = @_; my $to_serialize = { %$self }; - delete $to_serialize->{result_source}; - return (Storable::freeze($to_serialize)); + + # Dynamic values, easy to recalculate + delete $to_serialize->{$_} for qw/related_resultsets _inflated_column/; + + return (Storable::nfreeze($to_serialize)); } sub STORABLE_thaw { - my ($self,$cloning,$serialized) = @_; + my ($self, $cloning, $serialized) = @_; + %$self = %{ Storable::thaw($serialized) }; - $self->result_source($self->result_source_instance) - if $self->can('result_source_instance'); } 1; @@ -23,7 +32,13 @@ __END__ =head1 NAME - DBIx::Class::Serialize::Storable - hooks for Storable freeze/thaw + DBIx::Class::Serialize::Storable - hooks for Storable nfreeze/thaw + +=head1 DEPRECATION NOTE + +This component is now B. It has not been providing any useful +functionality for quite a while, and in fact destroys prefetched results +in its current implementation. Do not use! =head1 SYNOPSIS