X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSchema.pm;h=348edeb0bb1471f2f61bc832854ff9a188ae0360;hb=f5ef5fa1068d249fb353411f01a60bab5d41911c;hp=77a7fe7e511d1eba2d9e71b20309f1949c7879b1;hpb=c3e9f7189094e94137356251c4f0b1f1cbfeb04a;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Schema.pm b/lib/DBIx/Class/Schema.pm index 77a7fe7..348edeb 100644 --- a/lib/DBIx/Class/Schema.pm +++ b/lib/DBIx/Class/Schema.pm @@ -244,7 +244,9 @@ sub load_namespaces { use warnings 'redefine'; # ensure classes are loaded and attached in inheritance order - $class->ensure_class_loaded($_) foreach(values %results); + for my $res (values %results) { + $class->ensure_class_loaded($res); + } my %inh_idx; my @subclass_last = sort { @@ -898,6 +900,7 @@ sub compose_namespace { my $schema = $self->clone; { no warnings qw/redefine/; + no strict qw/refs/; # local *Class::C3::reinitialize = sub { }; foreach my $moniker ($schema->sources) { my $source = $schema->source($moniker); @@ -906,8 +909,14 @@ sub compose_namespace { $target_class => $source->result_class, ($base ? $base : ()) ); $source->result_class($target_class); - $target_class->result_source_instance($source) - if $target_class->can('result_source_instance'); + if ($target_class->can('result_source_instance')) { + + # since the newly created classes are registered only with + # the instance of $schema, it should be safe to weaken + # the ref (it will GC when $schema is destroyed) + $target_class->result_source_instance($source); + weaken ${"${target_class}::__cag_result_source_instance"}; + } $schema->register_source($moniker, $source); } }