X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSchema%2FLoader%2FDBI%2Fmysql.pm;h=a5384b1cbf8f8be6dab063ae2112016e2ef8b041;hb=8a9cc3bb69bee00efb91480ed7106a9bdf473414;hp=705bc02c32ce9a3802c01890ef6c753923c85c33;hpb=7c2059da9f662c629f53eca5cef10f66380f77b5;p=dbsrgits%2FDBIx-Class-Schema-Loader.git diff --git a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm index 705bc02..a5384b1 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm @@ -9,10 +9,11 @@ use List::Util 'first'; use List::MoreUtils 'any'; use Try::Tiny; use Scalar::Util 'blessed'; +use DBIx::Class::Schema::Loader::Utils qw/sigwarn_silencer/; use namespace::clean; use DBIx::Class::Schema::Loader::Table (); -our $VERSION = '0.07022'; +our $VERSION = '0.07037'; =head1 NAME @@ -65,7 +66,7 @@ sub _system_schemas { return ($self->next::method(@_), 'mysql'); } -sub _tables_list { +sub _tables_list { my ($self, $opts) = @_; return $self->next::method($opts, undef, undef); @@ -83,12 +84,12 @@ sub _table_fk_info { my $nqt = qr/[^"`]/; my (@reldata) = ($table_def =~ - /CONSTRAINT ${qt}${nqt}+${qt} FOREIGN KEY \($qt(.*)$qt\) REFERENCES (?:$qt($nqt+)$qt\.)?$qt($nqt+)$qt \($qt(.+)$qt\)/ig + /CONSTRAINT ${qt}${nqt}+${qt} FOREIGN KEY \($qt(.*)$qt\) REFERENCES (?:$qt($nqt+)$qt\.)?$qt($nqt+)$qt \($qt(.+)$qt\)\s*(.*)/ig ); my @rels; while (scalar @reldata > 0) { - my ($cols, $f_schema, $f_table, $f_cols) = splice @reldata, 0, 4; + my ($cols, $f_schema, $f_table, $f_cols, $rest) = splice @reldata, 0, 5; my @cols = map { s/$qt//g; $self->_lc($_) } split(/$qt?\s*$qt?,$qt?\s*$qt?/, $cols); @@ -129,10 +130,37 @@ sub _table_fk_info { ); } + my %attrs; + + if ($rest) { + my @on_clauses = $rest =~ /(ON DELETE|ON UPDATE) (RESTRICT|CASCADE|SET NULL|NO ACTION) ?/ig; + + while (my ($clause, $value) = splice @on_clauses, 0, 2) { + $clause = lc $clause; + $clause =~ s/ /_/; + + $value = uc $value; + + $attrs{$clause} = $value; + } + } + +# The default behavior is RESTRICT. Specifying RESTRICT explicitly just removes +# that ON clause from the SHOW CREATE TABLE output. For this reason, even +# though the default for these clauses everywhere else in Schema::Loader is +# CASCADE, we change the default here to RESTRICT in order to reproduce the +# schema faithfully. + $attrs{on_delete} ||= 'RESTRICT'; + $attrs{on_update} ||= 'RESTRICT'; + +# MySQL does not have a DEFERRABLE attribute, but there is a way to defer FKs. + $attrs{is_deferrable} = 1; + push(@rels, { local_columns => \@cols, remote_columns => \@f_cols, remote_table => $remote_table, + attrs => \%attrs, }); } @@ -242,7 +270,7 @@ EOF delete $info->{extra}{list}; - while ($column_type =~ /'((?:[^']* (?:''|\\')* [^']*)* [^\\'])',?/xg) { + while ($column_type =~ /'((?:[^']* (?:''|\\')* [^']*)* [^\\']?)',?/xg) { my $el = $1; $el =~ s/''/'/g; push @{ $info->{extra}{list} }, $el; @@ -294,8 +322,9 @@ sub _extra_column_info { sub _dbh_column_info { my $self = shift; - local $SIG{__WARN__} = sub { warn @_ - unless $_[0] =~ /^column_info: unrecognized column type/ }; + local $SIG{__WARN__} = sigwarn_silencer( + qr/^column_info: unrecognized column type/ + ); $self->next::method(@_); }