X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSchema%2FLoader%2FDBI%2Fmysql.pm;h=705bc02c32ce9a3802c01890ef6c753923c85c33;hb=7c2059da9f662c629f53eca5cef10f66380f77b5;hp=d4caf72d42e022b78e92202d50df7857563da50b;hpb=eeeab5406ba5610482bfa3220a918363c35ed3e1;p=dbsrgits%2FDBIx-Class-Schema-Loader.git diff --git a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm index d4caf72..705bc02 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm @@ -8,10 +8,11 @@ use Carp::Clan qw/^DBIx::Class/; use List::Util 'first'; use List::MoreUtils 'any'; use Try::Tiny; +use Scalar::Util 'blessed'; use namespace::clean; use DBIx::Class::Schema::Loader::Table (); -our $VERSION = '0.07012'; +our $VERSION = '0.07022'; =head1 NAME @@ -201,10 +202,10 @@ sub _columns_info_for { delete $info->{size} if $data_type !~ /^(?: (?:var)?(?:char(?:acter)?|binary) | bit | year)\z/ix; # information_schema is available in 5.0+ - my ($precision, $scale, $column_type, $default) = eval { $self->dbh->selectrow_array(<<'EOF', {}, $table, $col) }; + my ($precision, $scale, $column_type, $default) = eval { $self->dbh->selectrow_array(<<'EOF', {}, $table->name, lc($col)) }; SELECT numeric_precision, numeric_scale, column_type, column_default FROM information_schema.columns -WHERE table_name = ? AND column_name = ? +WHERE table_name = ? AND lower(column_name) = ? EOF my $has_information_schema = not $@; @@ -279,7 +280,8 @@ sub _extra_column_info { if ($dbi_info->{mysql_values}) { $extra_info{extra}{list} = $dbi_info->{mysql_values}; } - if ( lc($dbi_info->{COLUMN_DEF}) eq 'current_timestamp' + if ((not blessed $dbi_info) # isa $sth + && lc($dbi_info->{COLUMN_DEF}) eq 'current_timestamp' && lc($dbi_info->{mysql_type_name}) eq 'timestamp') { my $current_timestamp = 'current_timestamp'; @@ -307,7 +309,7 @@ sub _table_comment { FROM information_schema.tables WHERE table_schema = schema() AND table_name = ? - }, undef, $table); + }, undef, $table->name); }; # InnoDB likes to auto-append crap. if (not $comment) { @@ -332,8 +334,8 @@ sub _column_comment { FROM information_schema.columns WHERE table_schema = schema() AND table_name = ? - AND column_name = ? - }, undef, $table, $column_name); + AND lower(column_name) = ? + }, undef, $table->name, lc($column_name)); }; } return $comment;