X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FSchema%2FLoader%2FDBI%2Fmysql.pm;h=4d1bee88214babe580d4884b589870443e5811c8;hb=18eb280f9b71785a12c105299f813358faa47143;hp=8131ee26521f3e9a4344f7af5dafbc01a63bf64a;hpb=c4a69b87bd3d3fdda08f05d363311a6e9d3fc0f7;p=dbsrgits%2FDBIx-Class-Schema-Loader.git diff --git a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm index 8131ee2..4d1bee8 100644 --- a/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm +++ b/lib/DBIx/Class/Schema/Loader/DBI/mysql.pm @@ -9,8 +9,9 @@ use List::Util 'first'; use List::MoreUtils 'any'; use Try::Tiny; use namespace::clean; +use DBIx::Class::Schema::Loader::Table (); -our $VERSION = '0.07010'; +our $VERSION = '0.07018'; =head1 NAME @@ -36,7 +37,7 @@ sub _setup { if ($self->db_schema && $self->db_schema->[0] eq '%') { my @schemas = try { - map $_->[0], @{ $self->dbh->selectall_arrayref('SHOW DATABASES') }; + $self->_show_databases; } catch { croak "no SHOW DATABASES privileges: $_"; @@ -44,13 +45,19 @@ sub _setup { @schemas = grep { my $schema = $_; - not any { $schema eq $_ } $self->_system_schemas + not any { lc($schema) eq lc($_) } $self->_system_schemas } @schemas; $self->db_schema(\@schemas); } } +sub _show_databases { + my $self = shift; + + return map $_->[0], @{ $self->dbh->selectall_arrayref('SHOW DATABASES') }; +} + sub _system_schemas { my $self = shift; @@ -88,10 +95,38 @@ sub _table_fk_info { my @f_cols = map { s/$qt//g; $self->_lc($_) } split(/$qt?\s*$qt?,$qt?\s*$qt?/, $f_cols); - my $remote_table = first { - lc($_->name) eq lc($f_table) - && ((not $f_schema) || lc($_->schema) eq lc($f_schema)) - } $self->_tables_list; + # Match case of remote schema to that in SHOW DATABASES, if it's there + # and we have permissions to run SHOW DATABASES. + if ($f_schema) { + my $matched = first { + lc($_) eq lc($f_schema) + } try { $self->_show_databases }; + + $f_schema = $matched if $matched; + } + + my $remote_table = do { + # Get ->tables_list to return tables from the remote schema, in case it is not in the db_schema list. + local $self->{db_schema} = [ $f_schema ] if $f_schema; + + first { + lc($_->name) eq lc($f_table) + && ((not $f_schema) || lc($_->schema) eq lc($f_schema)) + } $self->_tables_list; + }; + + # The table may not be in any database, or it may not have been found by the previous code block for whatever reason. + if (not $remote_table) { + my $remote_schema = $f_schema || $self->db_schema && @{ $self->db_schema } == 1 && $self->db_schema->[0]; + + $remote_table = DBIx::Class::Schema::Loader::Table->new( + loader => $self, + name => $f_table, + ($remote_schema ? ( + schema => $remote_schema, + ) : ()), + ); + } push(@rels, { local_columns => \@cols, @@ -108,7 +143,7 @@ sub _table_fk_info { sub _mysql_table_get_keys { my ($self, $table) = @_; - if(!exists($self->{_cache}->{_mysql_keys}->{$table})) { + if(!exists($self->{_cache}->{_mysql_keys}->{$table->sql_name})) { my %keydata; my $sth = $self->dbh->prepare('SHOW INDEX FROM '.$table->sql_name); $sth->execute; @@ -123,10 +158,10 @@ sub _mysql_table_get_keys { @{$keydata{$keyname}}; $keydata{$keyname} = \@ordered_cols; } - $self->{_cache}->{_mysql_keys}->{$table} = \%keydata; + $self->{_cache}->{_mysql_keys}->{$table->sql_name} = \%keydata; } - return $self->{_cache}->{_mysql_keys}->{$table}; + return $self->{_cache}->{_mysql_keys}->{$table->sql_name}; } sub _table_pk_info {