X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FResultSet.pm;h=c0c758fb00de07adfc6c8ead3feb89943e3916f0;hb=c07482800ba8221bedd89f854dc56da865f7692f;hp=68b7d9b82e443cd3665f1ed0e6479b8823acfcc5;hpb=d0e5848787d1fb2d4914001586c456b456593e20;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/ResultSet.pm b/lib/DBIx/Class/ResultSet.pm index 68b7d9b..c0c758f 100644 --- a/lib/DBIx/Class/ResultSet.pm +++ b/lib/DBIx/Class/ResultSet.pm @@ -2851,14 +2851,10 @@ sub _resolved_attrs { my %already_grouped = map { $_ => 1 } (@{$attrs->{group_by}}); my $storage = $self->result_source->schema->storage; - my $sql_maker = $storage->sql_maker; - local $sql_maker->{quote_char}; #disable quoting my $rs_column_list = $storage->_resolve_column_info ($attrs->{from}); - my @chunks = $sql_maker->_order_by_chunks ($attrs->{order_by}); - for my $chunk (map { ref $_ ? @$_ : $_ } (@chunks) ) { - $chunk =~ s/\s+ (?: ASC|DESC ) \s* $//ix; + for my $chunk ($storage->_parse_order_by($attrs->{order_by})) { if ($rs_column_list->{$chunk} && not $already_grouped{$chunk}++) { push @{$attrs->{group_by}}, $chunk; }