X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FManyToMany.pm;h=e294a8cc6ad964bdd3d5a8942e45bf3416d53aca;hb=ae9a0fa0deca24bb6e472800f7e9e82374120b7b;hp=a88e1b0051ad1c9b121e0a1e712cb7caab0ebc53;hpb=3a868fb29b0bb50a7216f770cc9a71d358d67431;p=dbsrgits%2FDBIx-Class.git

diff --git a/lib/DBIx/Class/Relationship/ManyToMany.pm b/lib/DBIx/Class/Relationship/ManyToMany.pm
index a88e1b0..e294a8c 100644
--- a/lib/DBIx/Class/Relationship/ManyToMany.pm
+++ b/lib/DBIx/Class/Relationship/ManyToMany.pm
@@ -10,33 +10,72 @@ sub many_to_many {
     no strict 'refs';
     no warnings 'redefine';
 
+    my $add_meth = "add_to_${meth}";
+    my $remove_meth = "remove_from_${meth}";
+    my $set_meth = "set_${meth}";
+
+    $rel_attrs->{alias} ||= $f_rel;
+
     *{"${class}::${meth}"} = sub {
       my $self = shift;
       my $attrs = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
+      my @args = ($f_rel, @_ > 0 ? @_ : undef, { %{$rel_attrs||{}}, %$attrs });
       $self->search_related($rel)->search_related(
         $f_rel, @_ > 0 ? @_ : undef, { %{$rel_attrs||{}}, %$attrs }
       );
     };
 
-    *{"${class}::add_to_${meth}"} = sub {
-      my( $self, $obj ) = @_;
-      my $vals = @_ > 2 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
-      return $self->search_related($rel)->create({
-        map { $_=>$self->get_column($_) } $self->primary_columns(),
-        map { $_=>$obj->get_column($_) } $obj->primary_columns(),
-        %$vals,
-      });
+    *{"${class}::${add_meth}"} = sub {
+      my $self = shift;
+      @_ > 0 or $self->throw_exception(
+        "${add_meth} needs an object or hashref"
+      );
+      my $source = $self->result_source;
+      my $schema = $source->schema;
+      my $rel_source_name = $source->relationship_info($rel)->{source};
+      my $rel_source = $schema->resultset($rel_source_name)->result_source;
+      my $f_rel_source_name = $rel_source->relationship_info($f_rel)->{source};
+      my $f_rel_rs = $schema->resultset($f_rel_source_name)->search({}, $rel_attrs||{});
+
+      my $obj;
+      if (ref $_[0]) {
+        if (ref $_[0] eq 'HASH') {
+          $obj = $f_rel_rs->create($_[0]);
+        } else {
+          $obj = $_[0];
+        }
+      } else {
+        $obj = $f_rel_rs->create({@_});
+      }
+
+      my $link_vals = @_ > 1 && ref $_[$#_] eq 'HASH' ? pop(@_) : {};
+      my $link = $self->search_related($rel)->new_result({});
+      $link->set_from_related($f_rel, $obj);
+      $link->set_columns($link_vals);
+      $link->insert();
+    };
+
+    *{"${class}::${set_meth}"} = sub {
+      my $self = shift;
+      @_ > 0 or $self->throw_exception(
+        "{$set_meth} needs a list of objects or hashrefs"
+      );
+      my @to_set = (ref($_[0]) eq 'ARRAY' ? @{ $_[0] } : @_);
+      $self->search_related($rel, {})->delete;
+      $self->$add_meth($_) for (@to_set);
     };
 
-    *{"${class}::remove_from_${meth}"} = sub {
-      my( $self, $obj ) = @_;
-      return $self->search_related(
-        $rel,
-        {
-            map { $_=>$self->get_column($_) } $self->primary_columns(),
-            map { $_=>$obj->get_column($_) } $obj->primary_columns(),
-        },
-      )->delete();
+    *{"${class}::${remove_meth}"} = sub {
+      my $self = shift;
+      @_ > 0 && ref $_[0] ne 'HASH'
+        or $self->throw_exception("${remove_meth} needs an object");
+      my $obj = shift;
+      my $rel_source = $self->search_related($rel)->result_source;
+      my $cond = $rel_source->relationship_info($f_rel)->{cond};
+      my $link_cond = $rel_source->resolve_condition(
+        $cond, $obj, $f_rel
+      );
+      $self->search_related($rel, $link_cond)->delete;
     };
 
   }