X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FHasOne.pm;h=665d13190b02c91a47e4d2b8d470301865e3891a;hb=95b76469a363174145245b3490ebba83d1b639ce;hp=fbc90f1daa5b6207a01f281f7b3e80b3a6556559;hpb=6909ab3ccc795859d538010083cdafe77e225980;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Relationship/HasOne.pm b/lib/DBIx/Class/Relationship/HasOne.pm index fbc90f1..665d131 100644 --- a/lib/DBIx/Class/Relationship/HasOne.pm +++ b/lib/DBIx/Class/Relationship/HasOne.pm @@ -5,6 +5,7 @@ use strict; use warnings; use DBIx::Class::Carp; use Try::Tiny; +use DBIx::Class::_Util 'dbic_internal_try'; use namespace::clean; our %_pod_inherit_config = @@ -34,7 +35,7 @@ sub _has_one { # at this point we need to load the foreigner, expensive or not $class->ensure_class_loaded($f_class); - $f_rsrc = try { + $f_rsrc = dbic_internal_try { my $r = $f_class->result_source_instance; die "There got to be some columns by now... (exception caught and rewritten by catch below)" unless $r->columns; @@ -60,7 +61,7 @@ sub _has_one { # FIXME - this check needs to be moved to schema-composition time... # # only perform checks if the far side was not preloaded above *AND* # # appears to have been loaded by something else (has a rsrc_instance) -# if (! $f_rsrc and $f_rsrc = try { $f_class->result_source_instance }) { +# if (! $f_rsrc and $f_rsrc = dbic_internal_try { $f_class->result_source_instance }) { # $class->throw_exception( # "No such column '$f_key' on foreign class ${f_class} ($guess)" # ) if !$f_rsrc->has_column($f_key); @@ -77,6 +78,7 @@ sub _has_one { { accessor => 'single', cascade_update => $default_cascade, cascade_delete => $default_cascade, + is_depends_on => 0, ($join_type ? ('join_type' => $join_type) : ()), %{$attrs || {}} }); 1; @@ -96,8 +98,8 @@ sub _validate_has_one_condition { my $key = $1; $class->throw_exception("Defining rel on ${class} that includes '$key' but no such column defined here yet") - unless $class->has_column($key); - my $column_info = $class->column_info($key); + unless $class->result_source_instance->has_column($key); + my $column_info = $class->result_source_instance->column_info($key); if ( $column_info->{is_nullable} ) { carp(qq'"might_have/has_one" must not be on columns with is_nullable set to true ($class/$key). This might indicate an incorrect use of those relationship helpers instead of belongs_to.'); }