X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FHasMany.pm;h=6ef09fb74ce0661757e8509e8be70f90d2d9e178;hb=e570488a;hp=2efebb7dd76e1bfea0eca94eb711535ef3da8665;hpb=07037f89d4d9bf97c59a2c083de74f669521da47;p=dbsrgits%2FDBIx-Class.git

diff --git a/lib/DBIx/Class/Relationship/HasMany.pm b/lib/DBIx/Class/Relationship/HasMany.pm
index 2efebb7..6ef09fb 100644
--- a/lib/DBIx/Class/Relationship/HasMany.pm
+++ b/lib/DBIx/Class/Relationship/HasMany.pm
@@ -1,36 +1,54 @@
-package DBIx::Class::Relationship::HasMany;
+package # hide from PAUSE
+    DBIx::Class::Relationship::HasMany;
 
 use strict;
 use warnings;
+use DBIx::Class::_Util 'dbic_internal_try';
+use namespace::clean;
+
+our %_pod_inherit_config =
+  (
+   class_map => { 'DBIx::Class::Relationship::HasMany' => 'DBIx::Class::Relationship' }
+  );
 
 sub has_many {
   my ($class, $rel, $f_class, $cond, $attrs) = @_;
-    
-  eval "require $f_class";
 
-  if (!ref $cond) {
-    my $f_key;
+  unless (ref $cond) {
+
+    my $pri = $class->result_source->_single_pri_col_or_die;
+
+    my ($f_key,$guess);
     if (defined $cond && length $cond) {
       $f_key = $cond;
-      $class->throw( "No such column ${f_key} on foreign class ${f_class}" )
-        unless ($@ || $f_class->_columns->{$f_key});
+      $guess = "caller specified foreign key '$f_key'";
     } else {
-      $class =~ /([^\:]+)$/;
-      $f_key = lc $1 if $f_class->_columns->{lc $1};
-      $class->throw( "Unable to resolve foreign key for has_many from ${class} to ${f_class}" )
-        unless $f_key;
+      $class =~ /([^\:]+)$/;  # match is safe - $class can't be ''
+      $f_key = lc $1; # go ahead and guess; best we can do
+      $guess = "using our class name '$class' as foreign key source";
     }
-    my ($pri, $too_many) = keys %{ $class->_primaries };
-    $class->throw( "has_many can only infer join for a single primary key; ${class} has more" )
-      if $too_many;
-    $cond = { "foreign.${f_key}" => "self.${pri}" },
+
+# FIXME - this check needs to be moved to schema-composition time...
+#    # only perform checks if the far side appears already loaded
+#    if (my $f_rsrc = dbic_internal_try { $f_class->result_source } ) {
+#      $class->throw_exception(
+#        "No such column '$f_key' on foreign class ${f_class} ($guess)"
+#      ) if !$f_rsrc->has_column($f_key);
+#    }
+
+    $cond = { "foreign.${f_key}" => "self.${pri}" };
   }
 
-  $class->add_relationship($rel, $f_class, $cond,
-                            { accessor => 'multi',
-                              join_type => 'LEFT',
-                              cascade_delete => 1,
-                              %{$attrs||{}} } );
+  my $default_cascade = ref $cond eq 'CODE' ? 0 : 1;
+
+  $class->add_relationship($rel, $f_class, $cond, {
+    accessor => 'multi',
+    join_type => 'LEFT',
+    cascade_delete => $default_cascade,
+    cascade_copy => $default_cascade,
+    is_depends_on => 0,
+    %{$attrs||{}}
+  });
 }
 
 1;