X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FHasMany.pm;h=21e637d4ebec680f9a0c8e23922dbdfab32a2c4c;hb=3f52831919a64ea6fb3269e41c547bc42e8db2fd;hp=936238a968f0fa9e91b7e9aaebe48d392d9e0274;hpb=044e70c766df798a321d35329d06e69ba52b4bd0;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/lib/DBIx/Class/Relationship/HasMany.pm b/lib/DBIx/Class/Relationship/HasMany.pm index 936238a..21e637d 100644 --- a/lib/DBIx/Class/Relationship/HasMany.pm +++ b/lib/DBIx/Class/Relationship/HasMany.pm @@ -3,8 +3,10 @@ package # hide from PAUSE use strict; use warnings; +use Try::Tiny; +use namespace::clean; -our %_pod_inherit_config = +our %_pod_inherit_config = ( class_map => { 'DBIx::Class::Relationship::HasMany' => 'DBIx::Class::Relationship' } ); @@ -14,7 +16,10 @@ sub has_many { unless (ref $cond) { $class->ensure_class_loaded($f_class); - my ($pri, $too_many) = $class->primary_columns; + my ($pri, $too_many) = try { $class->_pri_cols } + catch { + $class->throw_exception("Can't infer join condition for ${rel} on ${class}: $_"); + }; $class->throw_exception( "has_many can only infer join for a single primary key; ". @@ -36,11 +41,11 @@ sub has_many { $guess = "using our class name '$class' as foreign key"; } - my $f_class_loaded = eval { $f_class->columns }; + my $f_class_loaded = try { $f_class->columns }; $class->throw_exception( "No such column ${f_key} on foreign class ${f_class} ($guess)" ) if $f_class_loaded && !$f_class->has_column($f_key); - + $cond = { "foreign.${f_key}" => "self.${pri}" }; }