X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FBelongsTo.pm;h=e2adbd88752b6bd3bc164c22fc39aa1027eff034;hb=3420931befe854a81e4c19a694ec491806013165;hp=050c1e4af0f409dfef93d2e6e08c362e5b7cca7b;hpb=ed7ab0f4ce1a9118ea6285ee562ef003085a6b64;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Relationship/BelongsTo.pm b/lib/DBIx/Class/Relationship/BelongsTo.pm index 050c1e4..e2adbd8 100644 --- a/lib/DBIx/Class/Relationship/BelongsTo.pm +++ b/lib/DBIx/Class/Relationship/BelongsTo.pm @@ -7,17 +7,20 @@ package # hide from PAUSE use strict; use warnings; use Try::Tiny; +use namespace::clean; -our %_pod_inherit_config = +our %_pod_inherit_config = ( class_map => { 'DBIx::Class::Relationship::BelongsTo' => 'DBIx::Class::Relationship' } ); -sub belongs_to { +sub belongs_to { goto \&refers_to } + +sub refers_to { my ($class, $rel, $f_class, $cond, $attrs) = @_; # assume a foreign key contraint unless defined otherwise - $attrs->{is_foreign_key_constraint} = 1 + $attrs->{is_foreign_key_constraint} = 1 if not exists $attrs->{is_foreign_key_constraint}; $attrs->{undef_on_null_fk} = 1 if not exists $attrs->{undef_on_null_fk}; @@ -27,26 +30,23 @@ sub belongs_to { $class->ensure_class_loaded($f_class); my %f_primaries = map { $_ => 1 } try { $f_class->_pri_cols } catch { - $class->throw_exception( "Can't infer join condition for ${rel} on ${class}: $_"); + $class->throw_exception( "Can't infer join condition for '$rel' on ${class}: $_"); }; my ($pri, $too_many) = keys %f_primaries; $class->throw_exception( - "Can't infer join condition for ${rel} on ${class}; ". - "${f_class} has multiple primary keys" + "Can't infer join condition for '$rel' on ${class}: " + . "${f_class} has multiple primary keys" ) if $too_many; my $fk = defined $cond ? $cond : $rel; $class->throw_exception( - "Can't infer join condition for ${rel} on ${class}; ". - "$fk is not a column of $class" + "Can't infer join condition for '$rel' on ${class}: " + . "'$fk' is not a column of $class" ) unless $class->has_column($fk); - my $acc_type = $class->has_column($rel) ? 'filter' : 'single'; - $class->add_relationship($rel, $f_class, - { "foreign.${pri}" => "self.${fk}" }, - { accessor => $acc_type, %{$attrs || {}} } - ); + $cond = { "foreign.${pri}" => "self.${fk}" }; + } # explicit join condition elsif (ref $cond) { @@ -61,22 +61,37 @@ sub belongs_to { } $cond = $cond_rel; } - my $acc_type = ((ref $cond eq 'HASH') - && keys %$cond == 1 - && $class->has_column($rel)) - ? 'filter' - : 'single'; - $class->add_relationship($rel, $f_class, - $cond, - { accessor => $acc_type, %{$attrs || {}} } - ); } + # dunno else { $class->throw_exception( 'third argument for belongs_to must be undef, a column name, '. 'or a join condition' ); } + + my $acc_type = ( + ref $cond eq 'HASH' + and + keys %$cond == 1 + and + $class->has_column($rel) + ) ? 'filter' : 'single'; + + my $fk_columns = ($acc_type eq 'single' and ref $cond eq 'HASH') + ? { map { $_ =~ /^self\.(.+)/ ? ( $1 => 1 ) : () } (values %$cond ) } + : undef + ; + + $class->add_relationship($rel, $f_class, + $cond, + { + accessor => $acc_type, + $fk_columns ? ( fk_columns => $fk_columns ) : (), + %{$attrs || {}} + } + ); + return 1; }