X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FRelationship%2FAccessor.pm;h=b94f2381a6ca02b5978f741acb8c792f7ab4b596;hb=412db1f428e95eeeac2a63f12b3c2d1ce1b3223a;hp=2350b81b44d31a71a692e61e4b3aedab9ec704c0;hpb=4a07648ace2ace5b878c63aec52b7a30c1432b4d;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/lib/DBIx/Class/Relationship/Accessor.pm b/lib/DBIx/Class/Relationship/Accessor.pm index 2350b81..b94f238 100644 --- a/lib/DBIx/Class/Relationship/Accessor.pm +++ b/lib/DBIx/Class/Relationship/Accessor.pm @@ -3,17 +3,15 @@ package DBIx::Class::Relationship::Accessor; use strict; use warnings; -sub add_relationship { - my ($class, $rel, @rest) = @_; - my $ret = $class->NEXT::ACTUAL::add_relationship($rel => @rest); - my $rel_obj = $class->_relationships->{$rel}; - if (my $acc_type = $rel_obj->{attrs}{accessor}) { - $class->_add_relationship_accessor($rel => $acc_type); +sub register_relationship { + my ($class, $rel, $info) = @_; + if (my $acc_type = $info->{attrs}{accessor}) { + $class->add_relationship_accessor($rel => $acc_type); } - return $ret; + $class->next::method($rel => $info); } -sub _add_relationship_accessor { +sub add_relationship_accessor { my ($class, $rel, $acc_type) = @_; my %meth; if ($acc_type eq 'single') { @@ -25,14 +23,15 @@ sub _add_relationship_accessor { } elsif (exists $self->{_relationship_data}{$rel}) { return $self->{_relationship_data}{$rel}; } else { - return $self->{_relationship_data}{$rel} - = $self->find_or_create_related($rel, {}, {}); + my $val = $self->find_related($rel, {}, {}); + return unless $val; + return $self->{_relationship_data}{$rel} = $val; } }; } elsif ($acc_type eq 'filter') { - $class->throw("No such column $rel to filter") - unless exists $class->_columns->{$rel}; - my $f_class = $class->_relationships->{$rel}{class}; + $class->throw_exception("No such column $rel to filter") + unless $class->has_column($rel); + my $f_class = $class->relationship_info($rel)->{class}; $class->inflate_column($rel, { inflate => sub { my ($val, $self) = @_; @@ -40,7 +39,7 @@ sub _add_relationship_accessor { }, deflate => sub { my ($val, $self) = @_; - $self->throw("$val isn't a $f_class") unless $val->isa($f_class); + $self->throw_exception("$val isn't a $f_class") unless $val->isa($f_class); return ($val->_ident_values)[0]; # WARNING: probably breaks for multi-pri sometimes. FIXME } @@ -50,7 +49,7 @@ sub _add_relationship_accessor { $meth{$rel} = sub { shift->search_related($rel, @_) }; $meth{"add_to_${rel}"} = sub { shift->create_related($rel, @_); }; } else { - $class->throw("No such relationship accessor type $acc_type"); + $class->throw_exception("No such relationship accessor type $acc_type"); } { no strict 'refs';