X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FPK.pm;h=f282924ca569d21cce25deee52059bf584c334d3;hb=27252a4a98791c2fcf13693cfbb9f8c44f5e585b;hp=e281dd48ab3c51bfd8f010e9747e3b5b69bf6baf;hpb=243a6b72cfb2a6f2ccfcd84b665f1880790e2ff9;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/PK.pm b/lib/DBIx/Class/PK.pm index e281dd4..f282924 100644 --- a/lib/DBIx/Class/PK.pm +++ b/lib/DBIx/Class/PK.pm @@ -25,7 +25,7 @@ sub _ident_values { return (map { $self->{_column_data}{$_} } $self->primary_columns); } -=head2 discard_changes +=head2 discard_changes ($attrs) Re-selects the row from the database, losing any changes that had been made. @@ -33,27 +33,30 @@ been made. This method can also be used to refresh from storage, retrieving any changes made since the row was last read from storage. +$attrs is expected to be a hashref of attributes suitable for passing as the +second argument to $resultset->search($cond, $attrs); + =cut sub discard_changes { - my ($self) = @_; + my ($self, $attrs) = @_; delete $self->{_dirty_columns}; return unless $self->in_storage; # Don't reload if we aren't real! - - my $reload = $self->result_source->schema->storage->reload_row($self); - unless ($reload) { # If we got deleted in the mean-time + if( my $current_storage = $self->get_from_storage($attrs)) { + + # Set $self to the current. + %$self = %$current_storage; + + # Avoid a possible infinite loop with + # sub DESTROY { $_[0]->discard_changes } + bless $current_storage, 'Do::Not::Exist'; + + return $self; + } else { $self->in_storage(0); - return $self; + return $self; } - - %$self = %$reload; - - # Avoid a possible infinite loop with - # sub DESTROY { $_[0]->discard_changes } - bless $reload, 'Do::Not::Exist'; - - return $self; } =head2 id