X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FComponentised.pm;h=db70c7b314da013198c9ab4eb7b4161c978b249d;hb=9c0df5f32b68e23c670c89ce6cdbff60b4bd0ed0;hp=737e24bf079959df042a79e80498728d40b63f87;hpb=6db94aca366e5734230b70b00cad3387ffac9e17;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Componentised.pm b/lib/DBIx/Class/Componentised.pm index 737e24b..db70c7b 100644 --- a/lib/DBIx/Class/Componentised.pm +++ b/lib/DBIx/Class/Componentised.pm @@ -1,43 +1,47 @@ -package DBIx::Class::Componentised; +package # hide from PAUSE + DBIx::Class::Componentised; -use Class::C3; +use strict; +use warnings; + +use base 'Class::C3::Componentised'; +use Carp::Clan qw/^DBIx::Class/; sub inject_base { my ($class, $target, @to_inject) = @_; { no strict 'refs'; - unshift(@{"${target}::ISA"}, grep { $target ne $_ && !$target->isa($_)} @to_inject); + foreach my $to (reverse @to_inject) { + my @comps = qw(DigestColumns ResultSetManager Ordered UTF8Columns); + # Add components here that need to be loaded before Core + foreach my $first_comp (@comps) { + if ($to eq 'DBIx::Class::Core' && + $target->isa("DBIx::Class::${first_comp}")) { + warn "Possible incorrect order of components in ". + "${target}::load_components($first_comp) call: Core loaded ". + "before $first_comp. See the documentation for ". + "DBIx::Class::$first_comp for more information"; + } + } + unshift( @{"${target}::ISA"}, $to ) + unless ($target eq $to || $target->isa($to)); + } } - # Yes, this is hack. But it *does* work. Please don't submit tickets about - # it on the basis of the comments in Class::C3, the author was on #dbix-class - # while I was implementing this. - - my $table = { Class::C3::_dump_MRO_table }; - eval "package $target; import Class::C3;" unless exists $table->{$target}; -} - -sub load_components { - my $class = shift; - my $base = $class->component_base_class; - my @comp = map { /^\+(.*)$/ ? $1 : "${base}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); - Class::C3::reinitialize(); -} - -sub load_own_components { - my $class = shift; - my @comp = map { "${class}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); + $class->next::method($target, @to_inject); } -sub _load_components { - my ($class, @comp) = @_; - foreach my $comp (@comp) { - eval "use $comp"; - die $@ if $@; +# Returns a true value if the specified class is installed and loaded +# successfully, throws an exception if the class is found but not loaded +# successfully, and false if the class is not installed +sub load_optional_class { + my ($class, $f_class) = @_; + if ($class->ensure_class_found($f_class)) { + $class->ensure_class_loaded($f_class); + return 1; + } else { + return 0; } - $class->inject_base($class => @comp); } 1;