X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FComponentised.pm;h=7b4cb1f2a15159fffcb53d9484767295e5eb5aff;hb=e8fcf76f98ebd3cc99638765220d0024380bdd02;hp=1bb6a689b476d3fa6f33a4ec51b713370a25559e;hpb=8a9d01098f6ede409c6c44e9ce2e37274343fbad;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Componentised.pm b/lib/DBIx/Class/Componentised.pm index 1bb6a68..7b4cb1f 100644 --- a/lib/DBIx/Class/Componentised.pm +++ b/lib/DBIx/Class/Componentised.pm @@ -4,8 +4,7 @@ package # hide from PAUSE use strict; use warnings; -use Class::C3; -use Class::Inspector; +use base 'Class::C3::Componentised'; use Carp::Clan qw/^DBIx::Class/; sub inject_base { @@ -18,7 +17,7 @@ sub inject_base { foreach my $first_comp (@comps) { if ($to eq 'DBIx::Class::Core' && $target->isa("DBIx::Class::${first_comp}")) { - warn "Possible incorrect order of components in ". + carp "Possible incorrect order of components in ". "${target}::load_components($first_comp) call: Core loaded ". "before $first_comp. See the documentation for ". "DBIx::Class::$first_comp for more information"; @@ -29,79 +28,7 @@ sub inject_base { } } - # Yes, this is hack. But it *does* work. Please don't submit tickets about - # it on the basis of the comments in Class::C3, the author was on #dbix-class - # while I was implementing this. - - eval "package $target; import Class::C3;" unless exists $Class::C3::MRO{$target}; -} - -sub load_components { - my $class = shift; - my $base = $class->component_base_class; - my @comp = map { /^\+(.*)$/ ? $1 : "${base}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); - Class::C3::reinitialize(); -} - -sub load_own_components { - my $class = shift; - my @comp = map { "${class}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); -} - -sub _load_components { - my ($class, @comp) = @_; - foreach my $comp (@comp) { - $class->ensure_class_loaded($comp); - } - $class->inject_base($class => @comp); -} - -# Given a class name, tests to see if it is already loaded or otherwise -# defined. If it is not yet loaded, the package is require'd, and an exception -# is thrown if the class is still not loaded. -# -# TODO: handle ->has_many('rel', 'Class'...) instead of -# ->has_many('rel', 'Some::Schema::Class'...) -# -# BUG: For some reason, packages with syntax errors are added to %INC on -# require -sub ensure_class_loaded { - my ($class, $f_class) = @_; - - croak "Invalid class name $f_class" - if ($f_class=~m/(?:\b:\b|\:{3,})/); - return if Class::Inspector->loaded($f_class); - eval "require $f_class"; # require needs a bareword or filename - if ($@) { - if ($class->can('throw_exception')) { - $class->throw_exception($@); - } else { - croak $@; - } - } -} - -# Returns true if the specified class is installed or already loaded, false -# otherwise -sub ensure_class_found { - my ($class, $f_class) = @_; - return Class::Inspector->loaded($f_class) || - Class::Inspector->installed($f_class); -} - -# Returns a true value if the specified class is installed and loaded -# successfully, throws an exception if the class is found but not loaded -# successfully, and false if the class is not installed -sub load_optional_class { - my ($class, $f_class) = @_; - if ($class->ensure_class_found($f_class)) { - $class->ensure_class_loaded($f_class); - return 1; - } else { - return 0; - } + $class->next::method($target, @to_inject); } 1;