X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FComponentised.pm;h=7b4cb1f2a15159fffcb53d9484767295e5eb5aff;hb=acf7eb85d09f8491b7a73af6dd02d7fcf261c3fc;hp=e23a0b4a948eebc4ce8db6bbe53a1fea9bda78d0;hpb=c037c03aa6089d35c8a62ce5e1ed8b19e765c8bc;p=dbsrgits%2FDBIx-Class-Historic.git diff --git a/lib/DBIx/Class/Componentised.pm b/lib/DBIx/Class/Componentised.pm index e23a0b4..7b4cb1f 100644 --- a/lib/DBIx/Class/Componentised.pm +++ b/lib/DBIx/Class/Componentised.pm @@ -4,58 +4,31 @@ package # hide from PAUSE use strict; use warnings; -use Class::C3; -use Class::Inspector; +use base 'Class::C3::Componentised'; +use Carp::Clan qw/^DBIx::Class/; sub inject_base { my ($class, $target, @to_inject) = @_; { no strict 'refs'; foreach my $to (reverse @to_inject) { - unshift( @{"${target}::ISA"}, $to ) - unless ($target eq $to || $target->isa($to)); + my @comps = qw(DigestColumns ResultSetManager Ordered UTF8Columns); + # Add components here that need to be loaded before Core + foreach my $first_comp (@comps) { + if ($to eq 'DBIx::Class::Core' && + $target->isa("DBIx::Class::${first_comp}")) { + carp "Possible incorrect order of components in ". + "${target}::load_components($first_comp) call: Core loaded ". + "before $first_comp. See the documentation for ". + "DBIx::Class::$first_comp for more information"; + } + } + unshift( @{"${target}::ISA"}, $to ) + unless ($target eq $to || $target->isa($to)); } } - # Yes, this is hack. But it *does* work. Please don't submit tickets about - # it on the basis of the comments in Class::C3, the author was on #dbix-class - # while I was implementing this. - - my $table = { Class::C3::_dump_MRO_table }; - eval "package $target; import Class::C3;" unless exists $table->{$target}; -} - -sub load_components { - my $class = shift; - my $base = $class->component_base_class; - my @comp = map { /^\+(.*)$/ ? $1 : "${base}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); - Class::C3::reinitialize(); -} - -sub load_own_components { - my $class = shift; - my @comp = map { "${class}::$_" } grep { $_ !~ /^#/ } @_; - $class->_load_components(@comp); -} - -sub _load_components { - my ($class, @comp) = @_; - foreach my $comp (@comp) { - $class->ensure_class_loaded($comp); - } - $class->inject_base($class => @comp); -} - -# TODO: handle ->has_many('rel', 'Class'...) instead of -# ->has_many('rel', 'Some::Schema::Class'...) -sub ensure_class_loaded { - my ($class, $f_class) = @_; - eval "require $f_class"; - my $err = $@; - Class::Inspector->loaded($f_class) - or die $err || "require $f_class was successful but the package". - "is not defined"; + $class->next::method($target, @to_inject); } 1;