X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FComponentised.pm;h=5a592388bfbace00d4bc7c9987b4c384f9cfbde4;hb=e398f77e59be21bfdb90087caa30a092c87df0d6;hp=7b6813ef8fef8015e08607e7bd72b93ec9e13d14;hpb=d38cd95cdbfbd66ff2eddd053e6cbb6f7ad4f102;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Componentised.pm b/lib/DBIx/Class/Componentised.pm index 7b6813e..5a59238 100644 --- a/lib/DBIx/Class/Componentised.pm +++ b/lib/DBIx/Class/Componentised.pm @@ -17,18 +17,24 @@ sub inject_base { no strict 'refs'; for my $comp (reverse @_) { - if ( - $comp->isa ('DBIx::Class::UTF8Columns') - and - my @broken = grep { $_ ne 'DBIx::Class::Row' and defined ${"${_}::"}{store_column} } (@present_components) - ) { + + if ($comp->isa ('DBIx::Class::UTF8Columns') ) { + require B; + my @broken; + + for (@present_components) { + my $cref = $_->can ('store_column') + or next; + push @broken, $_ if B::svref_2object($cref)->STASH->NAME ne 'DBIx::Class::Row'; + } + carp "Incorrect loading order of $comp by ${target} will affect other components overriding store_column (" . join (', ', @broken) - .'). Refer to the documentation of DBIx::Class::UTF8Columns for more info'; - } - else { - unshift @present_components, $comp; + .'). Refer to the documentation of DBIx::Class::UTF8Columns for more info' + if @broken; } + + unshift @present_components, $comp; } $class->next::method($target, @_);