X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FCDBICompat%2FLiveObjectIndex.pm;h=11238dc32cd66cbf7cb8b018c3c60bc607f9fd52;hb=10221b7913431aa88a47aafdd357b93de062c7c2;hp=29a995eddab8b4e7478958ff416d10911f8804d6;hpb=c1d2357300903fa0f4ec7d85c132f04547c4ccba;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/CDBICompat/LiveObjectIndex.pm b/lib/DBIx/Class/CDBICompat/LiveObjectIndex.pm index 29a995e..11238dc 100644 --- a/lib/DBIx/Class/CDBICompat/LiveObjectIndex.pm +++ b/lib/DBIx/Class/CDBICompat/LiveObjectIndex.pm @@ -1,4 +1,5 @@ -package DBIx::Class::CDBICompat::LiveObjectIndex; +package # hide from PAUSE + DBIx::Class::CDBICompat::LiveObjectIndex; use strict; use warnings; @@ -14,32 +15,18 @@ __PACKAGE__->mk_classdata('live_object_init_count' => { }); # Ripped from Class::DBI 0.999, all credit due to Tony Bowden for this code, # all blame due to me for whatever bugs I introduced porting it. -sub _live_object_key { - my ($me) = @_; - my $class = ref($me) || $me; - my @primary = keys %{$class->_primaries}; - - # no key unless all PK columns are defined - return "" unless @primary == grep defined $me->get_column($_), @primary; - - # create single unique key for this object - return join "\030", $class, map { $_ . "\032" . $me->get_column($_) } - sort @primary; -} - sub purge_dead_from_object_index { - my $live = $_[0]->live_object_index; + my $live = shift->live_object_index; delete @$live{ grep !defined $live->{$_}, keys %$live }; } sub remove_from_object_index { - my $self = shift; - my $obj_key = $self->_live_object_key; - delete $self->live_object_index->{$obj_key}; + my $self = shift; + delete $self->live_object_index->{$self->ID}; } sub clear_object_index { - my $live = $_[0]->live_object_index; + my $live = shift->live_object_index; delete @$live{ keys %$live }; } @@ -47,14 +34,14 @@ sub clear_object_index { sub insert { my ($self, @rest) = @_; - $self->NEXT::ACTUAL::insert(@rest); + $self->next::method(@rest); # Because the insert will die() if it can't insert into the db (or should) # we can be sure the object *was* inserted if we got this far. In which - # case, given primary keys are unique and _live_object_key only returns a + # case, given primary keys are unique and ID only returns a # value if the object has all its primary keys, we can be sure there # isn't a real one in the object index already because such a record # cannot have existed without the insert failing. - if (my $key = $self->_live_object_key) { + if (my $key = $self->ID) { my $live = $self->live_object_index; weaken($live->{$key} = $self); $self->purge_dead_from_object_index @@ -65,10 +52,10 @@ sub insert { return $self; } -sub _row_to_object { +sub inflate_result { my ($class, @rest) = @_; - my $new = $class->NEXT::ACTUAL::_row_to_object(@rest); - if (my $key = $new->_live_object_key) { + my $new = $class->next::method(@rest); + if (my $key = $new->ID) { #warn "Key $key"; my $live = $class->live_object_index; return $live->{$key} if $live->{$key}; @@ -80,16 +67,4 @@ sub _row_to_object { return $new; } -sub discard_changes { - my ($self) = @_; - if (my $key = $self->_live_object_key) { - $self->remove_from_object_index; - my $ret = $self->NEXT::ACTUAL::discard_changes; - $self->live_object_index->{$key} = $self if $self->in_database; - return $ret; - } else { - return $self->NEXT::ACTUAL::discard_changes; - } -} - 1;