X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FAdmin.pm;h=b0d76b8ae054e2cbc266814e24aa8dc4a5dfd7a9;hb=d6b39e463d43250ea171fa983b2364227172266f;hp=c7640dab6bfa2cdddbe36b8d8589587092ed7431;hpb=f33862043c4b1e9f5823bc407585b43582dbcd5a;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/Admin.pm b/lib/DBIx/Class/Admin.pm index c7640da..b0d76b8 100644 --- a/lib/DBIx/Class/Admin.pm +++ b/lib/DBIx/Class/Admin.pm @@ -2,9 +2,8 @@ package DBIx::Class::Admin; # check deps BEGIN { - use Carp::Clan qw/^DBIx::Class/; use DBIx::Class; - croak('The following modules are required for DBIx::Class::Admin ' . DBIx::Class::Optional::Dependencies->req_missing_for ('admin') ) + die('The following modules are required for DBIx::Class::Admin ' . DBIx::Class::Optional::Dependencies->req_missing_for ('admin') ) unless DBIx::Class::Optional::Dependencies->req_ok_for ('admin'); } @@ -134,7 +133,7 @@ has 'set' => ( =head2 attrs -a hash ref or json string to be used for passing additonal info to the ->search call +a hash ref or json string to be used for passing additional info to the ->search call =cut @@ -168,7 +167,7 @@ sub _build_connect_info { config_file provide a config_file to read connect_info from, if this is provided config_stanze should also be provided to locate where the connect_info is in the config -The config file should be in a format readable by Config::General +The config file should be in a format readable by Config::Any. =cut @@ -181,7 +180,7 @@ has config_file => ( =head2 config_stanza -config_stanza for use with config_file should be a '::' deliminated 'path' to the connection information +config_stanza for use with config_file should be a '::' delimited 'path' to the connection information designed for use with catalyst config files =cut @@ -257,7 +256,7 @@ has version => ( =head2 preversion -Previouse version of the schema to create an upgrade diff for, the full sql for that version of the sql must be in the sql_dir +Previous version of the schema to create an upgrade diff for, the full sql for that version of the sql must be in the sql_dir =cut @@ -324,7 +323,7 @@ sub _trigger_trace { =back -L will generate sql for the supplied schema_class in sql_dir. The +C will generate sql for the supplied schema_class in sql_dir. The flavour of sql to generate can be controlled by supplying a sqlt_type which should be a L name. @@ -403,7 +402,7 @@ sub install { print "return is $ret\n" if (!$self->quiet); } elsif ($schema->get_db_version() and $self->force ) { - carp "Forcing install may not be a good idea"; + warn "Forcing install may not be a good idea\n"; if($self->_confirm() ) { $self->schema->_set_db_version({ version => $version}); } @@ -580,6 +579,7 @@ sub _find_stanza { die ("Could not find $stanza in config, $path does not seem to exist.\n"); } } + $cfg = $cfg->{connect_info} if exists $cfg->{connect_info}; return $cfg; }