X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FAdmin.pm;h=ac47c61869f0c44bed110223c69e37d0a50bc5a7;hb=9485509b5b6fa85268a7256a20907e1f698d6af6;hp=e47e93b8727f2f7533e6bba35bbedb41de27181c;hpb=a4a02f15a49ccd4ab04bd18ff58d1de7fbe8b23f;p=dbsrgits%2FDBIx-Class-Historic.git

diff --git a/lib/DBIx/Class/Admin.pm b/lib/DBIx/Class/Admin.pm
index e47e93b..ac47c61 100644
--- a/lib/DBIx/Class/Admin.pm
+++ b/lib/DBIx/Class/Admin.pm
@@ -9,8 +9,6 @@ BEGIN {
 }
 
 use Moose;
-use parent 'DBIx::Class::Schema';
-
 use MooseX::Types::Moose qw/Int Str Any Bool/;
 use DBIx::Class::Admin::Types qw/DBICConnectInfo DBICHashRef/;
 use MooseX::Types::JSON qw(JSON);
@@ -70,8 +68,8 @@ the class of the schema to load
 =cut
 
 has 'schema_class' => (
-  is    => 'ro',
-  isa    => Str,
+  is  => 'ro',
+  isa => Str,
 );
 
 
@@ -82,14 +80,15 @@ A pre-connected schema object can be provided for manipulation
 =cut
 
 has 'schema' => (
-  is      => 'ro',
-  isa      => 'DBIx::Class::Schema',
+  is          => 'ro',
+  isa         => 'DBIx::Class::Schema',
   lazy_build  => 1,
 );
 
 sub _build_schema {
   my ($self)  = @_;
-  $self->ensure_class_loaded($self->schema_class);
+  require Class::MOP;
+  Class::MOP::load_class($self->schema_class);
 
   $self->connect_info->[3]->{ignore_version} =1;
   return $self->schema_class->connect(@{$self->connect_info()} ); # ,  $self->connect_info->[3], { ignore_version => 1} );
@@ -103,8 +102,8 @@ a resultset from the schema to operate on
 =cut
 
 has 'resultset' => (
-  is      => 'rw',
-  isa      => Str,
+  is  => 'rw',
+  isa => Str,
 );
 
 
@@ -116,8 +115,8 @@ a hash ref or json string to be used for identifying data to manipulate
 
 has 'where' => (
   is      => 'rw',
-  isa      => DBICHashRef,
-  coerce    => 1,
+  isa     => DBICHashRef,
+  coerce  => 1,
 );
 
 
@@ -129,8 +128,8 @@ a hash ref or json string to be used for inserting or updating data
 
 has 'set' => (
   is      => 'rw',
-  isa      => DBICHashRef,
-  coerce    => 1,
+  isa     => DBICHashRef,
+  coerce  => 1,
 );
 
 
@@ -141,9 +140,9 @@ a hash ref or json string to be used for passing additonal info to the ->search
 =cut
 
 has 'attrs' => (
-  is       => 'rw',
-  isa      => DBICHashRef,
-  coerce    => 1,
+  is      => 'rw',
+  isa     => DBICHashRef,
+  coerce  => 1,
 );
 
 
@@ -154,10 +153,10 @@ connect_info the arguments to provide to the connect call of the schema_class
 =cut
 
 has 'connect_info' => (
-  is      => 'ro',
-  isa      => DBICConnectInfo,
+  is          => 'ro',
+  isa         => DBICConnectInfo,
   lazy_build  => 1,
-  coerce    => 1,
+  coerce      => 1,
 );
 
 sub _build_connect_info {
@@ -176,8 +175,8 @@ The config file should be in a format readable by Config::General
 
 has config_file => (
   is      => 'ro',
-  isa      => File,
-  coerce    => 1,
+  isa     => File,
+  coerce  => 1,
 );
 
 
@@ -189,8 +188,8 @@ designed for use with catalyst config files
 =cut
 
 has 'config_stanza' => (
-  is      => 'ro',
-  isa      => Str,
+  is  => 'ro',
+  isa => Str,
 );
 
 
@@ -202,16 +201,16 @@ config_stanza will still be required.
 =cut
 
 has config => (
-  is      => 'ro',
-  isa      => DBICHashRef,
+  is          => 'ro',
+  isa         => DBICHashRef,
   lazy_build  => 1,
 );
 
 sub _build_config {
   my ($self) = @_;
 
-  eval { require Config::Any }
-    or $self->throw_exception( "Config::Any is required to parse the config file");
+  try { require Config::Any }
+    catch { die ("Config::Any is required to parse the config file.\n") };
 
   my $cfg = Config::Any->load_files ( {files => [$self->config_file], use_ext =>1, flatten_to_hash=>1});
 
@@ -229,8 +228,8 @@ The location where sql ddl files should be created or found for an upgrade.
 
 has 'sql_dir' => (
   is      => 'ro',
-  isa      => Dir,
-  coerce    => 1,
+  isa     => Dir,
+  coerce  => 1,
 );
 
 
@@ -241,8 +240,8 @@ Used for install, the version which will be 'installed' in the schema
 =cut
 
 has version => (
-  is      => 'rw',
-  isa      => Str,
+  is  => 'rw',
+  isa => Str,
 );
 
 
@@ -253,8 +252,8 @@ Previouse version of the schema to create an upgrade diff for, the full sql for
 =cut
 
 has preversion => (
-  is      => 'rw',
-  isa      => Str,
+  is  => 'rw',
+  isa => Str,
 );
 
 
@@ -265,8 +264,8 @@ Try and force certain operations.
 =cut
 
 has force => (
-  is      => 'rw',
-  isa      => Bool,
+  is  => 'rw',
+  isa => Bool,
 );
 
 
@@ -277,13 +276,13 @@ Be less verbose about actions
 =cut
 
 has quiet => (
-  is      => 'rw',
-  isa      => Bool,
+  is  => 'rw',
+  isa => Bool,
 );
 
 has '_confirm' => (
-  is    => 'bare',
-  isa    => Bool,
+  is  => 'bare',
+  isa => Bool,
 );
 
 
@@ -337,7 +336,7 @@ sub upgrade {
   my $schema = $self->schema();
   if (!$schema->get_db_version()) {
     # schema is unversioned
-    $self->throw_exception ("could not determin current schema version, please either install or deploy");
+    $schema->throw_exception ("Could not determin current schema version, please either install() or deploy().\n");
   } else {
     my $ret = $schema->upgrade();
     return $ret;
@@ -378,7 +377,7 @@ sub install {
     }
   }
   else {
-    $self->throw_exception ("schema already has a version not installing, try upgrade instead");
+    $schema->throw_exception ("Schema already has a version. Try upgrade instead.\n");
   }
 
 }
@@ -403,9 +402,9 @@ sub deploy {
   if (!$schema->get_db_version() ) {
     # schema is unversioned
     $schema->deploy( $args, $self->sql_dir)
-      or $self->throw_exception ("could not deploy schema");
+      or $schema->throw_exception ("Could not deploy schema.\n"); # FIXME deploy() does not return 1/0 on success/fail
   } else {
-    $self->throw_exception("there already is a database with a version here, try upgrade instead");
+    $schema->throw_exception("A versioned schema has already been deployed, try upgrade instead.\n");
   }
 }
 
@@ -550,7 +549,7 @@ sub _find_stanza {
       $cfg = $cfg->{$path};
     }
     else {
-      $self->throw_exception("could not find $stanza in config, $path did not seem to exist");
+      die ("Could not find $stanza in config, $path does not seem to exist.\n");
     }
   }
   return $cfg;