X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FAccessorGroup.pm;h=c999a6b496c60276eb1b10e52b543b6c59c97fed;hb=fcf32d045;hp=a7e85be061135179abe0d0adb9056d533100dca8;hpb=c687b87e860c97257542dda2b14c0137f6fbc583;p=dbsrgits%2FDBIx-Class.git diff --git a/lib/DBIx/Class/AccessorGroup.pm b/lib/DBIx/Class/AccessorGroup.pm index a7e85be..c999a6b 100644 --- a/lib/DBIx/Class/AccessorGroup.pm +++ b/lib/DBIx/Class/AccessorGroup.pm @@ -3,120 +3,54 @@ package DBIx::Class::AccessorGroup; use strict; use warnings; -use NEXT; +use base qw/Class::Accessor::Grouped/; +use Scalar::Util qw/weaken blessed/; +use namespace::clean; -sub mk_group_accessors { - my($self, $group, @fields) = @_; +my $successfully_loaded_components; - $self->_mk_group_accessors('make_group_accessor', $group, @fields); -} - - -{ - no strict 'refs'; - no warnings 'redefine'; - - sub _mk_group_accessors { - my($self, $maker, $group, @fields) = @_; - my $class = ref $self || $self; - - # So we don't have to do lots of lookups inside the loop. - $maker = $self->can($maker) unless ref $maker; +sub get_component_class { + my $class = $_[0]->get_inherited($_[1]); - foreach my $field (@fields) { - if( $field eq 'DESTROY' ) { - require Carp; - &Carp::carp("Having a data accessor named DESTROY in ". - "'$class' is unwise."); - } + # It's already an object, just go for it. + return $class if blessed $class; - my $name = $field; + if (defined $class and ! $successfully_loaded_components->{$class} ) { + $_[0]->ensure_class_loaded($class); - ($name, $field) = @$field if ref $field; - - my $accessor = $self->$maker($group, $field); - my $alias = "_${name}_accessor"; - - #warn "$class $group $field $alias"; - - *{$class."\:\:$name"} = $accessor; - #unless defined &{$class."\:\:$field"} - - *{$class."\:\:$alias"} = $accessor; - #unless defined &{$class."\:\:$alias"} - } - } -} - -sub mk_group_ro_accessors { - my($self, $group, @fields) = @_; - - $self->_mk_group_accessors('make_group_ro_accessor', $group, @fields); -} + no strict 'refs'; + $successfully_loaded_components->{$class} + = ${"${class}::__LOADED__BY__DBIC__CAG__COMPONENT_CLASS__"} + = do { \(my $anon = 'loaded') }; + weaken($successfully_loaded_components->{$class}); + } -sub mk_group_wo_accessors { - my($self, $group, @fields) = @_; + $class; +}; - $self->_mk_group_accessors('make_group_wo_accessor', $group, @fields); +sub set_component_class { + shift->set_inherited(@_); } -sub make_group_accessor { - my ($class, $group, $field) = @_; - - my $set = "set_$group"; - my $get = "get_$group"; +1; - # Build a closure around $field. - return sub { - my $self = shift; +=head1 NAME - if(@_) { - return $self->$set($field, @_); - } - else { - return $self->$get($field); - } - }; -} +DBIx::Class::AccessorGroup - See Class::Accessor::Grouped -sub make_group_ro_accessor { - my($class, $group, $field) = @_; +=head1 SYNOPSIS - my $get = "get_$group"; +=head1 DESCRIPTION - return sub { - my $self = shift; +This class now exists in its own right on CPAN as Class::Accessor::Grouped - if(@_) { - my $caller = caller; - require Carp; - Carp::croak("'$caller' cannot alter the value of '$field' on ". - "objects of class '$class'"); - } - else { - return $self->$get($field); - } - }; -} +=head1 AUTHOR AND CONTRIBUTORS -sub make_group_wo_accessor { - my($class, $group, $field) = @_; +See L and L in DBIx::Class - my $set = "set_$group"; +=head1 LICENSE - return sub { - my $self = shift; +You may distribute this code under the same terms as Perl itself. - unless (@_) { - my $caller = caller; - require Carp; - Carp::croak("'$caller' cannot access the value of '$field' on ". - "objects of class '$class'"); - } - else { - return $self->$set($field, @_); - } - }; -} +=cut -1;