X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FModule.pm;h=f8d22b24c8b6ffc66d2e8baf2dd39922f5e261b9;hb=d004c8d565f9b314da7652e9368aeb4587ffaa3d;hp=24eeacaa19b7e3d3205508612fee2add8fb217c2;hpb=ec9e38e5fd24916a3b5a4b67b5e7c7d20674d0f5;p=gitmo%2FClass-MOP.git diff --git a/lib/Class/MOP/Module.pm b/lib/Class/MOP/Module.pm index 24eeaca..f8d22b2 100644 --- a/lib/Class/MOP/Module.pm +++ b/lib/Class/MOP/Module.pm @@ -7,19 +7,20 @@ use warnings; use Carp 'confess'; use Scalar::Util 'blessed'; -our $VERSION = '0.89'; +our $VERSION = '1.12'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; use base 'Class::MOP::Package'; -sub _new{ +sub _new { my $class = shift; return Class::MOP::Class->initialize($class)->new_object(@_) - if $class ne __PACKAGE__; + if $class ne __PACKAGE__; my $params = @_ == 1 ? $_[0] : {@_}; return bless { + # from Class::MOP::Package package => $params->{package}, namespace => \undef, @@ -32,12 +33,12 @@ sub _new{ sub version { my $self = shift; - ${$self->get_package_symbol({ sigil => '$', type => 'SCALAR', name => 'VERSION' })}; + ${$self->get_or_add_package_symbol('$VERSION')}; } sub authority { my $self = shift; - ${$self->get_package_symbol({ sigil => '$', type => 'SCALAR', name => 'AUTHORITY' })}; + ${$self->get_or_add_package_symbol('$AUTHORITY')}; } sub identifier { @@ -54,26 +55,18 @@ sub create { } sub _instantiate_module { - my $self = shift; - my $version = shift; - my $authority = shift; - + my($self, $version, $authority) = @_; my $package_name = $self->name; - my $code = "package $package_name;"; + Class::MOP::_is_valid_class_name($package_name) + || confess "creation of $package_name failed: invalid package name"; - $code .= "\$$package_name\:\:VERSION = '" . $version . "';" - if defined $version; - $code .= "\$$package_name\:\:AUTHORITY = '" . $authority . "';" - if defined $authority; + no strict 'refs'; + scalar %{ $package_name . '::' }; # touch the stash + ${ $package_name . '::VERSION' } = $version if defined $version; + ${ $package_name . '::AUTHORITY' } = $authority if defined $authority; - my $e = do { - local $@; - local $SIG{__DIE__}; - eval $code; - $@; - }; - confess "creation of $package_name failed : $e" if $e; + return; } 1; @@ -126,7 +119,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2009 by Infinity Interactive, Inc. +Copyright 2006-2010 by Infinity Interactive, Inc. L