X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FModule.pm;h=2dba8557b90a87f6d4544bc0108ebe6309f8b2fe;hb=3bc310dd562250ad2bbce64058877d7d95d931a9;hp=6f9649177278c85f8e04690a22920208c501f4fd;hpb=070bb6c98b09351644c335dc9614d9bbba5d2684;p=gitmo%2FClass-MOP.git

diff --git a/lib/Class/MOP/Module.pm b/lib/Class/MOP/Module.pm
index 6f96491..2dba855 100644
--- a/lib/Class/MOP/Module.pm
+++ b/lib/Class/MOP/Module.pm
@@ -7,7 +7,7 @@ use warnings;
 use Carp         'confess';
 use Scalar::Util 'blessed';
 
-our $VERSION   = '0.78';
+our $VERSION   = '0.85';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
@@ -33,23 +33,25 @@ sub identifier {
 }
 
 sub create {
-    my ( $class, %options ) = @_;
+    confess "The Class::MOP::Module->create method has been made a private object method.\n";
+}
 
-    my $package_name = $options{package};
+sub _instantiate_module {
+    my $self      = shift;
+    my $version   = shift;
+    my $authority = shift;
 
-    (defined $package_name && $package_name)
-        || confess "You must pass a package name";
+    my $package_name = $self->name;
 
     my $code = "package $package_name;";
-    $code .= "\$$package_name\:\:VERSION = '" . $options{version} . "';"
-        if exists $options{version};
-    $code .= "\$$package_name\:\:AUTHORITY = '" . $options{authority} . "';"
-        if exists $options{authority};
+
+    $code .= "\$$package_name\:\:VERSION = '" . $version . "';"
+        if defined $version;
+    $code .= "\$$package_name\:\:AUTHORITY = '" . $authority . "';"
+        if defined $authority;
 
     eval $code;
     confess "creation of $package_name failed : $@" if $@;
-
-    return; # XXX: should this return some kind of meta object? ~sartak
 }
 
 1;
@@ -64,44 +66,35 @@ Class::MOP::Module - Module Meta Object
 
 =head1 DESCRIPTION
 
-This is an abstraction of a Perl 5 module, it is a superclass of
-L<Class::MOP::Class>. A module essentially a package with metadata, 
-in our case the version and authority. 
+A module is essentially a L<Class::MOP::Package> with metadata, in our
+case the version and authority.
 
 =head1 INHERITANCE
 
-B<Class::MOP::Module> is a subclass of L<Class::MOP::Package>
+B<Class::MOP::Module> is a subclass of L<Class::MOP::Package>.
 
 =head1 METHODS
 
 =over 4
 
-=item B<meta>
-
-Returns a metaclass for this package.
-
-=item B<initialize ($package_name)>
-
-This will initialize a Class::MOP::Module instance which represents 
-the module of C<$package_name>.
-
-=item B<version>
+=item B<< $metamodule->version >>
 
-This is a read-only attribute which returns the C<$VERSION> of the 
-package for the given instance.
+This is a read-only attribute which returns the C<$VERSION> of the
+package, if one exists.
 
-=item B<authority>
+=item B<< $metamodule->authority >>
 
-This is a read-only attribute which returns the C<$AUTHORITY> of the 
-package for the given instance.
+This is a read-only attribute which returns the C<$AUTHORITY> of the
+package, if one exists.
 
-=item B<identifier>
+=item B<< $metamodule->identifier >>
 
-This constructs a string of the name, version and authority.
+This constructs a string which combines the name, version and
+authority.
 
-=item B<create>
+=item B<< Class::MOP::Module->meta >>
 
-This creates the module; it does not return a useful result.
+This will return a L<Class::MOP::Class> instance for this class.
 
 =back