X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FMethod%2FConstructor.pm;h=ae5a548e75de55eb0b07bd694e64ca3f71408bec;hb=150f8be79166ab0b949ed4297c03107855501e60;hp=2d47859ba460ca53e6f4689447458990e5669a4d;hpb=097eeb20923df544ba145c1e61bc773d7df5857a;p=gitmo%2FClass-MOP.git

diff --git a/lib/Class/MOP/Method/Constructor.pm b/lib/Class/MOP/Method/Constructor.pm
index 2d47859..ae5a548 100644
--- a/lib/Class/MOP/Method/Constructor.pm
+++ b/lib/Class/MOP/Method/Constructor.pm
@@ -7,7 +7,7 @@ use warnings;
 use Carp         'confess';
 use Scalar::Util 'blessed', 'weaken', 'looks_like_number';
 
-our $VERSION   = '0.77_01';
+our $VERSION   = '0.78';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
@@ -102,7 +102,7 @@ sub generate_constructor_method_inline {
     $source .= "\n" . 'my $instance = ' . $self->meta_instance->inline_create_instance('$class');
     $source .= ";\n" . (join ";\n" => map {
         $self->_generate_slot_initializer($_, $close_over)
-    } 0 .. (@{$self->attributes} - 1));
+    } @{$self->attributes});
     $source .= ";\n" . 'return $instance';
     $source .= ";\n" . '}';
     warn $source if $self->options->{debug};
@@ -118,11 +118,9 @@ sub generate_constructor_method_inline {
 
 sub _generate_slot_initializer {
     my $self  = shift;
-    my $index = shift;
+    my $attr  = shift;
     my $close = shift;
 
-    my $attr = $self->attributes->[$index];
-
     my $default;
     if ($attr->has_default) {
         # NOTE:
@@ -197,58 +195,58 @@ Class::MOP::Method::Constructor - Method Meta Object for constructors
 
 =head1 DESCRIPTION
 
-This is a subclass of C<Class::MOP::Method> which deals with
-class constructors. This is used when making a class immutable
-to generate an optimized constructor.
+This is a subclass of C<Class::MOP::Method> which generates
+constructor methods.
 
 =head1 METHODS
 
 =over 4
 
-=item B<new (metaclass => $meta, options => \%options)>
+=item B<< Class::MOP::Method::Constructor->new(%options) >>
 
-=item B<options>
+This creates a new constructor object. It accepts a hash reference of
+options.
 
-This returns the options HASH which is passed into C<new>.
+=over 8
 
-=item B<associated_metaclass>
+=item * metaclass
 
-This returns the metaclass which is passed into C<new>.
+This should be a L<Class::MOP::Class> object. It is required.
 
-=item B<attributes>
+=item * name
 
-This returns the list of attributes which are associated with the
-metaclass which is passed into C<new>.
+The method name (without a package name). This is required.
 
-=item B<meta_instance>
+=item * package_name
 
-This returns the meta instance which is associated with the
-metaclass which is passed into C<new>.
+The package name for the method. This is required.
 
-=item B<is_inline>
+=item * is_inline
 
-This returns a boolean, but since constructors are very rarely
-not inlined, this always returns true for now.
+This indicates whether or not the constructor should be inlined. This
+defaults to false.
 
-=item B<can_be_inlined>
+=back
 
-This method always returns true in this class. It exists so that
-subclasses (like in Moose) can override and do some sort of checking
-to determine whether or not inlining the constructor is safe.
+=item B<< $metamethod->is_inline >>
 
-=item B<initialize_body>
+Returns a boolean indicating whether or not the constructor is
+inlined.
 
-This creates the code reference for the constructor itself.
+=item B<< $metamethod->associated_metaclass >>
 
-=back
+This returns the L<Class::MOP::Class> object for the method.
 
-=head2 Method Generators 
+=item B<< $metamethod->is_inline >>
 
-=over 4
+Returns a boolean indicating whether or not the constructor is
+inlined.
 
-=item B<generate_constructor_method>
+=item B<< $metamethod->can_be_inlined >>
 
-=item B<generate_constructor_method_inline>
+This method always returns true in this class. It exists so that
+subclasses (as in Moose) can do some sort of checking to determine
+whether or not inlining the constructor is safe.
 
 =back
 
@@ -258,7 +256,7 @@ Stevan Little E<lt>stevan@iinteractive.comE<gt>
 
 =head1 COPYRIGHT AND LICENSE
 
-Copyright 2006-2008 by Infinity Interactive, Inc.
+Copyright 2006-2009 by Infinity Interactive, Inc.
 
 L<http://www.iinteractive.com>