X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FMethod%2FConstructor.pm;h=23d4f41ffa06d2b4cd53273cb90b59801030a527;hb=436d2a84bd01a0a9798178c57d89e5edbc9b5f02;hp=980d151952623186d98a5ea5f966d1bc3332af53;hpb=6b5ac420e48ce3b29d9fe53094954821508b2925;p=gitmo%2FClass-MOP.git diff --git a/lib/Class/MOP/Method/Constructor.pm b/lib/Class/MOP/Method/Constructor.pm index 980d151..23d4f41 100644 --- a/lib/Class/MOP/Method/Constructor.pm +++ b/lib/Class/MOP/Method/Constructor.pm @@ -7,11 +7,11 @@ use warnings; use Carp 'confess'; use Scalar::Util 'blessed', 'weaken', 'looks_like_number'; -our $VERSION = '0.71_02'; +our $VERSION = '0.93'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; -use base 'Class::MOP::Method::Generated'; +use base 'Class::MOP::Method::Inlined'; sub new { my $class = shift; @@ -31,29 +31,40 @@ sub new { # needed weaken($self->{'associated_metaclass'}); - $self->initialize_body; + $self->_initialize_body; return $self; } sub _new { my $class = shift; - my $options = @_ == 1 ? $_[0] : {@_}; - - bless { - # from our superclass - 'body' => undef, - 'package_name' => $options->{package_name}, - 'name' => $options->{name}, - # specific to this subclass - 'options' => $options->{options} || {}, - 'associated_metaclass' => $options->{metaclass}, - 'is_inline' => ($options->{is_inline} || 0), + + return Class::MOP::Class->initialize($class)->new_object(@_) + if $class ne __PACKAGE__; + + my $params = @_ == 1 ? $_[0] : {@_}; + + return bless { + # inherited from Class::MOP::Method + body => $params->{body}, + # associated_metaclass => $params->{associated_metaclass}, # overriden + package_name => $params->{package_name}, + name => $params->{name}, + original_method => $params->{original_method}, + + # inherited from Class::MOP::Generated + is_inline => $params->{is_inline} || 0, + definition_context => $params->{definition_context}, + + # inherited from Class::MOP::Inlined + _expected_method_class => $params->{_expected_method_class}, + + # defined in this subclass + options => $params->{options} || {}, + associated_metaclass => $params->{metaclass}, }, $class; } -sub can_be_inlined { 1 } - ## accessors sub options { (shift)->{'options'} } @@ -61,34 +72,36 @@ sub associated_metaclass { (shift)->{'associated_metaclass'} } ## cached values ... -sub meta_instance { +sub _meta_instance { my $self = shift; $self->{'meta_instance'} ||= $self->associated_metaclass->get_meta_instance; } -sub attributes { +sub _attributes { my $self = shift; - $self->{'attributes'} ||= [ $self->associated_metaclass->compute_all_applicable_attributes ] + $self->{'attributes'} ||= [ $self->associated_metaclass->get_all_attributes ] } ## method -sub initialize_body { +sub _initialize_body { my $self = shift; - my $method_name = 'generate_constructor_method'; + my $method_name = '_generate_constructor_method'; $method_name .= '_inline' if $self->is_inline; $self->{'body'} = $self->$method_name; } -sub generate_constructor_method { +sub _generate_constructor_method { return sub { Class::MOP::Class->initialize(shift)->new_object(@_) } } -sub generate_constructor_method_inline { +sub _generate_constructor_method_inline { my $self = shift; + my $close_over = {}; + my $source = 'sub {'; $source .= "\n" . 'my $class = shift;'; @@ -97,32 +110,27 @@ sub generate_constructor_method_inline { $source .= "\n" . 'my $params = @_ == 1 ? $_[0] : {@_};'; - $source .= "\n" . 'my $instance = ' . $self->meta_instance->inline_create_instance('$class'); + $source .= "\n" . 'my $instance = ' . $self->_meta_instance->inline_create_instance('$class'); $source .= ";\n" . (join ";\n" => map { - $self->_generate_slot_initializer($_) - } 0 .. (@{$self->attributes} - 1)); + $self->_generate_slot_initializer($_, $close_over) + } @{ $self->_attributes }); $source .= ";\n" . 'return $instance'; $source .= ";\n" . '}'; warn $source if $self->options->{debug}; - my $code; - { - # NOTE: - # create the nessecary lexicals - # to be picked up in the eval - my $attrs = $self->attributes; + my ( $code, $e ) = $self->_eval_closure( + $close_over, + $source + ); + confess "Could not eval the constructor :\n\n$source\n\nbecause :\n\n$e" if $e; - $code = eval $source; - confess "Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@" if $@; - } return $code; } sub _generate_slot_initializer { my $self = shift; - my $index = shift; - - my $attr = $self->attributes->[$index]; + my $attr = shift; + my $close = shift; my $default; if ($attr->has_default) { @@ -133,7 +141,9 @@ sub _generate_slot_initializer { # in which case we can just deal with them # in the code we eval. if ($attr->is_default_a_coderef) { - $default = '$attrs->[' . $index . ']->default($instance)'; + my $idx = @{$close->{'@defaults'}||=[]}; + push(@{$close->{'@defaults'}}, $attr->default); + $default = '$defaults[' . $idx . ']->($instance)'; } else { $default = $attr->default; @@ -146,25 +156,25 @@ sub _generate_slot_initializer { $default = '$instance->'.$attr->builder; } - if ( defined $attr->init_arg ) { + if ( defined(my $init_arg = $attr->init_arg) ) { return ( - 'if(exists $params->{\'' . $attr->init_arg . '\'}){' . "\n" . - $self->meta_instance->inline_set_slot_value( + 'if(exists $params->{\'' . $init_arg . '\'}){' . "\n" . + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), - '$params->{\'' . $attr->init_arg . '\'}' ) . "\n" . + $attr->name, + '$params->{\'' . $init_arg . '\'}' ) . "\n" . '} ' . (!defined $default ? '' : 'else {' . "\n" . - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, $default ) . "\n" . '}') ); } elsif ( defined $default ) { return ( - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, $default ) . "\n" ); } else { return '' } @@ -196,58 +206,47 @@ Class::MOP::Method::Constructor - Method Meta Object for constructors =head1 DESCRIPTION -This is a subclass of C which deals with -class constructors. This is used when making a class immutable -to generate an optimized constructor. +This is a subclass of C which generates +constructor methods. =head1 METHODS =over 4 -=item B $meta, options => \%options)> - -=item B +=item B<< Class::MOP::Method::Constructor->new(%options) >> -This returns the options HASH which is passed into C. +This creates a new constructor object. It accepts a hash reference of +options. -=item B +=over 8 -This returns the metaclass which is passed into C. +=item * metaclass -=item B +This should be a L object. It is required. -This returns the list of attributes which are associated with the -metaclass which is passed into C. +=item * name -=item B +The method name (without a package name). This is required. -This returns the meta instance which is associated with the -metaclass which is passed into C. +=item * package_name -=item B +The package name for the method. This is required. -This returns a boolean, but since constructors are very rarely -not inlined, this always returns true for now. +=item * is_inline -=item B - -This method always returns true in this class. It exists so that -subclasses (like in Moose) can override and do some sort of checking -to determine whether or not inlining the constructor is safe. - -=item B - -This creates the code reference for the constructor itself. +This indicates whether or not the constructor should be inlined. This +defaults to false. =back -=head2 Method Generators +=item B<< $metamethod->is_inline >> -=over 4 +Returns a boolean indicating whether or not the constructor is +inlined. -=item B +=item B<< $metamethod->associated_metaclass >> -=item B +This returns the L object for the method. =back @@ -257,7 +256,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2008 by Infinity Interactive, Inc. +Copyright 2006-2009 by Infinity Interactive, Inc. L