X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FMethod%2FConstructor.pm;h=016f9ba87f9649257452f4804caeaef1e4a298c2;hb=e00524a03329f89358767302ffc62cd15ec33571;hp=f14c0354996f0bb0bde8bba487f6388f7ddc9b11;hpb=f0de47d9b033b6b5175454e7fb3fb43c4ef5ed2e;p=gitmo%2FClass-MOP.git diff --git a/lib/Class/MOP/Method/Constructor.pm b/lib/Class/MOP/Method/Constructor.pm index f14c035..016f9ba 100644 --- a/lib/Class/MOP/Method/Constructor.pm +++ b/lib/Class/MOP/Method/Constructor.pm @@ -7,11 +7,11 @@ use warnings; use Carp 'confess'; use Scalar::Util 'blessed', 'weaken', 'looks_like_number'; -our $VERSION = '0.71_01'; +our $VERSION = '0.83'; $VERSION = eval $VERSION; our $AUTHORITY = 'cpan:STEVAN'; -use base 'Class::MOP::Method::Generated'; +use base 'Class::MOP::Method::Inlined'; sub new { my $class = shift; @@ -31,7 +31,7 @@ sub new { # needed weaken($self->{'associated_metaclass'}); - $self->initialize_body; + $self->_initialize_body; return $self; } @@ -52,8 +52,6 @@ sub _new { }, $class; } -sub can_be_inlined { 1 } - ## accessors sub options { (shift)->{'options'} } @@ -62,20 +60,39 @@ sub associated_metaclass { (shift)->{'associated_metaclass'} } ## cached values ... sub meta_instance { + Carp::cluck('The meta_instance method has been made private.' + . " The public version is deprecated and will be removed in a future release.\n"); + shift->_meta_instance; +} + +sub _meta_instance { my $self = shift; $self->{'meta_instance'} ||= $self->associated_metaclass->get_meta_instance; } sub attributes { + Carp::cluck('The attributes method has been made private.' + . " The public version is deprecated and will be removed in a future release.\n"); + + return shift->_attributes; +} + +sub _attributes { my $self = shift; - $self->{'attributes'} ||= [ $self->associated_metaclass->compute_all_applicable_attributes ] + $self->{'attributes'} ||= [ $self->associated_metaclass->get_all_attributes ] } ## method sub initialize_body { + Carp::cluck('The initialize_body method has been made private.' + . " The public version is deprecated and will be removed in a future release.\n"); + shift->_initialize_body; +} + +sub _initialize_body { my $self = shift; - my $method_name = 'generate_constructor_method'; + my $method_name = '_generate_constructor_method'; $method_name .= '_inline' if $self->is_inline; @@ -83,12 +100,26 @@ sub initialize_body { } sub generate_constructor_method { + Carp::cluck('The generate_constructor_method method has been made private.' + . " The public version is deprecated and will be removed in a future release.\n"); + shift->_generate_constructor_method; +} + +sub _generate_constructor_method { return sub { Class::MOP::Class->initialize(shift)->new_object(@_) } } sub generate_constructor_method_inline { + Carp::cluck('The generate_constructor_method_inline method has been made private.' + . " The public version is deprecated and will be removed in a future release.\n"); + shift->_generate_constructor_method_inline; +} + +sub _generate_constructor_method_inline { my $self = shift; + my $close_over = {}; + my $source = 'sub {'; $source .= "\n" . 'my $class = shift;'; @@ -97,32 +128,27 @@ sub generate_constructor_method_inline { $source .= "\n" . 'my $params = @_ == 1 ? $_[0] : {@_};'; - $source .= "\n" . 'my $instance = ' . $self->meta_instance->inline_create_instance('$class'); + $source .= "\n" . 'my $instance = ' . $self->_meta_instance->inline_create_instance('$class'); $source .= ";\n" . (join ";\n" => map { - $self->_generate_slot_initializer($_) - } 0 .. (@{$self->attributes} - 1)); + $self->_generate_slot_initializer($_, $close_over) + } @{ $self->_attributes }); $source .= ";\n" . 'return $instance'; $source .= ";\n" . '}'; warn $source if $self->options->{debug}; - my $code; - { - # NOTE: - # create the nessecary lexicals - # to be picked up in the eval - my $attrs = $self->attributes; + my $code = $self->_eval_closure( + $close_over, + $source + ); + confess "Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@" if $@; - $code = eval $source; - confess "Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@" if $@; - } return $code; } sub _generate_slot_initializer { my $self = shift; - my $index = shift; - - my $attr = $self->attributes->[$index]; + my $attr = shift; + my $close = shift; my $default; if ($attr->has_default) { @@ -133,7 +159,9 @@ sub _generate_slot_initializer { # in which case we can just deal with them # in the code we eval. if ($attr->is_default_a_coderef) { - $default = '$attrs->[' . $index . ']->default($instance)'; + my $idx = @{$close->{'@defaults'}||=[]}; + push(@{$close->{'@defaults'}}, $attr->default); + $default = '$defaults[' . $idx . ']->($instance)'; } else { $default = $attr->default; @@ -149,22 +177,22 @@ sub _generate_slot_initializer { if ( defined $attr->init_arg ) { return ( 'if(exists $params->{\'' . $attr->init_arg . '\'}){' . "\n" . - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, '$params->{\'' . $attr->init_arg . '\'}' ) . "\n" . '} ' . (!defined $default ? '' : 'else {' . "\n" . - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, $default ) . "\n" . '}') ); } elsif ( defined $default ) { return ( - $self->meta_instance->inline_set_slot_value( + $self->_meta_instance->inline_set_slot_value( '$instance', - ("'" . $attr->name . "'"), + $attr->name, $default ) . "\n" ); } else { return '' } @@ -196,58 +224,47 @@ Class::MOP::Method::Constructor - Method Meta Object for constructors =head1 DESCRIPTION -This is a subclass of C which deals with -class constructors. This is used when making a class immutable -to generate an optimized constructor. +This is a subclass of C which generates +constructor methods. =head1 METHODS =over 4 -=item B $meta, options => \%options)> +=item B<< Class::MOP::Method::Constructor->new(%options) >> -=item B +This creates a new constructor object. It accepts a hash reference of +options. -This returns the options HASH which is passed into C. +=over 8 -=item B +=item * metaclass -This returns the metaclass which is passed into C. +This should be a L object. It is required. -=item B +=item * name -This returns the list of attributes which are associated with the -metaclass which is passed into C. +The method name (without a package name). This is required. -=item B +=item * package_name -This returns the meta instance which is associated with the -metaclass which is passed into C. +The package name for the method. This is required. -=item B +=item * is_inline -This returns a boolean, but since constructors are very rarely -not inlined, this always returns true for now. - -=item B - -This method always returns true in this class. It exists so that -subclasses (like in Moose) can override and do some sort of checking -to determine whether or not inlining the constructor is safe. - -=item B - -This creates the code reference for the constructor itself. +This indicates whether or not the constructor should be inlined. This +defaults to false. =back -=head2 Method Generators +=item B<< $metamethod->is_inline >> -=over 4 +Returns a boolean indicating whether or not the constructor is +inlined. -=item B +=item B<< $metamethod->associated_metaclass >> -=item B +This returns the L object for the method. =back @@ -257,7 +274,7 @@ Stevan Little Estevan@iinteractive.comE =head1 COPYRIGHT AND LICENSE -Copyright 2006-2008 by Infinity Interactive, Inc. +Copyright 2006-2009 by Infinity Interactive, Inc. L