X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FClass%2FMOP%2FImmutable.pm;h=0b408e16bc8a7a696face806f13c2b3cdc63c289;hb=229910b5cf0bee35e072db0f8305e799241d4366;hp=5898faa12cdbf3ad90c70691d3e04eb06c065eb3;hpb=a92a3fc064057221cf555728a34901c8062fb069;p=gitmo%2FClass-MOP.git diff --git a/lib/Class/MOP/Immutable.pm b/lib/Class/MOP/Immutable.pm index 5898faa..0b408e1 100644 --- a/lib/Class/MOP/Immutable.pm +++ b/lib/Class/MOP/Immutable.pm @@ -69,13 +69,19 @@ my %DEFAULT_METHODS = ( # existing metaclass to an immutable # version of itself sub make_metaclass_immutable { - my ($self, $metaclass, %options) = @_; + my ($self, $metaclass, $options) = @_; + + foreach my $pair ( + [ inline_accessors => 1 ], + [ inline_constructor => 1 ], + [ inline_destructor => 0 ], + [ constructor_name => 'new' ], + [ debug => 0 ], + ) { + $options->{$pair->[0]} = $pair->[1] unless exists $options->{$pair->[0]}; + } - $options{inline_accessors} = 1 unless exists $options{inline_accessors}; - $options{inline_constructor} = 1 unless exists $options{inline_constructor}; - $options{inline_destructor} = 0 unless exists $options{inline_destructor}; - $options{constructor_name} = 'new' unless exists $options{constructor_name}; - $options{debug} = 0 unless exists $options{debug}; + my %options = %$options; if ($options{inline_accessors}) { foreach my $attr_name ($metaclass->get_attribute_list) { @@ -141,7 +147,9 @@ sub make_metaclass_immutable { } sub make_metaclass_mutable { - my ($self, $immutable, %options) = @_; + my ($self, $immutable, $options) = @_; + + my %options = %$options; my $original_class = $immutable->get_mutable_metaclass_name; delete $immutable->{'___original_class'} ; @@ -180,7 +188,6 @@ sub make_metaclass_mutable { # 14:26 <@stevan> the only user of ::Method::Constructor is immutable # 14:27 <@stevan> if someone uses it outside of immutable,.. they are either: mst or groditi # 14:27 <@stevan> so I am not worried - $options{constructor_name} = 'new' unless exists $options{constructor_name}; if ($options{inline_constructor}) { my $constructor_class = $options{constructor_class} || 'Class::MOP::Method::Constructor'; $immutable->remove_method( $options{constructor_name} )