X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?a=blobdiff_plain;f=lib%2FCatalyst.pm;h=7a31fd340459c08258b3c7e93bdaa7af40220b47;hb=2dc77703330d645d683f869681221d2be8e4b5be;hp=549af887669b4d60733c07737f1ff6c4927e7212;hpb=c23b894b1e0dda68841e82cfd85219d2627e7ac2;p=catagits%2FCatalyst-Runtime.git diff --git a/lib/Catalyst.pm b/lib/Catalyst.pm index 549af88..7a31fd3 100644 --- a/lib/Catalyst.pm +++ b/lib/Catalyst.pm @@ -1199,7 +1199,7 @@ sub uri_for { ( scalar @args && ref $args[$#args] eq 'HASH' ? pop @args : {} ); carp "uri_for called with undef argument" if grep { ! defined $_ } @args; - s/([^A-Za-z0-9\-_.!~*'()+])/$URI::Escape::escapes{$1}/go for @args; + s/([^$URI::uric])/$URI::Escape::escapes{$1}/go for @args; unshift(@args, $path); @@ -1233,7 +1233,7 @@ sub uri_for { $_ = "$_"; utf8::encode( $_ ) if utf8::is_utf8($_); # using the URI::Escape pattern here so utf8 chars survive - s/([^A-Za-z0-9\-_.!~*'()])/$URI::Escape::escapes{$1}/go; + s/([^A-Za-z0-9\-_.!~*'() ])/$URI::Escape::escapes{$1}/go; s/ /+/g; "${key}=$_"; } ( ref $val eq 'ARRAY' ? @$val : $val )); } @keys); @@ -2716,6 +2716,8 @@ chicks: Christopher Hicks David E. Wheeler +dhoss: Devin Austin + dkubb: Dan Kubb Drew Taylor